* [PATCH] cifs: connect: added option krb5mi which may allow package signing
@ 2014-02-26 13:46 Lorenz Bucher
2014-02-26 20:26 ` Jeff Layton
0 siblings, 1 reply; 7+ messages in thread
From: Lorenz Bucher @ 2014-02-26 13:46 UTC (permalink / raw)
To: sfrench; +Cc: linux-cifs, samba-technical, linux-kernel, lorenz.bucher
Solves an issue with dfs where servers using package signing are
mixed with servers which don't use package signing.
Signed-off-by: Lorenz Bucher <lorenz.bucher@gmx.de>
---
fs/cifs/connect.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 56c152d..9d06dd8 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -1104,6 +1104,9 @@ cifs_parse_mount_options(const char *mountdata, const char *devname,
if (!value || !*value) {
cERROR(1, "no security value specified");
continue;
+ } else if (strnicmp(value, "krb5mi", 6) == 0) {
+ vol->secFlg |= CIFSSEC_MAY_KRB5 |
+ CIFSSEC_MAY_SIGN;
} else if (strnicmp(value, "krb5i", 5) == 0) {
vol->secFlg |= CIFSSEC_MAY_KRB5 |
CIFSSEC_MUST_SIGN;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] cifs: connect: added option krb5mi which may allow package signing
2014-02-26 13:46 [PATCH] cifs: connect: added option krb5mi which may allow package signing Lorenz Bucher
@ 2014-02-26 20:26 ` Jeff Layton
0 siblings, 0 replies; 7+ messages in thread
From: Jeff Layton @ 2014-02-26 20:26 UTC (permalink / raw)
To: Lorenz Bucher
Cc: sfrench-eUNUBHrolfbYtjvyW6yDsg,
linux-cifs-u79uwXL29TY76Z2rM5mHXA,
samba-technical-w/Ol4Ecudpl8XjKLYN78aQ,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Wed, 26 Feb 2014 14:46:47 +0100
"Lorenz Bucher" <Lorenz.Bucher-Mmb7MZpHnFY@public.gmane.org> wrote:
> Solves an issue with dfs where servers using package signing are
> mixed with servers which don't use package signing.
>
> Signed-off-by: Lorenz Bucher <lorenz.bucher-Mmb7MZpHnFY@public.gmane.org>
> ---
> fs/cifs/connect.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 56c152d..9d06dd8 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -1104,6 +1104,9 @@ cifs_parse_mount_options(const char *mountdata, const char *devname,
> if (!value || !*value) {
> cERROR(1, "no security value specified");
> continue;
> + } else if (strnicmp(value, "krb5mi", 6) == 0) {
> + vol->secFlg |= CIFSSEC_MAY_KRB5 |
> + CIFSSEC_MAY_SIGN;
> } else if (strnicmp(value, "krb5i", 5) == 0) {
> vol->secFlg |= CIFSSEC_MAY_KRB5 |
> CIFSSEC_MUST_SIGN;
This looks like it applies to a really old kernel. I think that problem
was what commit 0b7bc84000d71f3647ca33ab1bf5bd928535c846 was intended
to fix.
--
Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] cifs: connect: added option krb5mi which may allow package signing
@ 2014-02-26 20:26 ` Jeff Layton
0 siblings, 0 replies; 7+ messages in thread
From: Jeff Layton @ 2014-02-26 20:26 UTC (permalink / raw)
To: Lorenz Bucher; +Cc: sfrench, linux-cifs, samba-technical, linux-kernel
On Wed, 26 Feb 2014 14:46:47 +0100
"Lorenz Bucher" <Lorenz.Bucher@gmx.de> wrote:
> Solves an issue with dfs where servers using package signing are
> mixed with servers which don't use package signing.
>
> Signed-off-by: Lorenz Bucher <lorenz.bucher@gmx.de>
> ---
> fs/cifs/connect.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 56c152d..9d06dd8 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -1104,6 +1104,9 @@ cifs_parse_mount_options(const char *mountdata, const char *devname,
> if (!value || !*value) {
> cERROR(1, "no security value specified");
> continue;
> + } else if (strnicmp(value, "krb5mi", 6) == 0) {
> + vol->secFlg |= CIFSSEC_MAY_KRB5 |
> + CIFSSEC_MAY_SIGN;
> } else if (strnicmp(value, "krb5i", 5) == 0) {
> vol->secFlg |= CIFSSEC_MAY_KRB5 |
> CIFSSEC_MUST_SIGN;
This looks like it applies to a really old kernel. I think that problem
was what commit 0b7bc84000d71f3647ca33ab1bf5bd928535c846 was intended
to fix.
--
Jeff Layton <jlayton@samba.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Aw: Re: [PATCH] cifs: connect: added option krb5mi which may allow package signing
2014-02-26 20:26 ` Jeff Layton
@ 2014-02-27 9:13 ` Lorenz Bucher
-1 siblings, 0 replies; 7+ messages in thread
From: Lorenz Bucher @ 2014-02-27 9:13 UTC (permalink / raw)
To: Jeff Layton
Cc: sfrench-eUNUBHrolfbYtjvyW6yDsg,
linux-cifs-u79uwXL29TY76Z2rM5mHXA,
samba-technical-w/Ol4Ecudpl8XjKLYN78aQ,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Gesendet: Mittwoch, 26. Februar 2014 um 21:26 Uhr
Von: "Jeff Layton" <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
An: "Lorenz Bucher" <Lorenz.Bucher-Mmb7MZpHnFY@public.gmane.org>
Cc: sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, samba-technical@lists.samba.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Betreff: Re: [PATCH] cifs: connect: added option krb5mi which may allow package signing
On Wed, 26 Feb 2014 14:46:47 +0100
"Lorenz Bucher" <Lorenz.Bucher-Mmb7MZpHnFY@public.gmane.org> wrote:
> Solves an issue with dfs where servers using package signing are
> mixed with servers which don't use package signing.
>
> Signed-off-by: Lorenz Bucher <lorenz.bucher-Mmb7MZpHnFY@public.gmane.org>
> ---
> fs/cifs/connect.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 56c152d..9d06dd8 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -1104,6 +1104,9 @@ cifs_parse_mount_options(const char *mountdata, const char *devname,
> if (!value || !*value) {
> cERROR(1, "no security value specified");
> continue;
> + } else if (strnicmp(value, "krb5mi", 6) == 0) {
> + vol->secFlg |= CIFSSEC_MAY_KRB5 |
> + CIFSSEC_MAY_SIGN;
> } else if (strnicmp(value, "krb5i", 5) == 0) {
> vol->secFlg |= CIFSSEC_MAY_KRB5 |
> CIFSSEC_MUST_SIGN;
This looks like it applies to a really old kernel. I think that problem
was what commit 0b7bc84000d71f3647ca33ab1bf5bd928535c846 was intended
to fix.
--
Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
Its the current kernel from LTS Ubuntu 12.04
3.2.0-59-generic #90-Ubuntu SMP Tue Jan 7 22:43:51 UTC 2014
^ permalink raw reply [flat|nested] 7+ messages in thread
* Aw: Re: [PATCH] cifs: connect: added option krb5mi which may allow package signing
@ 2014-02-27 9:13 ` Lorenz Bucher
0 siblings, 0 replies; 7+ messages in thread
From: Lorenz Bucher @ 2014-02-27 9:13 UTC (permalink / raw)
To: Jeff Layton; +Cc: sfrench, linux-cifs, samba-technical, linux-kernel
Gesendet: Mittwoch, 26. Februar 2014 um 21:26 Uhr
Von: "Jeff Layton" <jlayton@samba.org>
An: "Lorenz Bucher" <Lorenz.Bucher@gmx.de>
Cc: sfrench@samba.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org
Betreff: Re: [PATCH] cifs: connect: added option krb5mi which may allow package signing
On Wed, 26 Feb 2014 14:46:47 +0100
"Lorenz Bucher" <Lorenz.Bucher@gmx.de> wrote:
> Solves an issue with dfs where servers using package signing are
> mixed with servers which don't use package signing.
>
> Signed-off-by: Lorenz Bucher <lorenz.bucher@gmx.de>
> ---
> fs/cifs/connect.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 56c152d..9d06dd8 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -1104,6 +1104,9 @@ cifs_parse_mount_options(const char *mountdata, const char *devname,
> if (!value || !*value) {
> cERROR(1, "no security value specified");
> continue;
> + } else if (strnicmp(value, "krb5mi", 6) == 0) {
> + vol->secFlg |= CIFSSEC_MAY_KRB5 |
> + CIFSSEC_MAY_SIGN;
> } else if (strnicmp(value, "krb5i", 5) == 0) {
> vol->secFlg |= CIFSSEC_MAY_KRB5 |
> CIFSSEC_MUST_SIGN;
This looks like it applies to a really old kernel. I think that problem
was what commit 0b7bc84000d71f3647ca33ab1bf5bd928535c846 was intended
to fix.
--
Jeff Layton <jlayton@samba.org>
Its the current kernel from LTS Ubuntu 12.04
3.2.0-59-generic #90-Ubuntu SMP Tue Jan 7 22:43:51 UTC 2014
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] cifs: connect: added option krb5mi which may allow package signing
2014-02-27 9:13 ` Lorenz Bucher
@ 2014-02-27 15:03 ` Jeff Layton
-1 siblings, 0 replies; 7+ messages in thread
From: Jeff Layton @ 2014-02-27 15:03 UTC (permalink / raw)
To: Lorenz Bucher
Cc: sfrench-eUNUBHrolfbYtjvyW6yDsg,
linux-cifs-u79uwXL29TY76Z2rM5mHXA,
samba-technical-w/Ol4Ecudpl8XjKLYN78aQ,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Thu, 27 Feb 2014 10:13:14 +0100
"Lorenz Bucher" <Lorenz.Bucher-Mmb7MZpHnFY@public.gmane.org> wrote:
>
>
>
>
> Gesendet: Mittwoch, 26. Februar 2014 um 21:26 Uhr
> Von: "Jeff Layton" <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
> An: "Lorenz Bucher" <Lorenz.Bucher-Mmb7MZpHnFY@public.gmane.org>
> Cc: sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Betreff: Re: [PATCH] cifs: connect: added option krb5mi which may allow package signing
> On Wed, 26 Feb 2014 14:46:47 +0100
> "Lorenz Bucher" <Lorenz.Bucher-Mmb7MZpHnFY@public.gmane.org> wrote:
>
> > Solves an issue with dfs where servers using package signing are
> > mixed with servers which don't use package signing.
> >
> > Signed-off-by: Lorenz Bucher <lorenz.bucher-Mmb7MZpHnFY@public.gmane.org>
> > ---
> > fs/cifs/connect.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> > index 56c152d..9d06dd8 100644
> > --- a/fs/cifs/connect.c
> > +++ b/fs/cifs/connect.c
> > @@ -1104,6 +1104,9 @@ cifs_parse_mount_options(const char *mountdata, const char *devname,
> > if (!value || !*value) {
> > cERROR(1, "no security value specified");
> > continue;
> > + } else if (strnicmp(value, "krb5mi", 6) == 0) {
> > + vol->secFlg |= CIFSSEC_MAY_KRB5 |
> > + CIFSSEC_MAY_SIGN;
> > } else if (strnicmp(value, "krb5i", 5) == 0) {
> > vol->secFlg |= CIFSSEC_MAY_KRB5 |
> > CIFSSEC_MUST_SIGN;
>
> This looks like it applies to a really old kernel. I think that problem
> was what commit 0b7bc84000d71f3647ca33ab1bf5bd928535c846 was intended
> to fix.
>
> --
> Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
>
> Its the current kernel from LTS Ubuntu 12.04
> 3.2.0-59-generic #90-Ubuntu SMP Tue Jan 7 22:43:51 UTC 2014
>
Yep, that kernel is pretty old.
You're probably best off asking the ubuntu kernel maintainers to take
that patch (or asking them to backport 0b7bc84000d). It should
be reasonably safe but they'll have to make that call.
--
Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] cifs: connect: added option krb5mi which may allow package signing
@ 2014-02-27 15:03 ` Jeff Layton
0 siblings, 0 replies; 7+ messages in thread
From: Jeff Layton @ 2014-02-27 15:03 UTC (permalink / raw)
To: Lorenz Bucher; +Cc: sfrench, linux-cifs, samba-technical, linux-kernel
On Thu, 27 Feb 2014 10:13:14 +0100
"Lorenz Bucher" <Lorenz.Bucher@gmx.de> wrote:
>
>
>
>
> Gesendet: Mittwoch, 26. Februar 2014 um 21:26 Uhr
> Von: "Jeff Layton" <jlayton@samba.org>
> An: "Lorenz Bucher" <Lorenz.Bucher@gmx.de>
> Cc: sfrench@samba.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org
> Betreff: Re: [PATCH] cifs: connect: added option krb5mi which may allow package signing
> On Wed, 26 Feb 2014 14:46:47 +0100
> "Lorenz Bucher" <Lorenz.Bucher@gmx.de> wrote:
>
> > Solves an issue with dfs where servers using package signing are
> > mixed with servers which don't use package signing.
> >
> > Signed-off-by: Lorenz Bucher <lorenz.bucher@gmx.de>
> > ---
> > fs/cifs/connect.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> > index 56c152d..9d06dd8 100644
> > --- a/fs/cifs/connect.c
> > +++ b/fs/cifs/connect.c
> > @@ -1104,6 +1104,9 @@ cifs_parse_mount_options(const char *mountdata, const char *devname,
> > if (!value || !*value) {
> > cERROR(1, "no security value specified");
> > continue;
> > + } else if (strnicmp(value, "krb5mi", 6) == 0) {
> > + vol->secFlg |= CIFSSEC_MAY_KRB5 |
> > + CIFSSEC_MAY_SIGN;
> > } else if (strnicmp(value, "krb5i", 5) == 0) {
> > vol->secFlg |= CIFSSEC_MAY_KRB5 |
> > CIFSSEC_MUST_SIGN;
>
> This looks like it applies to a really old kernel. I think that problem
> was what commit 0b7bc84000d71f3647ca33ab1bf5bd928535c846 was intended
> to fix.
>
> --
> Jeff Layton <jlayton@samba.org>
>
> Its the current kernel from LTS Ubuntu 12.04
> 3.2.0-59-generic #90-Ubuntu SMP Tue Jan 7 22:43:51 UTC 2014
>
Yep, that kernel is pretty old.
You're probably best off asking the ubuntu kernel maintainers to take
that patch (or asking them to backport 0b7bc84000d). It should
be reasonably safe but they'll have to make that call.
--
Jeff Layton <jlayton@samba.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-02-27 15:03 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-26 13:46 [PATCH] cifs: connect: added option krb5mi which may allow package signing Lorenz Bucher
2014-02-26 20:26 ` Jeff Layton
2014-02-26 20:26 ` Jeff Layton
[not found] ` <20140226122634.1190167e-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2014-02-27 9:13 ` Aw: " Lorenz Bucher
2014-02-27 9:13 ` Lorenz Bucher
2014-02-27 15:03 ` Jeff Layton
2014-02-27 15:03 ` Jeff Layton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.