All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Turquette <mturquette@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: devicetree@vger.kernel.org,
	Saravana Kannan <skannan@codeaurora.org>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Mark Brown <broonie@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] devicetree: bindings: qcom, mmcc: Document GDSC binding
Date: Tue, 29 Apr 2014 00:07:37 -0700	[thread overview]
Message-ID: <20140429070737.7224.72350@quantum> (raw)
In-Reply-To: <1396637136-29974-5-git-send-email-sboyd@codeaurora.org>

Quoting Stephen Boyd (2014-04-04 11:45:36)
> +Example:
> +       clock-controller@4000000 {
> +               compatible = "qcom,mmcc-msm8974";
> +               reg = <0x4000000 0x1000>;
> +               #clock-cells = <1>;
> +               #reset-cells = <1>;
> +
> +               regulators {
> +                       gdsc_oxili_gx: gdsc_oxili_gx {
> +                               regulator-name = "gdsc_oxili_gx";

Hi Stephen,

It makes sense to model the gdsc's as regulators. It also makes sense to
nest them within the clock-controller node, assuming that matches the
register manual for your part.

However, does it make sense to put this new code under drivers/clk/qcom?
I don't see a compelling reason. How about breaking the registers out
into a header for easier reuse?

Regards,
Mike

> +                               parent-supply = <&pm8841_s4>;
> +                               qcom,retain-mem;
> +                               qcom,retain-periph;
> +                               qcom,skip-logic-collapse;
> +                               qcom,support-hw-trigger;
> +                       };
> +               };
> +       };
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
> 

WARNING: multiple messages have this Message-ID (diff)
From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] devicetree: bindings: qcom, mmcc: Document GDSC binding
Date: Tue, 29 Apr 2014 00:07:37 -0700	[thread overview]
Message-ID: <20140429070737.7224.72350@quantum> (raw)
In-Reply-To: <1396637136-29974-5-git-send-email-sboyd@codeaurora.org>

Quoting Stephen Boyd (2014-04-04 11:45:36)
> +Example:
> +       clock-controller at 4000000 {
> +               compatible = "qcom,mmcc-msm8974";
> +               reg = <0x4000000 0x1000>;
> +               #clock-cells = <1>;
> +               #reset-cells = <1>;
> +
> +               regulators {
> +                       gdsc_oxili_gx: gdsc_oxili_gx {
> +                               regulator-name = "gdsc_oxili_gx";

Hi Stephen,

It makes sense to model the gdsc's as regulators. It also makes sense to
nest them within the clock-controller node, assuming that matches the
register manual for your part.

However, does it make sense to put this new code under drivers/clk/qcom?
I don't see a compelling reason. How about breaking the registers out
into a header for easier reuse?

Regards,
Mike

> +                               parent-supply = <&pm8841_s4>;
> +                               qcom,retain-mem;
> +                               qcom,retain-periph;
> +                               qcom,skip-logic-collapse;
> +                               qcom,support-hw-trigger;
> +                       };
> +               };
> +       };
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
> 

  reply	other threads:[~2014-04-29  7:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-04 18:45 [PATCH 0/4] Support qcom GDSC hardware Stephen Boyd
2014-04-04 18:45 ` Stephen Boyd
2014-04-04 18:45 ` [PATCH 1/4] clk: qcom: Add support for GDSCs Stephen Boyd
2014-04-04 18:45   ` Stephen Boyd
2014-04-04 18:45   ` Stephen Boyd
2014-04-04 18:45 ` [PATCH 2/4] clk: qcom: Add GDSCs within 8974 multimedia clock controller Stephen Boyd
2014-04-04 18:45   ` Stephen Boyd
2014-04-04 18:45 ` [PATCH 3/4] ARM: dts: qcom: Add GDSC nodes underneath " Stephen Boyd
2014-04-04 18:45   ` Stephen Boyd
2014-04-04 18:45   ` Stephen Boyd
2014-04-04 18:45 ` [PATCH 4/4] devicetree: bindings: qcom,mmcc: Document GDSC binding Stephen Boyd
2014-04-04 18:45   ` Stephen Boyd
2014-04-04 18:45   ` Stephen Boyd
2014-04-29  7:07   ` Mike Turquette [this message]
2014-04-29  7:07     ` [PATCH 4/4] devicetree: bindings: qcom, mmcc: " Mike Turquette
2014-04-30 21:16     ` [PATCH 4/4] devicetree: bindings: qcom,mmcc: " Stephen Boyd
2014-04-30 21:16       ` Stephen Boyd
2014-04-15 17:56 ` [PATCH 0/4] Support qcom GDSC hardware Stephen Boyd
2014-04-15 17:56   ` Stephen Boyd
2014-12-19  8:01   ` Ivan T. Ivanov
2014-12-19  8:01     ` Ivan T. Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140429070737.7224.72350@quantum \
    --to=mturquette@linaro.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=skannan@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.