All of lore.kernel.org
 help / color / mirror / Atom feed
From: Feng Tang <feng.tang@intel.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Grant Likely <grant.likely@linaro.org>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Yinghai Lu <yinghai@kernel.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Luck, Tony" <tony.luck@intel.com>,
	Joerg Roedel <joro@8bytes.org>,
	"Gortmaker, Paul (Wind River)" <paul.gortmaker@windriver.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	alek.du@i
Subject: Re: [Patch V4 00/42] use irqdomain to dynamically allocate IRQ for IOAPIC
Date: Sun, 22 Jun 2014 23:02:12 +0800	[thread overview]
Message-ID: <20140622150212.GB20551@feng-snb> (raw)
In-Reply-To: <20140622143946.GA20551@feng-snb>

On Sun, Jun 22, 2014 at 10:39:46PM +0800, Feng Tang wrote:
> Hi,
> 
> On Sun, Jun 22, 2014 at 04:42:27PM +0800, Ingo Molnar wrote:
> > 
> > JFYI, with these patches applied x86 allyes32config fails with:
> > 
> >   arch/x86/platform/intel-mid/device_libs/platform_wdt.c:45:3: error: implicit declaration of function ‘io_apic_set_pci_routing’ 
> 
> In some intel-mid platforms (Medfield/Merrifield etc), the IOAPIC
> may have more than 80 pins, and some devices like a i2c based touch
> screen has its interrupt line directly connected to IOAPIC (this
> platform_wdt.c here should be the same case).
> 
> Since these devices are not PCI device or ACPI device, they can't
> use the general PCI/ACPI xxx_enable_dev APIs which implicitly set
> up the ioapic entry, but use this "io_apic_set_pci_routing"
> directly.

Just quickly read Jiang's patch set, guess these driver should be ok
by using Jiang's new cleaner API "mp_set_gsi_attr()" to replace these
io_apic_set_pci_routing().

Thanks,
Feng
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Feng Tang <feng.tang@intel.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Grant Likely <grant.likely@linaro.org>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Yinghai Lu <yinghai@kernel.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Luck, Tony" <tony.luck@intel.com>,
	Joerg Roedel <joro@8bytes.org>,
	"Gortmaker, Paul (Wind River)" <paul.gortmaker@windriver.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	alek.du@intel.com, mark.gross@intel.com
Subject: Re: [Patch V4 00/42] use irqdomain to dynamically allocate IRQ for IOAPIC
Date: Sun, 22 Jun 2014 23:02:12 +0800	[thread overview]
Message-ID: <20140622150212.GB20551@feng-snb> (raw)
In-Reply-To: <20140622143946.GA20551@feng-snb>

On Sun, Jun 22, 2014 at 10:39:46PM +0800, Feng Tang wrote:
> Hi,
> 
> On Sun, Jun 22, 2014 at 04:42:27PM +0800, Ingo Molnar wrote:
> > 
> > JFYI, with these patches applied x86 allyes32config fails with:
> > 
> >   arch/x86/platform/intel-mid/device_libs/platform_wdt.c:45:3: error: implicit declaration of function ‘io_apic_set_pci_routing’ 
> 
> In some intel-mid platforms (Medfield/Merrifield etc), the IOAPIC
> may have more than 80 pins, and some devices like a i2c based touch
> screen has its interrupt line directly connected to IOAPIC (this
> platform_wdt.c here should be the same case).
> 
> Since these devices are not PCI device or ACPI device, they can't
> use the general PCI/ACPI xxx_enable_dev APIs which implicitly set
> up the ioapic entry, but use this "io_apic_set_pci_routing"
> directly.

Just quickly read Jiang's patch set, guess these driver should be ok
by using Jiang's new cleaner API "mp_set_gsi_attr()" to replace these
io_apic_set_pci_routing().

Thanks,
Feng

  reply	other threads:[~2014-06-22 15:04 UTC|newest]

Thread overview: 129+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-09  8:19 [Patch V4 00/42] use irqdomain to dynamically allocate IRQ for IOAPIC Jiang Liu
2014-06-09  8:19 ` [Patch V4 01/42] x86, irq: update high address field when updating affinity for MSI IRQ Jiang Liu
2014-06-09 23:46   ` Yinghai Lu
2014-06-10  2:54     ` Jiang Liu
2014-06-10  0:22   ` David Rientjes
2014-06-09  8:19 ` [Patch V4 02/42] x86, mpparse: use pr_lvl() helper utilities to replace printk(KERN_LVL) Jiang Liu
2014-06-21 21:09   ` [tip:x86/apic] x86, mpparse: Use " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 03/42] x86, mpparse: simplify arch/x86/include/asm/mpspec.h Jiang Liu
2014-06-21 21:09   ` [tip:x86/apic] x86, mpparse: Simplify arch/x86/include/asm/ mpspec.h tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 04/42] x86, acpi: reorganize code to avoid forward declaration in boot.c Jiang Liu
2014-06-21 21:10   ` [tip:x86/apic] x86, acpi: Reorganize " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 05/42] x86, PCI, ACPI: use kmalloc_node() to optimize for performance Jiang Liu
2014-06-21 21:10   ` [tip:x86/apic] x86, PCI, ACPI: Use " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 06/42] x86, acpi, irq: kill static function irq_to_gsi() Jiang Liu
2014-06-21 21:10   ` [tip:x86/apic] x86, acpi, irq: Kill " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 07/42] x86, ACPI, trivial: minor improvements to arch/x86/kernel/acpi/boot.c Jiang Liu
2014-06-21 21:10   ` [tip:x86/apic] x86, ACPI, trivial: Minor improvements to arch/x86 /kernel/acpi/boot.c tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 08/42] x86, ACPI, irq: enhance error handling in function acpi_register_gsi() Jiang Liu
2014-06-09 23:19   ` Thomas Gleixner
2014-06-10  5:49     ` Jiang Liu
2014-06-10  6:11     ` Jiang Liu
2014-06-21 21:10       ` [tip:x86/apic] x86, ACPI, irq: Enhance " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 09/42] x86, ACPI, irq: fix possible eror in GSI to IRQ mapping for legacy IRQ Jiang Liu
2014-06-21 21:11   ` [tip:x86/apic] x86, ACPI, irq: Fix " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 10/42] x86, irq, trivial: minor improvements of IRQ related code Jiang Liu
2014-06-21 21:11   ` [tip:x86/apic] x86, irq, trivial: Minor " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 11/42] x86, ioapic: kill unused global variable timer_through_8259 Jiang Liu
2014-06-09 14:41   ` Maciej W. Rozycki
2014-06-10  3:20     ` Jiang Liu
2014-06-10 21:57       ` Maciej W. Rozycki
2014-06-21 21:11   ` [tip:x86/apic] x86, ioapic: Kill " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 12/42] x86, ioapic: kill static variable nr_irqs_gsi Jiang Liu
2014-06-09 23:22   ` Thomas Gleixner
2014-06-10  5:31     ` Jiang Liu
2014-06-12 10:58       ` Thomas Gleixner
2014-06-12 12:40         ` Jiang Liu
2014-06-21 21:11   ` [tip:x86/apic] x86, ioapic: Kill " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 13/42] x86, ioapic: introduce helper utilities to walk ioapics and pins Jiang Liu
2014-06-21 21:12   ` [tip:x86/apic] x86, ioapic: Introduce " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 14/42] x86, ioapic: use irq_cfg() instead of irq_get_chip_data() for better readability Jiang Liu
2014-06-21 21:12   ` [tip:x86/apic] x86, ioapic: Use " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 15/42] x86, irq: reorganize IO_APIC_get_PCI_irq_vector() to prepare for irqdomain Jiang Liu
2014-06-21 21:12   ` [tip:x86/apic] x86, irq: Reorganize " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 16/42] x86, irq: introduce some helper utilities to improve readability Jiang Liu
2014-06-21 21:12   ` [tip:x86/apic] x86, irq: Introduce " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 17/42] ce4100, irq: make CE4100 depend on CONFIG_X86_IO_APIC Jiang Liu
2014-06-21 21:12   ` [tip:x86/apic] x86: ce4100, irq: Make " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 18/42] ce4100, irq: do not set legacy_pic to null_legacy_pic Jiang Liu
2014-06-21 21:13   ` [tip:x86/apic] x86: ce4100, irq: Do " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 19/42] x86, irq: count legacy IRQs by legacy_pic->nr_legacy_irqs instead of NR_IRQS_LEGACY Jiang Liu
2014-06-10 14:18   ` [Xen-devel] " David Vrabel
2014-06-10 14:18     ` David Vrabel
2014-06-10 14:18   ` David Vrabel
2014-06-21 21:13   ` [tip:x86/apic] x86, irq: Count legacy IRQs by legacy_pic-> nr_legacy_irqs " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 19/42] x86, irq: count legacy IRQs by legacy_pic->nr_legacy_irqs " Jiang Liu
2014-06-09  8:19 ` [Patch V4 20/42] x86, irq: simplify arch_early_irq_init() Jiang Liu
2014-06-21 21:13   ` [tip:x86/apic] x86, irq: Simplify arch_early_irq_init() tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 21/42] x86, ACPI, irq: consolidate algorithm of mapping (ioapic, pin) to IRQ number Jiang Liu
2014-06-10  6:13   ` Jiang Liu
2014-06-21 21:13     ` [tip:x86/apic] x86, ACPI, irq: Consolidate algorithm of mapping ( ioapic, " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 22/42] x86, irq, ACPI: change __acpi_register_gsi to return IRQ number instead of GSI Jiang Liu
2014-06-10  6:14   ` Jiang Liu
2014-06-21 21:14     ` [tip:x86/apic] x86, irq, ACPI: Change " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 23/42] x86, irq: introduce mechanisms to support dynamically allocate IRQ for IOAPIC Jiang Liu
2014-06-21 21:14   ` [tip:x86/apic] x86, irq: Introduce " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 24/42] x86, irq: enhance mp_register_ioapic() to support irqdomain Jiang Liu
2014-06-21 21:14   ` [tip:x86/apic] x86, irq: Enhance " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 25/42] x86, ACPI, irq: provide basic irqdomain support Jiang Liu
2014-06-21 21:14   ` [tip:x86/apic] x86, ACPI, irq: Provide " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 26/42] x86, mpparse, irq: provide " Jiang Liu
2014-06-21 21:14   ` [tip:x86/apic] x86, mpparse, irq: Provide " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 27/42] x86, SFI, irq: provide " Jiang Liu
2014-06-09  8:19   ` Jiang Liu
2014-06-21 21:15   ` [tip:x86/apic] x86, SFI, irq: Provide " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 28/42] x86, devicetree, irq: use common mechanism to support irqdomain Jiang Liu
2014-06-21 21:15   ` [tip:x86/apic] x86, devicetree, irq: Use " tip-bot for Jiang Liu
2014-06-09  8:19 ` [Patch V4 29/42] x86, irq: introduce two helper functions to support irqdomain map operation Jiang Liu
2014-06-21 21:15   ` [tip:x86/apic] x86, irq: Introduce " tip-bot for Jiang Liu
2014-08-21 14:17   ` [Patch V4 29/42] x86, irq: introduce " Mika Westerberg
2014-08-21 16:57     ` Mika Westerberg
2014-08-21 19:00       ` Jiang Liu
2014-08-22 12:41         ` Mika Westerberg
2014-08-26  8:45           ` [Bugfix] x86, irq: Fix bug in setting IOAPIC pin attributes Jiang Liu
2014-08-26  9:52             ` Mika Westerberg
2014-08-26 21:20               ` Thomas Gleixner
2014-08-27  5:53               ` Jiang Liu
2014-08-27  8:04                 ` Mika Westerberg
2014-08-27  9:15                 ` [tip:x86/urgent] x86: " tip-bot for Jiang Liu
2014-08-26 18:55             ` [Bugfix] x86, " Randy Dunlap
2014-06-09  8:19 ` [Patch V4 30/42] x86, irq, ACPI: use common irqdomain map interface to program IOAPIC pins Jiang Liu
2014-06-21 21:15   ` [tip:x86/apic] x86, irq, ACPI: Use " tip-bot for Jiang Liu
2014-06-09  8:20 ` [Patch V4 31/42] x86, irq, mpparse: use " Jiang Liu
2014-06-21 21:16   ` [tip:x86/apic] x86, irq, mpparse: Use " tip-bot for Jiang Liu
2014-06-09  8:20 ` [Patch V4 32/42] x86, irq, SFI: use " Jiang Liu
2014-06-09  8:20   ` Jiang Liu
2014-06-21 21:16   ` [tip:x86/apic] x86, irq, SFI: Use " tip-bot for Jiang Liu
2014-06-09  8:20 ` [Patch V4 33/42] x86, irq, devicetree: use " Jiang Liu
2014-06-21 21:16   ` [tip:x86/apic] x86, irq, devicetree: Use " tip-bot for Jiang Liu
2014-06-09  8:20 ` [Patch V4 34/42] x86, irq: clean up unused IOAPIC interface Jiang Liu
2014-06-21 21:16   ` [tip:x86/apic] x86, irq: Clean " tip-bot for Jiang Liu
2014-06-09  8:20 ` [Patch V4 35/42] x86, irq: simplify the way to handle ISA IRQ Jiang Liu
2014-06-21 21:16   ` [tip:x86/apic] x86, irq: Simplify " tip-bot for Jiang Liu
2014-06-09  8:20 ` [Patch V4 36/42] genirq: export irq_domain_disassociate() to architecture interrupt drivers Jiang Liu
2014-06-21 21:06   ` [tip:irq/core] genirq: Export " tip-bot for Jiang Liu
2014-06-09  8:20 ` [Patch V4 37/42] x86, irq: introduce helper functions to release IOAPIC pin Jiang Liu
2014-06-21 21:17   ` [tip:x86/apic] x86, irq: Introduce " tip-bot for Jiang Liu
2014-06-09  8:20 ` [Patch V4 38/42] x86, irq, ACPI: release IOAPIC pin when PCI device is disabled Jiang Liu
2014-06-10  6:16   ` Jiang Liu
2014-06-21 21:17     ` [tip:x86/apic] x86, irq, ACPI: Release " tip-bot for Jiang Liu
2014-06-09  8:20 ` [Patch V4 39/42] x86, irq, mpparse: release " Jiang Liu
2014-06-21 21:17   ` [tip:x86/apic] x86, irq, mpparse: Release " tip-bot for Jiang Liu
2014-06-09  8:20 ` [Patch V4 40/42] x86, irq, SFI: release " Jiang Liu
2014-06-21 21:17   ` [tip:x86/apic] x86, irq, SFI: Release " tip-bot for Jiang Liu
2014-06-09  8:20 ` [Patch V4 41/42] x86, irq, devicetree: release " Jiang Liu
2014-06-21 21:18   ` [tip:x86/apic] x86, irq, devicetree: Release " tip-bot for Jiang Liu
2014-06-09  8:20 ` [Patch V4 42/42] x86, irq: clean up irqdomain transition code Jiang Liu
2014-06-21 21:18   ` [tip:x86/apic] x86, irq: Clean " tip-bot for Jiang Liu
2014-06-21 21:08 ` [Patch V4 00/42] use irqdomain to dynamically allocate IRQ for IOAPIC Thomas Gleixner
2014-06-27  3:36   ` Yinghai Lu
2014-06-22  8:42 ` Ingo Molnar
2014-06-22 14:39   ` Feng Tang
2014-06-22 14:39     ` Feng Tang
2014-06-22 15:02     ` Feng Tang [this message]
2014-06-22 15:02       ` Feng Tang
2014-06-23  2:30   ` [Patch] x86: intel-mid: fix conflicts between 78a3bb9e408b and 9f354b0252b8 Jiang Liu
2014-06-23 17:38     ` David Cohen
2014-06-26 19:33       ` David Cohen
2014-06-27  0:37         ` Jiang Liu
2014-07-14 18:22     ` [tip:x86/apic] x86: intel-mid: Use the new io_apic interfaces tip-bot for Jiang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140622150212.GB20551@feng-snb \
    --to=feng.tang@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=alek.du@i \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=jiang.liu@linux.intel.com \
    --cc=joro@8bytes.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=rdunlap@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.