[PATCH net-next] netlink: remove bool varible

[PATCH net-next] netlink: remove bool varible

[varkabhadram]

From: Varka Bhadram <varkab@cdac.in>

This patch removes the bool variable 'pass'.
If the swith case exist return true or return false.

Signed-off-by: Varka Bhadram <varkab@cdac.in>
---
 net/netlink/af_netlink.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index e8c9f97..5dd8193 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -170,7 +170,6 @@ EXPORT_SYMBOL_GPL(netlink_remove_tap);
 static bool netlink_filter_tap(const struct sk_buff *skb)
 {
 	struct sock *sk = skb->sk;
-	bool pass = false;
 
 	/* We take the more conservative approach and
 	 * whitelist socket protocols that may pass.
@@ -184,11 +183,10 @@ static bool netlink_filter_tap(const struct sk_buff *skb)
 	case NETLINK_FIB_LOOKUP:
 	case NETLINK_NETFILTER:
 	case NETLINK_GENERIC:
-		pass = true;
-		break;
+		return true;
 	}
 
-	return pass;
+	return false;
 }
 
 static int __netlink_deliver_tap_skb(struct sk_buff *skb,
-- 
1.7.9.5

Re: [PATCH net-next] netlink: remove bool varible

[David Miller]

From: varkabhadram@gmail.com
Date: Wed, 16 Jul 2014 10:59:47 +0530

> From: Varka Bhadram <varkab@cdac.in>
> 
> This patch removes the bool variable 'pass'.
> If the swith case exist return true or return false.
> 
> Signed-off-by: Varka Bhadram <varkab@cdac.in>

This is fine, applied, thanks.