* [PATCH -next] ASoC: rockchip: remove redundant dev_err call in rockchip_i2s_probe()
@ 2014-07-28 13:21 weiyj_lk
2014-07-28 13:46 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: weiyj_lk @ 2014-07-28 13:21 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Grant Likely, Rob Herring, Jianqun Xu
Cc: Wei Yongjun, alsa-devel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
sound/soc/rockchip/rockchip_i2s.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c
index af1d8eb..52ccced 100644
--- a/sound/soc/rockchip/rockchip_i2s.c
+++ b/sound/soc/rockchip/rockchip_i2s.c
@@ -427,10 +427,8 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
regs = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(regs)) {
- dev_err(&pdev->dev, "No memory resource\n");
+ if (IS_ERR(regs))
return PTR_ERR(regs);
- }
i2s->regmap = devm_regmap_init_mmio(&pdev->dev, regs,
&rockchip_i2s_regmap_config);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] ASoC: rockchip: remove redundant dev_err call in rockchip_i2s_probe()
2014-07-28 13:21 [PATCH -next] ASoC: rockchip: remove redundant dev_err call in rockchip_i2s_probe() weiyj_lk
@ 2014-07-28 13:46 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-07-28 13:46 UTC (permalink / raw)
To: weiyj_lk
Cc: alsa-devel, Jianqun Xu, Takashi Iwai, Liam Girdwood, Wei Yongjun,
Rob Herring, Grant Likely
[-- Attachment #1.1: Type: text/plain, Size: 277 bytes --]
On Mon, Jul 28, 2014 at 09:21:00PM +0800, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-28 13:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-28 13:21 [PATCH -next] ASoC: rockchip: remove redundant dev_err call in rockchip_i2s_probe() weiyj_lk
2014-07-28 13:46 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.