All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Boris BREZILLON <boris.brezillon@free-electrons.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Andrew Victor <linux@maxim.org.za>,
	Alessandro Zummo <a.zummo@towertech.it>,
	rtc-linux@googlegroups.com, Johan Hovold <jhovold@gmail.com>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Douglas Gilbert <dgilbert@interlog.com>
Subject: Re: [PATCH v3 8/8] rtc: at91sam9: add DT bindings documentation
Date: Thu, 11 Sep 2014 11:42:13 +0200	[thread overview]
Message-ID: <20140911094213.GC12295@localhost> (raw)
In-Reply-To: <1410425767-17874-9-git-send-email-boris.brezillon@free-electrons.com>

On Thu, Sep 11, 2014 at 10:56:07AM +0200, Boris BREZILLON wrote:
> Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com>
> ---
>  .../devicetree/bindings/rtc/atmel,at91sam9-rtc.txt | 24 ++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt
> 
> diff --git a/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt b/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt
> new file mode 100644
> index 0000000..258a036
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt
> @@ -0,0 +1,24 @@
> +Atmel AT91SAM9260 Real Time Timer
> +
> +Required properties:
> +- compatible: should be: "atmel,at91sam9260-rtt"
> +- reg: should encode the memory region of the RTT controller
> +- interrupts: rtc alarm/event interrupt
> +- clocks: should contain one clock pointing the the slow clk
> +- atmel,time-reg: should encode the GPBR register used to store the RTC
> +		  time. The first cell should point to the GPBR node and
> +		  the second one encode the offset within the GPBR block
> +		  (or in other terms, the GPBR register used to store the
> +		  current time value).
> +
> +
> +
> +Example:
> +
> +rtc@fffffe00 {

This should be rtt@

> +	compatible = "atmel,at91sam9260-rtt";
> +	reg = <0xfffffd20 0x10>;
> +	interrupts = <1 4 7>;
> +	clocks = <&clk32k>;
> +	atmel,time-reg = <&gpbr 0x0>;

I think the property name could be more descriptive as it is specific to
when the RTT is used as an RTC. Perhaps, atmel,rtt-rtc-time-reg?

> +};

Johan

WARNING: multiple messages have this Message-ID (diff)
From: johan@kernel.org (Johan Hovold)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 8/8] rtc: at91sam9: add DT bindings documentation
Date: Thu, 11 Sep 2014 11:42:13 +0200	[thread overview]
Message-ID: <20140911094213.GC12295@localhost> (raw)
In-Reply-To: <1410425767-17874-9-git-send-email-boris.brezillon@free-electrons.com>

On Thu, Sep 11, 2014 at 10:56:07AM +0200, Boris BREZILLON wrote:
> Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com>
> ---
>  .../devicetree/bindings/rtc/atmel,at91sam9-rtc.txt | 24 ++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt
> 
> diff --git a/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt b/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt
> new file mode 100644
> index 0000000..258a036
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.txt
> @@ -0,0 +1,24 @@
> +Atmel AT91SAM9260 Real Time Timer
> +
> +Required properties:
> +- compatible: should be: "atmel,at91sam9260-rtt"
> +- reg: should encode the memory region of the RTT controller
> +- interrupts: rtc alarm/event interrupt
> +- clocks: should contain one clock pointing the the slow clk
> +- atmel,time-reg: should encode the GPBR register used to store the RTC
> +		  time. The first cell should point to the GPBR node and
> +		  the second one encode the offset within the GPBR block
> +		  (or in other terms, the GPBR register used to store the
> +		  current time value).
> +
> +
> +
> +Example:
> +
> +rtc at fffffe00 {

This should be rtt@

> +	compatible = "atmel,at91sam9260-rtt";
> +	reg = <0xfffffd20 0x10>;
> +	interrupts = <1 4 7>;
> +	clocks = <&clk32k>;
> +	atmel,time-reg = <&gpbr 0x0>;

I think the property name could be more descriptive as it is specific to
when the RTT is used as an RTC. Perhaps, atmel,rtt-rtc-time-reg?

> +};

Johan

  reply	other threads:[~2014-09-11  9:44 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11  8:55 [PATCH v3 0/8] rtc: at91sam9: add DT support Boris BREZILLON
2014-09-11  8:55 ` Boris BREZILLON
2014-09-11  8:56 ` [PATCH v3 1/8] rtc: at91sam9: remove references to mach specific headers Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56 ` [PATCH v3 2/8] rtc: at91sam9: use standard readl/writel functions instead of raw versions Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56 ` [PATCH v3 3/8] rtc: at91sam9: replace devm_ioremap by devm_ioremap_resource Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56 ` [PATCH v3 4/8] rtc: at91sam9: add DT support Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56 ` [PATCH v3 5/8] rtc: at91sam9: make use of syscon/regmap to access GPBR registers Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  9:41   ` Johan Hovold
2014-09-11  9:41     ` Johan Hovold
2014-09-11  9:55     ` Boris BREZILLON
2014-09-11  9:55       ` Boris BREZILLON
2014-09-11  9:55       ` Boris BREZILLON
2014-09-11  8:56 ` [PATCH v3 6/8] ARM: at91: add clk_lookup entry for RTT devices Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56 ` [PATCH v3 7/8] rtc: at91sam9: use clk API instead of relying on AT91_SLOW_CLOCK Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56 ` [PATCH v3 8/8] rtc: at91sam9: add DT bindings documentation Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  8:56   ` Boris BREZILLON
2014-09-11  9:42   ` Johan Hovold [this message]
2014-09-11  9:42     ` Johan Hovold
2014-09-11  9:56     ` Boris BREZILLON
2014-09-11  9:56       ` Boris BREZILLON
2014-09-11  9:56       ` Boris BREZILLON
2014-09-11  9:39 ` [PATCH v3 0/8] rtc: at91sam9: add DT support Johan Hovold
2014-09-11  9:39   ` Johan Hovold
2014-09-11  9:39   ` Johan Hovold
2014-09-11 10:06   ` Boris BREZILLON
2014-09-11 10:06     ` Boris BREZILLON
2014-09-11 10:06     ` Boris BREZILLON
2014-09-11 10:22     ` Johan Hovold
2014-09-11 10:22       ` Johan Hovold
2014-09-11 11:52     ` Nicolas Ferre
2014-09-11 11:52       ` Nicolas Ferre
2014-09-11 11:52       ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140911094213.GC12295@localhost \
    --to=johan@kernel.org \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dgilbert@interlog.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jhovold@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@maxim.org.za \
    --cc=mark.rutland@arm.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=pawel.moll@arm.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=robh+dt@kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.