[PATCH] linux-yocto: Added bc-native as DEPENDS

[PATCH] linux-yocto: Added bc-native as DEPENDS

[Alejandro Hernandez]

The makefile checks for bc during for compilation

[YOCTO #6781]

Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
---
 meta/classes/kernel.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 78b33ce..0782923 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -1,7 +1,7 @@
 inherit linux-kernel-base kernel-module-split
 
 PROVIDES += "virtual/kernel"
-DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native depmodwrapper-cross"
+DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native depmodwrapper-cross bc-native"
 
 # we include gcc above, we dont need virtual/libc
 INHIBIT_DEFAULT_DEPS = "1"
-- 
1.9.1

Re: [PATCH] linux-yocto: Added bc-native as DEPENDS

[Paul Eggleton]

Hi Alejandro,

On Thursday 02 October 2014 10:19:17 Alejandro Hernandez wrote:
> The makefile checks for bc during for compilation
> 
> [YOCTO #6781]
> 
> Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
> ---
>  meta/classes/kernel.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 78b33ce..0782923 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -1,7 +1,7 @@
>  inherit linux-kernel-base kernel-module-split
> 
>  PROVIDES += "virtual/kernel"
> -DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc
> kmod-native depmodwrapper-cross" +DEPENDS +=
> "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native
> depmodwrapper-cross bc-native"
> 
>  # we include gcc above, we dont need virtual/libc
>  INHIBIT_DEFAULT_DEPS = "1"

Since this is a change to kernel.bbclass, the shortlog should start with 
kernel.bbclass (or classes/kernel, whichever you prefer) rather than 
linux-yocto.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH] linux-yocto: Added bc-native as DEPENDS

[Saul Wold]

Alejandro,

Sorry this was my bad, I was not clear on your question to me earlier, 
since this was for the kernel.bbclass it should be

kernel: ...

So please submit corrected v2

Sorry
	Sau!

On 10/02/2014 08:19 AM, Alejandro Hernandez wrote:
> The makefile checks for bc during for compilation
>
> [YOCTO #6781]
>
> Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
> ---
>   meta/classes/kernel.bbclass | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 78b33ce..0782923 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -1,7 +1,7 @@
>   inherit linux-kernel-base kernel-module-split
>
>   PROVIDES += "virtual/kernel"
> -DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native depmodwrapper-cross"
> +DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native depmodwrapper-cross bc-native"
>
>   # we include gcc above, we dont need virtual/libc
>   INHIBIT_DEFAULT_DEPS = "1"
>

Re: [PATCH] linux-yocto: Added bc-native as DEPENDS

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1569 bytes --]

On Thu, Oct 02, 2014 at 10:19:17AM -0500, Alejandro Hernandez wrote:
> The makefile checks for bc during for compilation

It's needed only by 3.9 and newer, so that's why it wasn't globally
required by kernel.bbclass, but only in linux-yocto (3.10+ at that
time) and I've applied it in couple kernel recipes which were building
3.9+.

But bc-native doesn't take so long to build, so I'm not opposed to
depend on it (even when it isn't necessary in some cases).

> 
> [YOCTO #6781]
> 
> Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
> ---
>  meta/classes/kernel.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 78b33ce..0782923 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -1,7 +1,7 @@
>  inherit linux-kernel-base kernel-module-split
>  
>  PROVIDES += "virtual/kernel"
> -DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native depmodwrapper-cross"
> +DEPENDS += "virtual/${TARGET_PREFIX}binutils virtual/${TARGET_PREFIX}gcc kmod-native depmodwrapper-cross bc-native"
>  
>  # we include gcc above, we dont need virtual/libc
>  INHIBIT_DEFAULT_DEPS = "1"
> -- 
> 1.9.1
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]