* [PATCH] arm64: dump: Fix implicit inclusion of definition for PCI_IOBASE
@ 2015-01-12 12:29 Mark Brown
2015-01-12 13:46 ` Mark Rutland
0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2015-01-12 12:29 UTC (permalink / raw)
To: linux-arm-kernel
Since c9465b4ec37a68425 (arm64: add support to dump the kernel page tables)
allmodconfig has failed to build on arm64 as a result of:
../arch/arm64/mm/dump.c:55:20: error: 'PCI_IOBASE' undeclared here (not in a function)
Fix this by explicitly including io.h to ensure that a definition is
present.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
arch/arm64/mm/dump.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c
index cf33f33333cc..258ce731c5cd 100644
--- a/arch/arm64/mm/dump.c
+++ b/arch/arm64/mm/dump.c
@@ -14,6 +14,7 @@
* of the License.
*/
#include <linux/debugfs.h>
+#include <linux/io.h>
#include <linux/fs.h>
#include <linux/mm.h>
#include <linux/sched.h>
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] arm64: dump: Fix implicit inclusion of definition for PCI_IOBASE
2015-01-12 12:29 [PATCH] arm64: dump: Fix implicit inclusion of definition for PCI_IOBASE Mark Brown
@ 2015-01-12 13:46 ` Mark Rutland
2015-01-12 13:49 ` Will Deacon
2015-01-12 15:02 ` Mark Brown
0 siblings, 2 replies; 5+ messages in thread
From: Mark Rutland @ 2015-01-12 13:46 UTC (permalink / raw)
To: linux-arm-kernel
Hi Mark,
On Mon, Jan 12, 2015 at 12:29:44PM +0000, Mark Brown wrote:
> Since c9465b4ec37a68425 (arm64: add support to dump the kernel page tables)
> allmodconfig has failed to build on arm64 as a result of:
>
> ../arch/arm64/mm/dump.c:55:20: error: 'PCI_IOBASE' undeclared here (not in a function)
When I build a v3.19-rc4 allmodconfig, I don't see this failure, but I
agree that we need the explicit include for PCI_IOBASE.
> Fix this by explicitly including io.h to ensure that a definition is
> present.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> arch/arm64/mm/dump.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c
> index cf33f33333cc..258ce731c5cd 100644
> --- a/arch/arm64/mm/dump.c
> +++ b/arch/arm64/mm/dump.c
> @@ -14,6 +14,7 @@
> * of the License.
> */
> #include <linux/debugfs.h>
> +#include <linux/io.h>
> #include <linux/fs.h>
> #include <linux/mm.h>
> #include <linux/sched.h>
Nit: please keep includes ordered (unless there's some other include
issue?).
I see that for other definitions we include the asm headers rather than
linux headers, and we also seem to be missing an include of asm/memory.h
for MODULES_VADDR and PAGE_OFFSET.
Does the below work for you?
Thanks,
Mark.
---->8----
diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c
index cf33f33..88f9ad9 100644
--- a/arch/arm64/mm/dump.c
+++ b/arch/arm64/mm/dump.c
@@ -19,7 +19,9 @@
#include <linux/sched.h>
#include <linux/seq_file.h>
+#include <asm/io.h>
#include <asm/fixmap.h>
+#include <asm/memory.h>
#include <asm/pgtable.h>
#define LOWEST_ADDR (UL(0xffffffffffffffff) << VA_BITS)
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] arm64: dump: Fix implicit inclusion of definition for PCI_IOBASE
2015-01-12 13:46 ` Mark Rutland
@ 2015-01-12 13:49 ` Will Deacon
2015-01-12 15:02 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Will Deacon @ 2015-01-12 13:49 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jan 12, 2015 at 01:46:11PM +0000, Mark Rutland wrote:
> On Mon, Jan 12, 2015 at 12:29:44PM +0000, Mark Brown wrote:
> > Since c9465b4ec37a68425 (arm64: add support to dump the kernel page tables)
> > allmodconfig has failed to build on arm64 as a result of:
> >
> > ../arch/arm64/mm/dump.c:55:20: error: 'PCI_IOBASE' undeclared here (not in a function)
>
> When I build a v3.19-rc4 allmodconfig, I don't see this failure, but I
> agree that we need the explicit include for PCI_IOBASE.
It's one of the failures in -next, but it didn't get resolved by Paul's
series unfortunately (I probably just did a defconfig build for that).
Will
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm64: dump: Fix implicit inclusion of definition for PCI_IOBASE
2015-01-12 13:46 ` Mark Rutland
2015-01-12 13:49 ` Will Deacon
@ 2015-01-12 15:02 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2015-01-12 15:02 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jan 12, 2015 at 01:46:11PM +0000, Mark Rutland wrote:
> I see that for other definitions we include the asm headers rather than
> linux headers, and we also seem to be missing an include of asm/memory.h
> for MODULES_VADDR and PAGE_OFFSET.
> Does the below work for you?
Should do.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150112/955dc12d/attachment.sig>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] arm64: dump: Fix implicit inclusion of definition for PCI_IOBASE
@ 2015-01-22 20:52 Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2015-01-22 20:52 UTC (permalink / raw)
To: linux-arm-kernel
Since c9465b4ec37a68425 (arm64: add support to dump the kernel page tables)
allmodconfig has failed to build on arm64 as a result of:
../arch/arm64/mm/dump.c:55:20: error: 'PCI_IOBASE' undeclared here (not in a function)
Fix this by explicitly including io.h to ensure that a definition is
present.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
As discussed the other day the quick stop gap for the implicit inclusion
issues that are breaking -next builds at the minute.
arch/arm64/mm/dump.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c
index cf33f33333cc..d54dc9ac4b70 100644
--- a/arch/arm64/mm/dump.c
+++ b/arch/arm64/mm/dump.c
@@ -15,6 +15,7 @@
*/
#include <linux/debugfs.h>
#include <linux/fs.h>
+#include <linux/io.h>
#include <linux/mm.h>
#include <linux/sched.h>
#include <linux/seq_file.h>
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-01-22 20:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-12 12:29 [PATCH] arm64: dump: Fix implicit inclusion of definition for PCI_IOBASE Mark Brown
2015-01-12 13:46 ` Mark Rutland
2015-01-12 13:49 ` Will Deacon
2015-01-12 15:02 ` Mark Brown
2015-01-22 20:52 Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.