* [PATCH iproute2] ss: Filter inet dgram sockets with established state by default
@ 2015-01-08 17:32 Vadim Kochan
2015-01-14 1:31 ` Stephen Hemminger
0 siblings, 1 reply; 7+ messages in thread
From: Vadim Kochan @ 2015-01-08 17:32 UTC (permalink / raw)
To: netdev; +Cc: Vadim Kochan
From: Vadim Kochan <vadim4j@gmail.com>
As inet dgram sockets (udp, raw) can call connect(...) - they
might be set in ESTABLISHED state. So keep the original behaviour of
'ss' which filtered them by ESTABLISHED state by default. So:
$ ss -u
or
$ ss -w
Will show only ESTABLISHED UDP sockets by default.
Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
---
misc/ss.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/misc/ss.c b/misc/ss.c
index 08d210a..015d829 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -170,11 +170,11 @@ static const struct filter default_dbs[MAX_DB] = {
.families = (1 << AF_INET) | (1 << AF_INET6),
},
[UDP_DB] = {
- .states = (1 << SS_CLOSE),
+ .states = (1 << SS_ESTABLISHED),
.families = (1 << AF_INET) | (1 << AF_INET6),
},
[RAW_DB] = {
- .states = (1 << SS_CLOSE),
+ .states = (1 << SS_ESTABLISHED),
.families = (1 << AF_INET) | (1 << AF_INET6),
},
[UNIX_DG_DB] = {
--
2.1.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH iproute2] ss: Filter inet dgram sockets with established state by default
2015-01-08 17:32 [PATCH iproute2] ss: Filter inet dgram sockets with established state by default Vadim Kochan
@ 2015-01-14 1:31 ` Stephen Hemminger
2015-01-14 6:49 ` Vadim Kochan
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Hemminger @ 2015-01-14 1:31 UTC (permalink / raw)
To: Vadim Kochan; +Cc: netdev
On Thu, 8 Jan 2015 19:32:22 +0200
Vadim Kochan <vadim4j@gmail.com> wrote:
> From: Vadim Kochan <vadim4j@gmail.com>
>
> As inet dgram sockets (udp, raw) can call connect(...) - they
> might be set in ESTABLISHED state. So keep the original behaviour of
> 'ss' which filtered them by ESTABLISHED state by default. So:
>
> $ ss -u
>
> or
>
> $ ss -w
>
> Will show only ESTABLISHED UDP sockets by default.
>
> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> ---
> misc/ss.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/misc/ss.c b/misc/ss.c
> index 08d210a..015d829 100644
> --- a/misc/ss.c
> +++ b/misc/ss.c
> @@ -170,11 +170,11 @@ static const struct filter default_dbs[MAX_DB] = {
> .families = (1 << AF_INET) | (1 << AF_INET6),
> },
> [UDP_DB] = {
> - .states = (1 << SS_CLOSE),
> + .states = (1 << SS_ESTABLISHED),
> .families = (1 << AF_INET) | (1 << AF_INET6),
> },
> [RAW_DB] = {
> - .states = (1 << SS_CLOSE),
> + .states = (1 << SS_ESTABLISHED),
> .families = (1 << AF_INET) | (1 << AF_INET6),
> },
> [UNIX_DG_DB] = {
This is a change likely to break somebody using 'ss -u' now and the bound
sockets will disappear from the output.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH iproute2] ss: Filter inet dgram sockets with established state by default
2015-01-14 1:31 ` Stephen Hemminger
@ 2015-01-14 6:49 ` Vadim Kochan
2015-01-14 22:41 ` Stephen Hemminger
0 siblings, 1 reply; 7+ messages in thread
From: Vadim Kochan @ 2015-01-14 6:49 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Vadim Kochan, netdev
On Tue, Jan 13, 2015 at 05:31:50PM -0800, Stephen Hemminger wrote:
> On Thu, 8 Jan 2015 19:32:22 +0200
> Vadim Kochan <vadim4j@gmail.com> wrote:
>
> > From: Vadim Kochan <vadim4j@gmail.com>
> >
> > As inet dgram sockets (udp, raw) can call connect(...) - they
> > might be set in ESTABLISHED state. So keep the original behaviour of
> > 'ss' which filtered them by ESTABLISHED state by default. So:
> >
> > $ ss -u
> >
> > or
> >
> > $ ss -w
> >
> > Will show only ESTABLISHED UDP sockets by default.
> >
> > Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> > ---
> > misc/ss.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/misc/ss.c b/misc/ss.c
> > index 08d210a..015d829 100644
> > --- a/misc/ss.c
> > +++ b/misc/ss.c
> > @@ -170,11 +170,11 @@ static const struct filter default_dbs[MAX_DB] = {
> > .families = (1 << AF_INET) | (1 << AF_INET6),
> > },
> > [UDP_DB] = {
> > - .states = (1 << SS_CLOSE),
> > + .states = (1 << SS_ESTABLISHED),
> > .families = (1 << AF_INET) | (1 << AF_INET6),
> > },
> > [RAW_DB] = {
> > - .states = (1 << SS_CLOSE),
> > + .states = (1 << SS_ESTABLISHED),
> > .families = (1 << AF_INET) | (1 << AF_INET6),
> > },
> > [UNIX_DG_DB] = {
>
> This is a change likely to break somebody using 'ss -u' now and the bound
> sockets will disappear from the output.
>
But thats was as original behaviour before I added table-driven code
(about few commits ago), so thats a rather fix (sorry I did not noticed
about it) to keep the previous behaviour for dgram sockets - show
established states by default.
Regards,
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH iproute2] ss: Filter inet dgram sockets with established state by default
2015-01-14 6:49 ` Vadim Kochan
@ 2015-01-14 22:41 ` Stephen Hemminger
2015-01-14 22:43 ` Vadim Kochan
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Hemminger @ 2015-01-14 22:41 UTC (permalink / raw)
To: Vadim Kochan; +Cc: netdev
On Wed, 14 Jan 2015 08:49:44 +0200
Vadim Kochan <vadim4j@gmail.com> wrote:
> On Tue, Jan 13, 2015 at 05:31:50PM -0800, Stephen Hemminger wrote:
> > On Thu, 8 Jan 2015 19:32:22 +0200
> > Vadim Kochan <vadim4j@gmail.com> wrote:
> >
> > > From: Vadim Kochan <vadim4j@gmail.com>
> > >
> > > As inet dgram sockets (udp, raw) can call connect(...) - they
> > > might be set in ESTABLISHED state. So keep the original behaviour of
> > > 'ss' which filtered them by ESTABLISHED state by default. So:
> > >
> > > $ ss -u
> > >
> > > or
> > >
> > > $ ss -w
> > >
> > > Will show only ESTABLISHED UDP sockets by default.
> > >
> > > Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> > > ---
> > > misc/ss.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/misc/ss.c b/misc/ss.c
> > > index 08d210a..015d829 100644
> > > --- a/misc/ss.c
> > > +++ b/misc/ss.c
> > > @@ -170,11 +170,11 @@ static const struct filter default_dbs[MAX_DB] = {
> > > .families = (1 << AF_INET) | (1 << AF_INET6),
> > > },
> > > [UDP_DB] = {
> > > - .states = (1 << SS_CLOSE),
> > > + .states = (1 << SS_ESTABLISHED),
> > > .families = (1 << AF_INET) | (1 << AF_INET6),
> > > },
> > > [RAW_DB] = {
> > > - .states = (1 << SS_CLOSE),
> > > + .states = (1 << SS_ESTABLISHED),
> > > .families = (1 << AF_INET) | (1 << AF_INET6),
> > > },
> > > [UNIX_DG_DB] = {
> >
> > This is a change likely to break somebody using 'ss -u' now and the bound
> > sockets will disappear from the output.
> >
>
> But thats was as original behaviour before I added table-driven code
> (about few commits ago), so thats a rather fix (sorry I did not noticed
> about it) to keep the previous behaviour for dgram sockets - show
> established states by default.
>
> Regards,
Ok, I will merge it and update the comments.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH iproute2] ss: Filter inet dgram sockets with established state by default
2015-01-14 22:41 ` Stephen Hemminger
@ 2015-01-14 22:43 ` Vadim Kochan
2015-01-15 2:48 ` Stephen Hemminger
0 siblings, 1 reply; 7+ messages in thread
From: Vadim Kochan @ 2015-01-14 22:43 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Vadim Kochan, netdev
On Wed, Jan 14, 2015 at 02:41:20PM -0800, Stephen Hemminger wrote:
> On Wed, 14 Jan 2015 08:49:44 +0200
> Vadim Kochan <vadim4j@gmail.com> wrote:
>
> > On Tue, Jan 13, 2015 at 05:31:50PM -0800, Stephen Hemminger wrote:
> > > On Thu, 8 Jan 2015 19:32:22 +0200
> > > Vadim Kochan <vadim4j@gmail.com> wrote:
> > >
> > > > From: Vadim Kochan <vadim4j@gmail.com>
> > > >
> > > > As inet dgram sockets (udp, raw) can call connect(...) - they
> > > > might be set in ESTABLISHED state. So keep the original behaviour of
> > > > 'ss' which filtered them by ESTABLISHED state by default. So:
> > > >
> > > > $ ss -u
> > > >
> > > > or
> > > >
> > > > $ ss -w
> > > >
> > > > Will show only ESTABLISHED UDP sockets by default.
> > > >
> > > > Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> > > > ---
> > > > misc/ss.c | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/misc/ss.c b/misc/ss.c
> > > > index 08d210a..015d829 100644
> > > > --- a/misc/ss.c
> > > > +++ b/misc/ss.c
> > > > @@ -170,11 +170,11 @@ static const struct filter default_dbs[MAX_DB] = {
> > > > .families = (1 << AF_INET) | (1 << AF_INET6),
> > > > },
> > > > [UDP_DB] = {
> > > > - .states = (1 << SS_CLOSE),
> > > > + .states = (1 << SS_ESTABLISHED),
> > > > .families = (1 << AF_INET) | (1 << AF_INET6),
> > > > },
> > > > [RAW_DB] = {
> > > > - .states = (1 << SS_CLOSE),
> > > > + .states = (1 << SS_ESTABLISHED),
> > > > .families = (1 << AF_INET) | (1 << AF_INET6),
> > > > },
> > > > [UNIX_DG_DB] = {
> > >
> > > This is a change likely to break somebody using 'ss -u' now and the bound
> > > sockets will disappear from the output.
> > >
> >
> > But thats was as original behaviour before I added table-driven code
> > (about few commits ago), so thats a rather fix (sorry I did not noticed
> > about it) to keep the previous behaviour for dgram sockets - show
> > established states by default.
> >
> > Regards,
>
> Ok, I will merge it and update the comments.
Even with this PATCH I am still confused what is preferred behaviour -
show established dgram sockets (as it was all the way) or closed + established by default.
What do you think ?
Thanks,
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH iproute2] ss: Filter inet dgram sockets with established state by default
2015-01-14 22:43 ` Vadim Kochan
@ 2015-01-15 2:48 ` Stephen Hemminger
2015-01-15 4:49 ` Vadim Kochan
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Hemminger @ 2015-01-15 2:48 UTC (permalink / raw)
To: Vadim Kochan; +Cc: netdev
On Thu, 15 Jan 2015 00:43:47 +0200
Vadim Kochan <vadim4j@gmail.com> wrote:
> On Wed, Jan 14, 2015 at 02:41:20PM -0800, Stephen Hemminger wrote:
> > On Wed, 14 Jan 2015 08:49:44 +0200
> > Vadim Kochan <vadim4j@gmail.com> wrote:
> >
> > > On Tue, Jan 13, 2015 at 05:31:50PM -0800, Stephen Hemminger wrote:
> > > > On Thu, 8 Jan 2015 19:32:22 +0200
> > > > Vadim Kochan <vadim4j@gmail.com> wrote:
> > > >
> > > > > From: Vadim Kochan <vadim4j@gmail.com>
> > > > >
> > > > > As inet dgram sockets (udp, raw) can call connect(...) - they
> > > > > might be set in ESTABLISHED state. So keep the original behaviour of
> > > > > 'ss' which filtered them by ESTABLISHED state by default. So:
> > > > >
> > > > > $ ss -u
> > > > >
> > > > > or
> > > > >
> > > > > $ ss -w
> > > > >
> > > > > Will show only ESTABLISHED UDP sockets by default.
> > > > >
> > > > > Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> > > > > ---
> > > > > misc/ss.c | 4 ++--
> > > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git a/misc/ss.c b/misc/ss.c
> > > > > index 08d210a..015d829 100644
> > > > > --- a/misc/ss.c
> > > > > +++ b/misc/ss.c
> > > > > @@ -170,11 +170,11 @@ static const struct filter default_dbs[MAX_DB] = {
> > > > > .families = (1 << AF_INET) | (1 << AF_INET6),
> > > > > },
> > > > > [UDP_DB] = {
> > > > > - .states = (1 << SS_CLOSE),
> > > > > + .states = (1 << SS_ESTABLISHED),
> > > > > .families = (1 << AF_INET) | (1 << AF_INET6),
> > > > > },
> > > > > [RAW_DB] = {
> > > > > - .states = (1 << SS_CLOSE),
> > > > > + .states = (1 << SS_ESTABLISHED),
> > > > > .families = (1 << AF_INET) | (1 << AF_INET6),
> > > > > },
> > > > > [UNIX_DG_DB] = {
> > > >
> > > > This is a change likely to break somebody using 'ss -u' now and the bound
> > > > sockets will disappear from the output.
> > > >
> > >
> > > But thats was as original behaviour before I added table-driven code
> > > (about few commits ago), so thats a rather fix (sorry I did not noticed
> > > about it) to keep the previous behaviour for dgram sockets - show
> > > established states by default.
> > >
> > > Regards,
> >
> > Ok, I will merge it and update the comments.
> Even with this PATCH I am still confused what is preferred behaviour -
> show established dgram sockets (as it was all the way) or closed + established by default.
>
> What do you think ?
>
> Thanks,
Make it work like earliest releases (like 3 months ago).
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH iproute2] ss: Filter inet dgram sockets with established state by default
2015-01-15 2:48 ` Stephen Hemminger
@ 2015-01-15 4:49 ` Vadim Kochan
0 siblings, 0 replies; 7+ messages in thread
From: Vadim Kochan @ 2015-01-15 4:49 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
So it means showing by established state by default.
On Thu, Jan 15, 2015 at 4:48 AM, Stephen Hemminger
<stephen@networkplumber.org> wrote:
> On Thu, 15 Jan 2015 00:43:47 +0200
> Vadim Kochan <vadim4j@gmail.com> wrote:
>
>> On Wed, Jan 14, 2015 at 02:41:20PM -0800, Stephen Hemminger wrote:
>> > On Wed, 14 Jan 2015 08:49:44 +0200
>> > Vadim Kochan <vadim4j@gmail.com> wrote:
>> >
>> > > On Tue, Jan 13, 2015 at 05:31:50PM -0800, Stephen Hemminger wrote:
>> > > > On Thu, 8 Jan 2015 19:32:22 +0200
>> > > > Vadim Kochan <vadim4j@gmail.com> wrote:
>> > > >
>> > > > > From: Vadim Kochan <vadim4j@gmail.com>
>> > > > >
>> > > > > As inet dgram sockets (udp, raw) can call connect(...) - they
>> > > > > might be set in ESTABLISHED state. So keep the original behaviour of
>> > > > > 'ss' which filtered them by ESTABLISHED state by default. So:
>> > > > >
>> > > > > $ ss -u
>> > > > >
>> > > > > or
>> > > > >
>> > > > > $ ss -w
>> > > > >
>> > > > > Will show only ESTABLISHED UDP sockets by default.
>> > > > >
>> > > > > Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
>> > > > > ---
>> > > > > misc/ss.c | 4 ++--
>> > > > > 1 file changed, 2 insertions(+), 2 deletions(-)
>> > > > >
>> > > > > diff --git a/misc/ss.c b/misc/ss.c
>> > > > > index 08d210a..015d829 100644
>> > > > > --- a/misc/ss.c
>> > > > > +++ b/misc/ss.c
>> > > > > @@ -170,11 +170,11 @@ static const struct filter default_dbs[MAX_DB] = {
>> > > > > .families = (1 << AF_INET) | (1 << AF_INET6),
>> > > > > },
>> > > > > [UDP_DB] = {
>> > > > > - .states = (1 << SS_CLOSE),
>> > > > > + .states = (1 << SS_ESTABLISHED),
>> > > > > .families = (1 << AF_INET) | (1 << AF_INET6),
>> > > > > },
>> > > > > [RAW_DB] = {
>> > > > > - .states = (1 << SS_CLOSE),
>> > > > > + .states = (1 << SS_ESTABLISHED),
>> > > > > .families = (1 << AF_INET) | (1 << AF_INET6),
>> > > > > },
>> > > > > [UNIX_DG_DB] = {
>> > > >
>> > > > This is a change likely to break somebody using 'ss -u' now and the bound
>> > > > sockets will disappear from the output.
>> > > >
>> > >
>> > > But thats was as original behaviour before I added table-driven code
>> > > (about few commits ago), so thats a rather fix (sorry I did not noticed
>> > > about it) to keep the previous behaviour for dgram sockets - show
>> > > established states by default.
>> > >
>> > > Regards,
>> >
>> > Ok, I will merge it and update the comments.
>> Even with this PATCH I am still confused what is preferred behaviour -
>> show established dgram sockets (as it was all the way) or closed + established by default.
>>
>> What do you think ?
>>
>> Thanks,
>
> Make it work like earliest releases (like 3 months ago).
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-01-15 4:49 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-08 17:32 [PATCH iproute2] ss: Filter inet dgram sockets with established state by default Vadim Kochan
2015-01-14 1:31 ` Stephen Hemminger
2015-01-14 6:49 ` Vadim Kochan
2015-01-14 22:41 ` Stephen Hemminger
2015-01-14 22:43 ` Vadim Kochan
2015-01-15 2:48 ` Stephen Hemminger
2015-01-15 4:49 ` Vadim Kochan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.