Re: [PATCH v6 0/7] Add initial support for DA9150 Charger & Fuel-Gauge IC

From: Sebastian Reichel <sre@kernel.org>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
	Lee Jones <lee.jones@linaro.org>,
	Jonathan Cameron <jic23@kernel.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	Hartmut Knaack <knaack.h@gmx.de>,
	linux-iio@vger.kernel.org,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	linux-pm@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Grant Likely <grant.likely@linaro.org>,
	devicetree@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Joe Perches <joe@perches.com>,
	linux-kernel@vger.kernel.org, support.opensource@diasemi.com
Subject: Re: [PATCH v6 0/7] Add initial support for DA9150 Charger & Fuel-Gauge IC
Date: Wed, 21 Jan 2015 17:52:50 +0100	[thread overview]
Message-ID: <20150121165250.GG13715@earth.universe> (raw)
In-Reply-To: <cover.1421854282.git.Adam.Thomson.Opensource@diasemi.com>

[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]

Hi,

On Wed, Jan 21, 2015 at 03:46:25PM +0000, Adam Thomson wrote:
> This patch set adds initial support for the Dialog DA9150 Integrated Charger &
> Fuel-Gauge IC. The device also provides GPIO and GPADC functionality.
> 
> In this patch set the following is provided:
>  - MFD Core support and DT bindings documentation.
>  - IIO GPADC support and DT bindings documentation.
>  - Power Supply Charger support and DT bindings documentation.
>  - Update to MAINTAINERS file to add DA9150 files to Dialog support list.
> 
> To keep patch submission from being too large, support for GPIO and Fuel-Gauge
> will come after initial support patches are accepted.
> 
> This patch set is baselined against the v3.19-rc5 kernel version.
> 
> Changes in v6:
> - For GPADC driver, Use lower case extended names for IIO GPADC channels, and
>   remove extended names for GPIO related channels.
> - For charger driver, revert to no devm IRQ request/free functions as ordering
>   is important, and probe failure scenario was not being correctly covered. A
>   helper function for free IRQs has been added to make code cleaner.

Probably a devm_ variant of power_supply_register should be created,
but for now this is ok for me.

Jonathan, Lee: I assume you are ok with the whole patchset going
through the power supply subsystem?

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]