Re: [PATCH 1/6] clk: make strings in parent name arrays const

From: Sascha Hauer <s.hauer@pengutronix.de>
To: Joe Perches <joe@perches.com>
Cc: Mike Turquette <mturquette@linaro.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	YH Chen <yh.chen@mediatek.com>,
	linux-kernel@vger.kernel.org,
	Henry Chen <henryc.chen@mediatek.com>,
	linux-mediatek@lists.infradead.org, kernel@pengutronix.de,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Yingjoe Chen <Yingjoe.Chen@mediatek.com>,
	Eddie Huang <eddie.huang@mediatek.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/6] clk: make strings in parent name arrays const
Date: Mon, 30 Mar 2015 20:16:57 +0200	[thread overview]
Message-ID: <20150330181657.GF9742@pengutronix.de> (raw)
In-Reply-To: <1427738119.14276.19.camel@perches.com>

On Mon, Mar 30, 2015 at 10:55:19AM -0700, Joe Perches wrote:
> On Mon, 2015-03-30 at 19:40 +0200, Sascha Hauer wrote:
> > The clk functions and structs declare the parent_name arrays as
> > 'const char **parent_names' which means the parent name strings
> > are const, but the array itself is not. Use
> > 'const char * const * parent_names' instead which also makes
> > the array const. This allows us to put the parent_name arrays into
> > the __initconst section.
> 
> If these are pointer entries are stored, care needs to be
> taken to make sure that the memory isn't discarded or needed
> post init.

The clock framework makes deep copies of all initialization data
structures.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |