From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> To: Lina Iyer <lina.iyer@linaro.org> Cc: Kumar Gala <galak@codeaurora.org>, Catalin Marinas <Catalin.Marinas@arm.com>, Device Tree Mailing List <devicetree@vger.kernel.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org>, Will Deacon <Will.Deacon@arm.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "arm@kernel.org" <arm@kernel.org>, Abhimanyu Kapur <abhimany@codeaurora.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [RFC PATCH 0/5] Add smp booting support for Qualcomm ARMv8 SoCs Date: Wed, 15 Apr 2015 18:35:13 +0100 [thread overview] Message-ID: <20150415173513.GE23758@red-moon> (raw) In-Reply-To: <20150415161759.GB1111@linaro.org> On Wed, Apr 15, 2015 at 05:17:59PM +0100, Lina Iyer wrote: > On Tue, Apr 14 2015 at 16:32 -0600, Lorenzo Pieralisi wrote: > >On Tue, Apr 14, 2015 at 03:21:17PM +0100, Kumar Gala wrote: > > > >[...] > > > >> > Looking beyond this set of patches, I can foresee that you won't care > >> > about the generic arm64 cpuidle driver either, or more precisely the > >> > separation between cpuidle subsystem+driver and the SoC-specific > >> > back-end (cpu_operations). > >> > >> That's probably true for what I guess are a number of reasons. I'm guessing the arm64 cpuidle driver expects PSCI. > > > >Wrap lines sensibly please. > > > >The arm64 cpuidle driver, that is now arm generic cpuidle driver does > >not expect anything apart from an enable-method (and you pulled > >part of its back-end implementation for arm32 Qualcomm platforms, FYI). > > > The backend for this SoC would leverage the same platform code as ARM32. > The cpu_operations callbacks for init and suspend will call into the the > same platform functions used by arm32 QCOM SoCs. It is understood, but this does not mean we should merge this patchset, actually it is the other way around. It was extremely complicated to factor out some common CPUidle bits because of the prolification of power down interfaces in arm/mach code, each with its quirks du jour. If we had a standard interface (that encompasses what all ARM mach code power interfaces do, basically PSCI) when arm32 power management code was being pushed upstream we would not have that power management arm/mach code today. PSCI is there to solve that problem, and it predates v8, there is no reason to merge code that provides no added value (I am obviously talking about the pseudo-boot protocol this patchset is enabling, not the platforms themselves which we definitely want to support upstream, with some preconditions that are equal for everyone) and to leverage a legacy that does not exist for arm64. Thanks, Lorenzo > > Thanks, > Lina > > >It took years to consolidate it and the main reason was the lack of > >standard interfaces for power down/up sequences that this patchset of > >yours wants to promote in arm64 world. > > > >The lack of standard power interfaces may not have been an issue for you, > >who cares about Qualcomm code, it has been a sore issue for people > >trying to generalize things across ARM platforms in the kernel, which is > >the only sensible way forward. > > > >PSCI is a standard interface (and Qualcomm are already contributing to > >it, for the records) that can certainly be extended, and you are welcome > >to contribute to it, but certainly not ignored. > > > >Thanks, > >Lorenzo > >-- > >To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > >the body of a message to majordomo@vger.kernel.org > >More majordomo info at http://vger.kernel.org/majordomo-info.html >
WARNING: multiple messages have this Message-ID (diff)
From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi) To: linux-arm-kernel@lists.infradead.org Subject: [RFC PATCH 0/5] Add smp booting support for Qualcomm ARMv8 SoCs Date: Wed, 15 Apr 2015 18:35:13 +0100 [thread overview] Message-ID: <20150415173513.GE23758@red-moon> (raw) In-Reply-To: <20150415161759.GB1111@linaro.org> On Wed, Apr 15, 2015 at 05:17:59PM +0100, Lina Iyer wrote: > On Tue, Apr 14 2015 at 16:32 -0600, Lorenzo Pieralisi wrote: > >On Tue, Apr 14, 2015 at 03:21:17PM +0100, Kumar Gala wrote: > > > >[...] > > > >> > Looking beyond this set of patches, I can foresee that you won't care > >> > about the generic arm64 cpuidle driver either, or more precisely the > >> > separation between cpuidle subsystem+driver and the SoC-specific > >> > back-end (cpu_operations). > >> > >> That's probably true for what I guess are a number of reasons. I'm guessing the arm64 cpuidle driver expects PSCI. > > > >Wrap lines sensibly please. > > > >The arm64 cpuidle driver, that is now arm generic cpuidle driver does > >not expect anything apart from an enable-method (and you pulled > >part of its back-end implementation for arm32 Qualcomm platforms, FYI). > > > The backend for this SoC would leverage the same platform code as ARM32. > The cpu_operations callbacks for init and suspend will call into the the > same platform functions used by arm32 QCOM SoCs. It is understood, but this does not mean we should merge this patchset, actually it is the other way around. It was extremely complicated to factor out some common CPUidle bits because of the prolification of power down interfaces in arm/mach code, each with its quirks du jour. If we had a standard interface (that encompasses what all ARM mach code power interfaces do, basically PSCI) when arm32 power management code was being pushed upstream we would not have that power management arm/mach code today. PSCI is there to solve that problem, and it predates v8, there is no reason to merge code that provides no added value (I am obviously talking about the pseudo-boot protocol this patchset is enabling, not the platforms themselves which we definitely want to support upstream, with some preconditions that are equal for everyone) and to leverage a legacy that does not exist for arm64. Thanks, Lorenzo > > Thanks, > Lina > > >It took years to consolidate it and the main reason was the lack of > >standard interfaces for power down/up sequences that this patchset of > >yours wants to promote in arm64 world. > > > >The lack of standard power interfaces may not have been an issue for you, > >who cares about Qualcomm code, it has been a sore issue for people > >trying to generalize things across ARM platforms in the kernel, which is > >the only sensible way forward. > > > >PSCI is a standard interface (and Qualcomm are already contributing to > >it, for the records) that can certainly be extended, and you are welcome > >to contribute to it, but certainly not ignored. > > > >Thanks, > >Lorenzo > >-- > >To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > >the body of a message to majordomo at vger.kernel.org > >More majordomo info at http://vger.kernel.org/majordomo-info.html >
next prev parent reply other threads:[~2015-04-15 17:35 UTC|newest] Thread overview: 132+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-09 17:37 [RFC PATCH 0/5] Add smp booting support for Qualcomm ARMv8 SoCs Kumar Gala 2015-04-09 17:37 ` Kumar Gala 2015-04-09 17:37 ` [RFC PATCH 1/5] firmware: qcom: scm: Split out 32-bit specific SCM code Kumar Gala 2015-04-09 17:37 ` Kumar Gala 2015-04-09 17:37 ` [RFC PATCH 2/5] firmware: qcom: scm: Add support for ARM64 SoCs Kumar Gala 2015-04-09 17:37 ` Kumar Gala 2015-04-09 17:37 ` [RFC PATCH 3/5] arm64: introduce CPU_OF_TABLES for cpu ops selection Kumar Gala 2015-04-09 17:37 ` Kumar Gala 2015-04-09 21:17 ` Arnd Bergmann 2015-04-09 21:17 ` Arnd Bergmann 2015-04-14 15:52 ` Mark Rutland 2015-04-14 15:52 ` Mark Rutland 2015-04-14 15:52 ` Mark Rutland 2015-04-10 10:28 ` Lorenzo Pieralisi 2015-04-10 10:28 ` Lorenzo Pieralisi 2015-04-10 10:28 ` Lorenzo Pieralisi 2015-04-09 17:37 ` [RFC PATCH 4/5] arm64: smp: move the pen to a header file Kumar Gala 2015-04-09 17:37 ` Kumar Gala 2015-04-09 21:17 ` Arnd Bergmann 2015-04-09 21:17 ` Arnd Bergmann 2015-04-14 19:41 ` Kumar Gala 2015-04-14 19:41 ` Kumar Gala 2015-04-14 15:59 ` Mark Rutland 2015-04-14 15:59 ` Mark Rutland 2015-04-14 15:59 ` Mark Rutland 2015-04-14 19:40 ` Kumar Gala 2015-04-14 19:40 ` Kumar Gala 2015-04-14 19:40 ` Kumar Gala [not found] ` <1428601031-5366-1-git-send-email-galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2015-04-09 17:37 ` [RFC PATCH 5/5] arm64: qcom: add cpu operations Kumar Gala 2015-04-09 17:37 ` Kumar Gala 2015-04-09 17:37 ` Kumar Gala 2015-04-09 21:19 ` Arnd Bergmann 2015-04-09 21:19 ` Arnd Bergmann 2015-04-10 10:08 ` Catalin Marinas 2015-04-10 10:08 ` Catalin Marinas 2015-04-10 10:08 ` Catalin Marinas 2015-04-10 10:39 ` Lorenzo Pieralisi 2015-04-10 10:39 ` Lorenzo Pieralisi 2015-04-10 10:39 ` Lorenzo Pieralisi 2015-04-14 16:29 ` Mark Rutland 2015-04-14 16:29 ` Mark Rutland 2015-04-14 16:29 ` Mark Rutland 2015-04-14 20:51 ` Arnd Bergmann 2015-04-14 20:51 ` Arnd Bergmann 2015-04-15 14:46 ` Catalin Marinas 2015-04-15 14:46 ` Catalin Marinas 2015-04-15 14:46 ` Catalin Marinas 2015-04-14 22:52 ` Al Stone 2015-04-14 22:52 ` Al Stone 2015-04-14 22:52 ` Al Stone 2015-04-15 9:04 ` Mark Rutland 2015-04-15 9:04 ` Mark Rutland 2015-04-15 9:04 ` Mark Rutland 2015-04-15 14:53 ` Catalin Marinas 2015-04-15 14:53 ` Catalin Marinas 2015-04-15 14:53 ` Catalin Marinas 2015-04-15 16:29 ` Al Stone 2015-04-15 16:29 ` Al Stone 2015-04-15 16:29 ` Al Stone 2015-04-10 10:05 ` [RFC PATCH 0/5] Add smp booting support for Qualcomm ARMv8 SoCs Catalin Marinas 2015-04-10 10:05 ` Catalin Marinas [not found] ` <20150410100529.GA6854-M2fw3Uu6cmfZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org> 2015-04-10 15:24 ` Kumar Gala 2015-04-10 15:24 ` Kumar Gala 2015-04-10 15:24 ` Kumar Gala [not found] ` <493B15F8-0EBE-4633-9604-671EF403F36E-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2015-04-10 16:10 ` Catalin Marinas 2015-04-10 16:10 ` Catalin Marinas 2015-04-10 16:10 ` Catalin Marinas 2015-04-10 19:06 ` Kumar Gala 2015-04-10 19:06 ` Kumar Gala 2015-04-13 9:41 ` Catalin Marinas 2015-04-13 9:41 ` Catalin Marinas 2015-04-14 14:21 ` Kumar Gala 2015-04-14 14:21 ` Kumar Gala 2015-04-14 14:21 ` Kumar Gala 2015-04-14 14:44 ` Kumar Gala 2015-04-14 14:44 ` Kumar Gala 2015-04-14 15:45 ` Mark Rutland 2015-04-14 15:45 ` Mark Rutland 2015-04-14 15:45 ` Mark Rutland 2015-04-14 22:32 ` Lorenzo Pieralisi 2015-04-14 22:32 ` Lorenzo Pieralisi 2015-04-14 22:32 ` Lorenzo Pieralisi 2015-04-15 16:17 ` Lina Iyer 2015-04-15 16:17 ` Lina Iyer 2015-04-15 16:17 ` Lina Iyer 2015-04-15 17:35 ` Lorenzo Pieralisi [this message] 2015-04-15 17:35 ` Lorenzo Pieralisi 2015-04-15 17:35 ` Lorenzo Pieralisi 2015-04-15 14:27 ` Catalin Marinas 2015-04-15 14:27 ` Catalin Marinas 2015-04-14 16:36 ` Mark Rutland 2015-04-14 16:36 ` Mark Rutland 2015-04-14 16:36 ` Mark Rutland 2015-04-14 19:49 ` Kumar Gala 2015-04-14 19:49 ` Kumar Gala 2015-04-14 19:49 ` Kumar Gala 2015-04-14 21:17 ` Catalin Marinas 2015-04-14 21:17 ` Catalin Marinas 2015-04-14 21:17 ` Catalin Marinas 2015-04-14 21:48 ` Rob Clark 2015-04-14 21:48 ` Rob Clark 2015-04-14 21:48 ` Rob Clark [not found] ` <CAF6AEGtoxNrCoxT5n0CXmKMnL-YprJ3DkAuM4Myi87WMxPqBGw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-04-15 13:34 ` Catalin Marinas 2015-04-15 13:34 ` Catalin Marinas 2015-04-15 13:34 ` Catalin Marinas 2015-04-15 15:01 ` Rob Clark 2015-04-15 15:01 ` Rob Clark 2015-04-15 15:01 ` Rob Clark 2015-04-16 15:21 ` Catalin Marinas 2015-04-16 15:21 ` Catalin Marinas 2015-04-16 15:21 ` Catalin Marinas [not found] ` <20150416152121.GE819-M2fw3Uu6cmfZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org> 2015-04-16 17:17 ` Rob Clark 2015-04-16 17:17 ` Rob Clark 2015-04-16 17:17 ` Rob Clark [not found] ` <CAF6AEGt3bf70MUWFU_kqtc8KDR09tMUCkXbqOq0SpOXU44moTg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2015-04-16 21:39 ` Catalin Marinas 2015-04-16 21:39 ` Catalin Marinas 2015-04-16 21:39 ` Catalin Marinas 2015-04-16 22:03 ` Matt Sealey 2015-04-16 22:03 ` Matt Sealey 2015-04-16 22:03 ` Matt Sealey 2015-04-10 11:03 ` Lorenzo Pieralisi 2015-04-10 11:03 ` Lorenzo Pieralisi 2015-04-10 11:03 ` Lorenzo Pieralisi 2015-04-10 15:25 ` Kumar Gala 2015-04-10 15:25 ` Kumar Gala 2015-04-10 15:25 ` Kumar Gala 2015-04-10 16:07 ` Lorenzo Pieralisi 2015-04-10 16:07 ` Lorenzo Pieralisi 2015-04-10 16:07 ` Lorenzo Pieralisi 2015-04-16 22:08 ` Rob Herring 2015-04-10 20:43 Kumar Gala 2015-04-10 20:43 ` Kumar Gala
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20150415173513.GE23758@red-moon \ --to=lorenzo.pieralisi@arm.com \ --cc=Catalin.Marinas@arm.com \ --cc=Will.Deacon@arm.com \ --cc=abhimany@codeaurora.org \ --cc=arm@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=galak@codeaurora.org \ --cc=lina.iyer@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.