All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com, linux-kernel@vger.kernel.org, peterz@infradead.org
Subject: Re: [PATCH 1/2] percpu_counter: batch size aware __percpu_counter_compare()
Date: Wed, 13 May 2015 09:59:19 -0400	[thread overview]
Message-ID: <20150513135919.GS11388@htj.duckdns.org> (raw)
In-Reply-To: <1431474754-15764-2-git-send-email-david@fromorbit.com>

Hello, Dave.

On Wed, May 13, 2015 at 09:52:33AM +1000, Dave Chinner wrote:
> @@ -116,6 +121,12 @@ static inline int percpu_counter_compare(struct percpu_counter *fbc, s64 rhs)
>  		return 0;
>  }
>  
> +static inline int
> +percpu_counter_compare(struct percpu_counter *fbc, s64 rhs, s32 batch)
> +{
> +	return percpu_counter_compare(fbc, rhs);
> +}

I don't think this is right.  Looks fine to me otherwise.

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Dave Chinner <david@fromorbit.com>
Cc: peterz@infradead.org, linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] percpu_counter: batch size aware __percpu_counter_compare()
Date: Wed, 13 May 2015 09:59:19 -0400	[thread overview]
Message-ID: <20150513135919.GS11388@htj.duckdns.org> (raw)
In-Reply-To: <1431474754-15764-2-git-send-email-david@fromorbit.com>

Hello, Dave.

On Wed, May 13, 2015 at 09:52:33AM +1000, Dave Chinner wrote:
> @@ -116,6 +121,12 @@ static inline int percpu_counter_compare(struct percpu_counter *fbc, s64 rhs)
>  		return 0;
>  }
>  
> +static inline int
> +percpu_counter_compare(struct percpu_counter *fbc, s64 rhs, s32 batch)
> +{
> +	return percpu_counter_compare(fbc, rhs);
> +}

I don't think this is right.  Looks fine to me otherwise.

Thanks.

-- 
tejun

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2015-05-13 13:59 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12 23:52 [PATCH 0/2 v2] percpu_counter: xfs requires custom compare batch size Dave Chinner
2015-05-12 23:52 ` Dave Chinner
2015-05-12 23:52 ` [PATCH 1/2] percpu_counter: batch size aware __percpu_counter_compare() Dave Chinner
2015-05-12 23:52   ` Dave Chinner
2015-05-13 13:59   ` Tejun Heo [this message]
2015-05-13 13:59     ` Tejun Heo
2015-05-14  0:55     ` Dave Chinner
2015-05-14  0:55       ` Dave Chinner
2015-05-14 15:02       ` Tejun Heo
2015-05-14 15:02         ` Tejun Heo
2015-05-12 23:52 ` [PATCH 2/2] xfs: inode and free block counters need to use __percpu_counter_compare Dave Chinner
2015-05-12 23:52   ` Dave Chinner
2015-05-14 14:21   ` Brian Foster
2015-05-14 14:21     ` Brian Foster
  -- strict thread matches above, loose matches on Subject: below --
2015-05-05 22:01 [PATCH 0/2] xfs: fix inode count underrun Dave Chinner
2015-05-05 22:01 ` [PATCH 1/2] percpu_counter: batch size aware __percpu_counter_compare() Dave Chinner
2015-05-05 22:01   ` Dave Chinner
2015-05-06  4:36   ` Christoph Hellwig
2015-05-06  4:36     ` Christoph Hellwig
2015-05-06  4:46     ` Christoph Hellwig
2015-05-06  4:46       ` Christoph Hellwig
2015-05-06  5:43     ` Dave Chinner
2015-05-06  5:43       ` Dave Chinner
2015-05-06  5:53       ` Dave Chinner
2015-05-06  5:53         ` Dave Chinner
2015-05-06  6:11         ` Dave Chinner
2015-05-06  6:11           ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150513135919.GS11388@htj.duckdns.org \
    --to=tj@kernel.org \
    --cc=david@fromorbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.