* [Buildroot] [PATCHv4] Makefile: fix performance regression casued by the umask handling
@ 2015-07-16 22:33 Yann E. MORIN
2015-07-16 22:35 ` Arnout Vandecappelle
2015-07-18 9:31 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: Yann E. MORIN @ 2015-07-16 22:33 UTC (permalink / raw)
To: buildroot
From: Guido Mart?nez <guido@vanguardiasur.com.ar>
Commit bee5745c introduced an extra level of 'make' when the umask is
different from 0022. However, when several targets were specified on
the command line, a new make instance would be called for each target.
This introduces a huge performance overhead when many targets are
specified on the command line.
To fix this, use the same approach as used in the mkmakefile script:
an addition target on which the MAKECMDGOALS depend, so that this
target is run only once.
Note that the mkmakefile script contains a special exception for
Makefile, because the Makefile in the output directory is generated.
Since the top-level Makefile is not generated, this exception is not
needed here.
While we're at it, also fix the whitespace in the UMASK assignment.
Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
[yann.morin.1998 at free.fr: aggregate patches from Arnout and Guido]
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
---
Changes v0 -> v4:
- aggregate Arnout's and Guido's patches together, keepign the best of
both patches
- fix the spaces in UMASK assignment
---
Makefile | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/Makefile b/Makefile
index 531ac5d..afdf554 100644
--- a/Makefile
+++ b/Makefile
@@ -25,15 +25,15 @@
#--------------------------------------------------------------
# Trick for always running with a fixed umask
-UMASK=0022
+UMASK = 0022
ifneq ($(shell umask),$(UMASK))
-.PHONY: all $(MAKECMDGOALS)
+.PHONY: _all $(MAKECMDGOALS)
-all:
- @umask $(UMASK) && $(MAKE) --no-print-directory
+$(MAKECMDGOALS): _all
+ @:
-$(MAKECMDGOALS):
- @umask $(UMASK) && $(MAKE) --no-print-directory $@
+_all:
+ @umask $(UMASK) && $(MAKE) --no-print-directory $(MAKECMDGOALS)
else # umask
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCHv4] Makefile: fix performance regression casued by the umask handling
2015-07-16 22:33 [Buildroot] [PATCHv4] Makefile: fix performance regression casued by the umask handling Yann E. MORIN
@ 2015-07-16 22:35 ` Arnout Vandecappelle
2015-07-17 16:47 ` Yann E. MORIN
2015-07-18 9:31 ` Thomas Petazzoni
1 sibling, 1 reply; 4+ messages in thread
From: Arnout Vandecappelle @ 2015-07-16 22:35 UTC (permalink / raw)
To: buildroot
On 07/17/15 00:33, Yann E. MORIN wrote:
> From: Guido Mart?nez <guido@vanguardiasur.com.ar>
>
> Commit bee5745c introduced an extra level of 'make' when the umask is
> different from 0022. However, when several targets were specified on
> the command line, a new make instance would be called for each target.
> This introduces a huge performance overhead when many targets are
> specified on the command line.
>
> To fix this, use the same approach as used in the mkmakefile script:
> an addition target on which the MAKECMDGOALS depend, so that this
> target is run only once.
>
> Note that the mkmakefile script contains a special exception for
> Makefile, because the Makefile in the output directory is generated.
> Since the top-level Makefile is not generated, this exception is not
> needed here.
>
> While we're at it, also fix the whitespace in the UMASK assignment.
>
> Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> [yann.morin.1998 at free.fr: aggregate patches from Arnout and Guido]
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Someone finally got it right :-)
Sorry for all the spam...
Regards,
Arnout
>
> ---
> Changes v0 -> v4:
> - aggregate Arnout's and Guido's patches together, keepign the best of
> both patches
> - fix the spaces in UMASK assignment
> ---
> Makefile | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 531ac5d..afdf554 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -25,15 +25,15 @@
> #--------------------------------------------------------------
>
> # Trick for always running with a fixed umask
> -UMASK=0022
> +UMASK = 0022
> ifneq ($(shell umask),$(UMASK))
> -.PHONY: all $(MAKECMDGOALS)
> +.PHONY: _all $(MAKECMDGOALS)
>
> -all:
> - @umask $(UMASK) && $(MAKE) --no-print-directory
> +$(MAKECMDGOALS): _all
> + @:
>
> -$(MAKECMDGOALS):
> - @umask $(UMASK) && $(MAKE) --no-print-directory $@
> +_all:
> + @umask $(UMASK) && $(MAKE) --no-print-directory $(MAKECMDGOALS)
>
> else # umask
>
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCHv4] Makefile: fix performance regression casued by the umask handling
2015-07-16 22:35 ` Arnout Vandecappelle
@ 2015-07-17 16:47 ` Yann E. MORIN
0 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2015-07-17 16:47 UTC (permalink / raw)
To: buildroot
Arnout, Guido, All,
On 2015-07-17 00:35 +0200, Arnout Vandecappelle spake thusly:
> On 07/17/15 00:33, Yann E. MORIN wrote:
> > From: Guido Mart?nez <guido@vanguardiasur.com.ar>
> >
> > Commit bee5745c introduced an extra level of 'make' when the umask is
> > different from 0022. However, when several targets were specified on
> > the command line, a new make instance would be called for each target.
> > This introduces a huge performance overhead when many targets are
> > specified on the command line.
> >
> > To fix this, use the same approach as used in the mkmakefile script:
> > an addition target on which the MAKECMDGOALS depend, so that this
> > target is run only once.
> >
> > Note that the mkmakefile script contains a special exception for
> > Makefile, because the Makefile in the output directory is generated.
> > Since the top-level Makefile is not generated, this exception is not
> > needed here.
> >
> > While we're at it, also fix the whitespace in the UMASK assignment.
> >
> > Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
> > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> > [yann.morin.1998 at free.fr: aggregate patches from Arnout and Guido]
> > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
> Someone finally got it right :-)
Almost... I made a typo in the subject... ;-]
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCHv4] Makefile: fix performance regression casued by the umask handling
2015-07-16 22:33 [Buildroot] [PATCHv4] Makefile: fix performance regression casued by the umask handling Yann E. MORIN
2015-07-16 22:35 ` Arnout Vandecappelle
@ 2015-07-18 9:31 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2015-07-18 9:31 UTC (permalink / raw)
To: buildroot
Dear Yann E. MORIN,
On Fri, 17 Jul 2015 00:33:07 +0200, Yann E. MORIN wrote:
> From: Guido Mart?nez <guido@vanguardiasur.com.ar>
>
> Commit bee5745c introduced an extra level of 'make' when the umask is
> different from 0022. However, when several targets were specified on
> the command line, a new make instance would be called for each target.
> This introduces a huge performance overhead when many targets are
> specified on the command line.
>
> To fix this, use the same approach as used in the mkmakefile script:
> an addition target on which the MAKECMDGOALS depend, so that this
> target is run only once.
>
> Note that the mkmakefile script contains a special exception for
> Makefile, because the Makefile in the output directory is generated.
> Since the top-level Makefile is not generated, this exception is not
> needed here.
>
> While we're at it, also fix the whitespace in the UMASK assignment.
>
> Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> [yann.morin.1998 at free.fr: aggregate patches from Arnout and Guido]
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
>
> ---
> Changes v0 -> v4:
> - aggregate Arnout's and Guido's patches together, keepign the best of
> both patches
> - fix the spaces in UMASK assignment
> ---
> Makefile | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-18 9:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-16 22:33 [Buildroot] [PATCHv4] Makefile: fix performance regression casued by the umask handling Yann E. MORIN
2015-07-16 22:35 ` Arnout Vandecappelle
2015-07-17 16:47 ` Yann E. MORIN
2015-07-18 9:31 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.