All of lore.kernel.org
 help / color / mirror / Atom feed
* [lm-sensors] [PATCH] hwmon: (k10temp) remove duplicate pci-id define
@ 2015-07-17 11:51 Adam Majer
  2015-07-17 16:42 ` Jean Delvare
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Adam Majer @ 2015-07-17 11:51 UTC (permalink / raw)
  To: lm-sensors

PCI_DEVICE_ID_AMD_15H_M60H_NB_F3 is now defined in pci_ids.h

Signed-off-by: Adam Majer <adamm@zombino.com>
---
 drivers/hwmon/k10temp.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
index 1e7bdcd..9cdfde6 100644
--- a/drivers/hwmon/k10temp.c
+++ b/drivers/hwmon/k10temp.c
@@ -60,7 +60,6 @@ static DEFINE_MUTEX(nb_smu_ind_mutex);
  * Control]
  */
 #define F15H_M60H_REPORTED_TEMP_CTRL_OFFSET	0xd8200ca4
-#define PCI_DEVICE_ID_AMD_15H_M60H_NB_F3	0x1573
 
 static void amd_nb_smu_index_read(struct pci_dev *pdev, unsigned int devfn,
 				  int offset, u32 *val)
-- 
2.1.4


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [lm-sensors] [PATCH] hwmon: (k10temp) remove duplicate pci-id define
  2015-07-17 11:51 [lm-sensors] [PATCH] hwmon: (k10temp) remove duplicate pci-id define Adam Majer
@ 2015-07-17 16:42 ` Jean Delvare
  2015-07-20 14:45 ` Guenter Roeck
  2015-07-25 16:30 ` Jean Delvare
  2 siblings, 0 replies; 8+ messages in thread
From: Jean Delvare @ 2015-07-17 16:42 UTC (permalink / raw)
  To: lm-sensors

On Fri, 17 Jul 2015 06:51:19 -0500, Adam Majer wrote:
> PCI_DEVICE_ID_AMD_15H_M60H_NB_F3 is now defined in pci_ids.h
> 
> Signed-off-by: Adam Majer <adamm@zombino.com>
> ---
>  drivers/hwmon/k10temp.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> index 1e7bdcd..9cdfde6 100644
> --- a/drivers/hwmon/k10temp.c
> +++ b/drivers/hwmon/k10temp.c
> @@ -60,7 +60,6 @@ static DEFINE_MUTEX(nb_smu_ind_mutex);
>   * Control]
>   */
>  #define F15H_M60H_REPORTED_TEMP_CTRL_OFFSET	0xd8200ca4
> -#define PCI_DEVICE_ID_AMD_15H_M60H_NB_F3	0x1573
>  
>  static void amd_nb_smu_index_read(struct pci_dev *pdev, unsigned int devfn,
>  				  int offset, u32 *val)

Applied, thanks.

-- 
Jean Delvare
SUSE L3 Support

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [lm-sensors] [PATCH] hwmon: (k10temp) remove duplicate pci-id define
  2015-07-17 11:51 [lm-sensors] [PATCH] hwmon: (k10temp) remove duplicate pci-id define Adam Majer
  2015-07-17 16:42 ` Jean Delvare
@ 2015-07-20 14:45 ` Guenter Roeck
  2015-07-25 16:30 ` Jean Delvare
  2 siblings, 0 replies; 8+ messages in thread
From: Guenter Roeck @ 2015-07-20 14:45 UTC (permalink / raw)
  To: lm-sensors

On 07/17/2015 04:51 AM, Adam Majer wrote:
> PCI_DEVICE_ID_AMD_15H_M60H_NB_F3 is now defined in pci_ids.h
>
> Signed-off-by: Adam Majer <adamm@zombino.com>

Acked-by: Guenter Roeck <linux@roeck-us.net>

Jean, do you want to take that one, or should I take it ?

Thanks,
Guenter

> ---
>   drivers/hwmon/k10temp.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> index 1e7bdcd..9cdfde6 100644
> --- a/drivers/hwmon/k10temp.c
> +++ b/drivers/hwmon/k10temp.c
> @@ -60,7 +60,6 @@ static DEFINE_MUTEX(nb_smu_ind_mutex);
>    * Control]
>    */
>   #define F15H_M60H_REPORTED_TEMP_CTRL_OFFSET	0xd8200ca4
> -#define PCI_DEVICE_ID_AMD_15H_M60H_NB_F3	0x1573
>
>   static void amd_nb_smu_index_read(struct pci_dev *pdev, unsigned int devfn,
>   				  int offset, u32 *val)
>


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [lm-sensors] [PATCH] hwmon: (k10temp) remove duplicate pci-id define
  2015-07-17 11:51 [lm-sensors] [PATCH] hwmon: (k10temp) remove duplicate pci-id define Adam Majer
  2015-07-17 16:42 ` Jean Delvare
  2015-07-20 14:45 ` Guenter Roeck
@ 2015-07-25 16:30 ` Jean Delvare
  2 siblings, 0 replies; 8+ messages in thread
From: Jean Delvare @ 2015-07-25 16:30 UTC (permalink / raw)
  To: lm-sensors

Hi Guenter,

On Mon, 20 Jul 2015 07:45:06 -0700, Guenter Roeck wrote:
> On 07/17/2015 04:51 AM, Adam Majer wrote:
> > PCI_DEVICE_ID_AMD_15H_M60H_NB_F3 is now defined in pci_ids.h
> >
> > Signed-off-by: Adam Majer <adamm@zombino.com>
> 
> Acked-by: Guenter Roeck <linux@roeck-us.net>
> 
> Jean, do you want to take that one, or should I take it ?

I picked it.

-- 
Jean Delvare
SUSE L3 Support

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [lm-sensors] [PATCH] [hwmon]: (k10temp) remove duplicate pci-id define
  2015-07-17  2:47 [lm-sensors] [PATCH] [hwmon]: " Adam Majer
  2015-07-17 10:41 ` Jean Delvare
  2015-07-17 10:44 ` Clemens Ladisch
@ 2015-07-17 11:53 ` Adam Majer
  2 siblings, 0 replies; 8+ messages in thread
From: Adam Majer @ 2015-07-17 11:53 UTC (permalink / raw)
  To: lm-sensors

On Fri, Jul 17, 2015 at 12:41:59PM +0200, Jean Delvare wrote:
> Hi Adam,
> 
> This looks good, however per Documentation/SubmittingPatches I need
> your Signed-off-by so that I can commit this patch.

Hi Jean,

Sorry, completely forgot about this!

> Please also not that the subject should read hwmon: instead of [hwmon]:.

Fixed.

> Thanks,
> -- 
> Jean Delvare
> SUSE L3 Support


Thank you,

-- 
Adam Majer
adamm@zombino.com

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [lm-sensors] [PATCH] [hwmon]: (k10temp) remove duplicate pci-id define
  2015-07-17  2:47 [lm-sensors] [PATCH] [hwmon]: " Adam Majer
  2015-07-17 10:41 ` Jean Delvare
@ 2015-07-17 10:44 ` Clemens Ladisch
  2015-07-17 11:53 ` Adam Majer
  2 siblings, 0 replies; 8+ messages in thread
From: Clemens Ladisch @ 2015-07-17 10:44 UTC (permalink / raw)
  To: lm-sensors

Adam Majer wrote:
> PCI_DEVICE_ID_AMD_15H_M60H_NB_F3 is now defined in pci_ids.h

Acked-by: Clemens Ladisch <clemens@ladisch.de>

> ---
>  drivers/hwmon/k10temp.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> index 1e7bdcd..9cdfde6 100644
> --- a/drivers/hwmon/k10temp.c
> +++ b/drivers/hwmon/k10temp.c
> @@ -60,7 +60,6 @@ static DEFINE_MUTEX(nb_smu_ind_mutex);
>   * Control]
>   */
>  #define F15H_M60H_REPORTED_TEMP_CTRL_OFFSET	0xd8200ca4
> -#define PCI_DEVICE_ID_AMD_15H_M60H_NB_F3	0x1573
>
>  static void amd_nb_smu_index_read(struct pci_dev *pdev, unsigned int devfn,
>  				  int offset, u32 *val)

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [lm-sensors] [PATCH] [hwmon]: (k10temp) remove duplicate pci-id define
  2015-07-17  2:47 [lm-sensors] [PATCH] [hwmon]: " Adam Majer
@ 2015-07-17 10:41 ` Jean Delvare
  2015-07-17 10:44 ` Clemens Ladisch
  2015-07-17 11:53 ` Adam Majer
  2 siblings, 0 replies; 8+ messages in thread
From: Jean Delvare @ 2015-07-17 10:41 UTC (permalink / raw)
  To: lm-sensors

Hi Adam,

On Thu, 16 Jul 2015 21:47:49 -0500, Adam Majer wrote:
> PCI_DEVICE_ID_AMD_15H_M60H_NB_F3 is now defined in pci_ids.h
> ---
>  drivers/hwmon/k10temp.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
> index 1e7bdcd..9cdfde6 100644
> --- a/drivers/hwmon/k10temp.c
> +++ b/drivers/hwmon/k10temp.c
> @@ -60,7 +60,6 @@ static DEFINE_MUTEX(nb_smu_ind_mutex);
>   * Control]
>   */
>  #define F15H_M60H_REPORTED_TEMP_CTRL_OFFSET	0xd8200ca4
> -#define PCI_DEVICE_ID_AMD_15H_M60H_NB_F3	0x1573
>  
>  static void amd_nb_smu_index_read(struct pci_dev *pdev, unsigned int devfn,
>  				  int offset, u32 *val)

This looks good, however per Documentation/SubmittingPatches I need
your Signed-off-by so that I can commit this patch.

Please also not that the subject should read hwmon: instead of [hwmon]:.

Thanks,
-- 
Jean Delvare
SUSE L3 Support

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [lm-sensors] [PATCH] [hwmon]: (k10temp) remove duplicate pci-id define
@ 2015-07-17  2:47 Adam Majer
  2015-07-17 10:41 ` Jean Delvare
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Adam Majer @ 2015-07-17  2:47 UTC (permalink / raw)
  To: lm-sensors

PCI_DEVICE_ID_AMD_15H_M60H_NB_F3 is now defined in pci_ids.h
---
 drivers/hwmon/k10temp.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
index 1e7bdcd..9cdfde6 100644
--- a/drivers/hwmon/k10temp.c
+++ b/drivers/hwmon/k10temp.c
@@ -60,7 +60,6 @@ static DEFINE_MUTEX(nb_smu_ind_mutex);
  * Control]
  */
 #define F15H_M60H_REPORTED_TEMP_CTRL_OFFSET	0xd8200ca4
-#define PCI_DEVICE_ID_AMD_15H_M60H_NB_F3	0x1573
 
 static void amd_nb_smu_index_read(struct pci_dev *pdev, unsigned int devfn,
 				  int offset, u32 *val)
-- 
2.1.4


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2015-07-25 16:30 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-17 11:51 [lm-sensors] [PATCH] hwmon: (k10temp) remove duplicate pci-id define Adam Majer
2015-07-17 16:42 ` Jean Delvare
2015-07-20 14:45 ` Guenter Roeck
2015-07-25 16:30 ` Jean Delvare
  -- strict thread matches above, loose matches on Subject: below --
2015-07-17  2:47 [lm-sensors] [PATCH] [hwmon]: " Adam Majer
2015-07-17 10:41 ` Jean Delvare
2015-07-17 10:44 ` Clemens Ladisch
2015-07-17 11:53 ` Adam Majer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.