* [PATCH] bpf_trace: Make dependent on PERF_EVENTS
@ 2015-11-10 20:28 ` Steven Rostedt
0 siblings, 0 replies; 9+ messages in thread
From: Steven Rostedt @ 2015-11-10 20:28 UTC (permalink / raw)
To: LKML
Cc: Arnd Bergmann, Ingo Molnar, Alexei Starovoitov, David S. Miller,
Daniel Borkmann, Kaixu Xia, Hannes Frederic Sowa, Wang Nan,
netdev, Arnaldo Carvalho de Melo, linux-arm-kernel,
Peter Zijlstra
Arnd Bergmann reported:
In my ARM randconfig tests, I'm getting a build error for
newly added code in bpf_perf_event_read and bpf_perf_event_output
whenever CONFIG_PERF_EVENTS is disabled:
kernel/trace/bpf_trace.c: In function 'bpf_perf_event_read':
kernel/trace/bpf_trace.c:203:11: error: 'struct perf_event' has no member named 'oncpu'
if (event->oncpu != smp_processor_id() ||
^
kernel/trace/bpf_trace.c:204:11: error: 'struct perf_event' has no member named 'pmu'
event->pmu->count)
This can happen when UPROBE_EVENT is enabled but KPROBE_EVENT
is disabled. I'm not sure if that is a configuration we care
about, otherwise we could prevent this case from occuring by
adding Kconfig dependencies.
Looking at this further, it's really that UPROBE_EVENT enables PERF_EVENTS.
By just having BPF_EVENTS depend on PERF_EVENTS, then all is fine.
Link: http://lkml.kernel.org/r/4525348.Aq9YoXkChv@wuerfel
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/trace/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 8d6363f42169..e45db6b0d878 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -434,7 +434,7 @@ config UPROBE_EVENT
config BPF_EVENTS
depends on BPF_SYSCALL
- depends on KPROBE_EVENT || UPROBE_EVENT
+ depends on (KPROBE_EVENT || UPROBE_EVENT) && PERF_EVENTS
bool
default y
help
--
1.8.3.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] bpf_trace: Make dependent on PERF_EVENTS
@ 2015-11-10 20:28 ` Steven Rostedt
0 siblings, 0 replies; 9+ messages in thread
From: Steven Rostedt @ 2015-11-10 20:28 UTC (permalink / raw)
To: linux-arm-kernel
Arnd Bergmann reported:
In my ARM randconfig tests, I'm getting a build error for
newly added code in bpf_perf_event_read and bpf_perf_event_output
whenever CONFIG_PERF_EVENTS is disabled:
kernel/trace/bpf_trace.c: In function 'bpf_perf_event_read':
kernel/trace/bpf_trace.c:203:11: error: 'struct perf_event' has no member named 'oncpu'
if (event->oncpu != smp_processor_id() ||
^
kernel/trace/bpf_trace.c:204:11: error: 'struct perf_event' has no member named 'pmu'
event->pmu->count)
This can happen when UPROBE_EVENT is enabled but KPROBE_EVENT
is disabled. I'm not sure if that is a configuration we care
about, otherwise we could prevent this case from occuring by
adding Kconfig dependencies.
Looking at this further, it's really that UPROBE_EVENT enables PERF_EVENTS.
By just having BPF_EVENTS depend on PERF_EVENTS, then all is fine.
Link: http://lkml.kernel.org/r/4525348.Aq9YoXkChv at wuerfel
Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
kernel/trace/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 8d6363f42169..e45db6b0d878 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -434,7 +434,7 @@ config UPROBE_EVENT
config BPF_EVENTS
depends on BPF_SYSCALL
- depends on KPROBE_EVENT || UPROBE_EVENT
+ depends on (KPROBE_EVENT || UPROBE_EVENT) && PERF_EVENTS
bool
default y
help
--
1.8.3.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] bpf_trace: Make dependent on PERF_EVENTS
2015-11-10 20:28 ` Steven Rostedt
(?)
@ 2015-11-10 20:39 ` Arnd Bergmann
-1 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2015-11-10 20:39 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Steven Rostedt, LKML, Wang Nan, Kaixu Xia, Daniel Borkmann,
Peter Zijlstra, netdev, Alexei Starovoitov,
Arnaldo Carvalho de Melo, Ingo Molnar, Hannes Frederic Sowa,
David S. Miller
On Tuesday 10 November 2015 15:28:17 Steven Rostedt wrote:
> Arnd Bergmann reported:
>
> In my ARM randconfig tests, I'm getting a build error for
> newly added code in bpf_perf_event_read and bpf_perf_event_output
> whenever CONFIG_PERF_EVENTS is disabled:
>
> kernel/trace/bpf_trace.c: In function 'bpf_perf_event_read':
> kernel/trace/bpf_trace.c:203:11: error: 'struct perf_event' has no member named 'oncpu'
> if (event->oncpu != smp_processor_id() ||
> ^
> kernel/trace/bpf_trace.c:204:11: error: 'struct perf_event' has no member named 'pmu'
> event->pmu->count)
>
> This can happen when UPROBE_EVENT is enabled but KPROBE_EVENT
> is disabled. I'm not sure if that is a configuration we care
> about, otherwise we could prevent this case from occuring by
> adding Kconfig dependencies.
>
> Looking at this further, it's really that UPROBE_EVENT enables PERF_EVENTS.
> By just having BPF_EVENTS depend on PERF_EVENTS, then all is fine.
>
> Link: http://lkml.kernel.org/r/4525348.Aq9YoXkChv@wuerfel
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
>
Ok, sounds good.
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] bpf_trace: Make dependent on PERF_EVENTS
@ 2015-11-10 20:39 ` Arnd Bergmann
0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2015-11-10 20:39 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Wang Nan, Kaixu Xia, Daniel Borkmann, Peter Zijlstra, netdev,
LKML, Steven Rostedt, Alexei Starovoitov, Ingo Molnar,
Arnaldo Carvalho de Melo, Hannes Frederic Sowa, David S. Miller
On Tuesday 10 November 2015 15:28:17 Steven Rostedt wrote:
> Arnd Bergmann reported:
>
> In my ARM randconfig tests, I'm getting a build error for
> newly added code in bpf_perf_event_read and bpf_perf_event_output
> whenever CONFIG_PERF_EVENTS is disabled:
>
> kernel/trace/bpf_trace.c: In function 'bpf_perf_event_read':
> kernel/trace/bpf_trace.c:203:11: error: 'struct perf_event' has no member named 'oncpu'
> if (event->oncpu != smp_processor_id() ||
> ^
> kernel/trace/bpf_trace.c:204:11: error: 'struct perf_event' has no member named 'pmu'
> event->pmu->count)
>
> This can happen when UPROBE_EVENT is enabled but KPROBE_EVENT
> is disabled. I'm not sure if that is a configuration we care
> about, otherwise we could prevent this case from occuring by
> adding Kconfig dependencies.
>
> Looking at this further, it's really that UPROBE_EVENT enables PERF_EVENTS.
> By just having BPF_EVENTS depend on PERF_EVENTS, then all is fine.
>
> Link: http://lkml.kernel.org/r/4525348.Aq9YoXkChv@wuerfel
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
>
Ok, sounds good.
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] bpf_trace: Make dependent on PERF_EVENTS
@ 2015-11-10 20:39 ` Arnd Bergmann
0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2015-11-10 20:39 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 10 November 2015 15:28:17 Steven Rostedt wrote:
> Arnd Bergmann reported:
>
> In my ARM randconfig tests, I'm getting a build error for
> newly added code in bpf_perf_event_read and bpf_perf_event_output
> whenever CONFIG_PERF_EVENTS is disabled:
>
> kernel/trace/bpf_trace.c: In function 'bpf_perf_event_read':
> kernel/trace/bpf_trace.c:203:11: error: 'struct perf_event' has no member named 'oncpu'
> if (event->oncpu != smp_processor_id() ||
> ^
> kernel/trace/bpf_trace.c:204:11: error: 'struct perf_event' has no member named 'pmu'
> event->pmu->count)
>
> This can happen when UPROBE_EVENT is enabled but KPROBE_EVENT
> is disabled. I'm not sure if that is a configuration we care
> about, otherwise we could prevent this case from occuring by
> adding Kconfig dependencies.
>
> Looking at this further, it's really that UPROBE_EVENT enables PERF_EVENTS.
> By just having BPF_EVENTS depend on PERF_EVENTS, then all is fine.
>
> Link: http://lkml.kernel.org/r/4525348.Aq9YoXkChv at wuerfel
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
>
Ok, sounds good.
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] bpf_trace: Make dependent on PERF_EVENTS
2015-11-10 20:28 ` Steven Rostedt
@ 2015-11-10 20:40 ` David Miller
-1 siblings, 0 replies; 9+ messages in thread
From: David Miller @ 2015-11-10 20:40 UTC (permalink / raw)
To: rostedt
Cc: linux-kernel, arnd, mingo, ast, daniel, xiakaixu, hannes,
wangnan0, netdev, acme, linux-arm-kernel, peterz
From: Steven Rostedt <rostedt@goodmis.org>
Date: Tue, 10 Nov 2015 15:28:17 -0500
>
> Arnd Bergmann reported:
>
> In my ARM randconfig tests, I'm getting a build error for
> newly added code in bpf_perf_event_read and bpf_perf_event_output
> whenever CONFIG_PERF_EVENTS is disabled:
>
> kernel/trace/bpf_trace.c: In function 'bpf_perf_event_read':
> kernel/trace/bpf_trace.c:203:11: error: 'struct perf_event' has no member named 'oncpu'
> if (event->oncpu != smp_processor_id() ||
> ^
> kernel/trace/bpf_trace.c:204:11: error: 'struct perf_event' has no member named 'pmu'
> event->pmu->count)
>
> This can happen when UPROBE_EVENT is enabled but KPROBE_EVENT
> is disabled. I'm not sure if that is a configuration we care
> about, otherwise we could prevent this case from occuring by
> adding Kconfig dependencies.
>
> Looking at this further, it's really that UPROBE_EVENT enables PERF_EVENTS.
> By just having BPF_EVENTS depend on PERF_EVENTS, then all is fine.
>
> Link: http://lkml.kernel.org/r/4525348.Aq9YoXkChv@wuerfel
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
I'll apply this, thanks Steven et al.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] bpf_trace: Make dependent on PERF_EVENTS
@ 2015-11-10 20:40 ` David Miller
0 siblings, 0 replies; 9+ messages in thread
From: David Miller @ 2015-11-10 20:40 UTC (permalink / raw)
To: linux-arm-kernel
From: Steven Rostedt <rostedt@goodmis.org>
Date: Tue, 10 Nov 2015 15:28:17 -0500
>
> Arnd Bergmann reported:
>
> In my ARM randconfig tests, I'm getting a build error for
> newly added code in bpf_perf_event_read and bpf_perf_event_output
> whenever CONFIG_PERF_EVENTS is disabled:
>
> kernel/trace/bpf_trace.c: In function 'bpf_perf_event_read':
> kernel/trace/bpf_trace.c:203:11: error: 'struct perf_event' has no member named 'oncpu'
> if (event->oncpu != smp_processor_id() ||
> ^
> kernel/trace/bpf_trace.c:204:11: error: 'struct perf_event' has no member named 'pmu'
> event->pmu->count)
>
> This can happen when UPROBE_EVENT is enabled but KPROBE_EVENT
> is disabled. I'm not sure if that is a configuration we care
> about, otherwise we could prevent this case from occuring by
> adding Kconfig dependencies.
>
> Looking at this further, it's really that UPROBE_EVENT enables PERF_EVENTS.
> By just having BPF_EVENTS depend on PERF_EVENTS, then all is fine.
>
> Link: http://lkml.kernel.org/r/4525348.Aq9YoXkChv at wuerfel
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
I'll apply this, thanks Steven et al.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] bpf_trace: Make dependent on PERF_EVENTS
2015-11-10 20:40 ` David Miller
@ 2015-11-10 20:48 ` Steven Rostedt
-1 siblings, 0 replies; 9+ messages in thread
From: Steven Rostedt @ 2015-11-10 20:48 UTC (permalink / raw)
To: David Miller
Cc: linux-kernel, arnd, mingo, ast, daniel, xiakaixu, hannes,
wangnan0, netdev, acme, linux-arm-kernel, peterz
On Tue, 10 Nov 2015 15:40:35 -0500 (EST)
David Miller <davem@davemloft.net> wrote:
> I'll apply this, thanks Steven et al.
Thanks David.
-- Steve
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] bpf_trace: Make dependent on PERF_EVENTS
@ 2015-11-10 20:48 ` Steven Rostedt
0 siblings, 0 replies; 9+ messages in thread
From: Steven Rostedt @ 2015-11-10 20:48 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 10 Nov 2015 15:40:35 -0500 (EST)
David Miller <davem@davemloft.net> wrote:
> I'll apply this, thanks Steven et al.
Thanks David.
-- Steve
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-11-10 20:48 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-10 20:28 [PATCH] bpf_trace: Make dependent on PERF_EVENTS Steven Rostedt
2015-11-10 20:28 ` Steven Rostedt
2015-11-10 20:39 ` Arnd Bergmann
2015-11-10 20:39 ` Arnd Bergmann
2015-11-10 20:39 ` Arnd Bergmann
2015-11-10 20:40 ` David Miller
2015-11-10 20:40 ` David Miller
2015-11-10 20:48 ` Steven Rostedt
2015-11-10 20:48 ` Steven Rostedt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.