From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
Theodore Ts'o <tytso@mit.edu>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Dan Williams <dan.j.williams@intel.com>,
Dave Chinner <david@fromorbit.com>,
Ingo Molnar <mingo@redhat.com>, Jan Kara <jack@suse.com>,
Jeff Layton <jlayton@poochiereds.net>,
Matthew Wilcox <willy@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-nvdimm@lists.01.org, x86@kernel.org,
xfs@oss.sgi.com, Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <matthew.r.wilcox@intel.com>
Subject: Re: [PATCH v2 02/11] mm: add pmd_mkclean()
Date: Tue, 17 Nov 2015 10:52:43 -0700 [thread overview]
Message-ID: <20151117175243.GA28024@linux.intel.com> (raw)
In-Reply-To: <56468838.6010506@intel.com>
On Fri, Nov 13, 2015 at 05:02:48PM -0800, Dave Hansen wrote:
> On 11/13/2015 04:06 PM, Ross Zwisler wrote:
> > +static inline pmd_t pmd_mkclean(pmd_t pmd)
> > +{
> > + return pmd_clear_flags(pmd, _PAGE_DIRTY | _PAGE_SOFT_DIRTY);
> > +}
>
> pte_mkclean() doesn't clear _PAGE_SOFT_DIRTY. What the thought behind
> doing it here?
I just wrote it to undo the work done by pmd_mkdirty() - you're right, it
should mirror the work done by pte_mkclean() and not clear _PAGE_SOFT_DIRTY.
I'll fix this for v3, thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
"Theodore Ts'o" <tytso@mit.edu>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Dan Williams <dan.j.williams@intel.com>,
Dave Chinner <david@fromorbit.com>,
Ingo Molnar <mingo@redhat.com>, Jan Kara <jack@suse.com>,
Jeff Layton <jlayton@poochiereds.net>,
Matthew Wilcox <willy@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-nvdimm@ml01.01.org, x86@kernel.org,
xfs@oss.sgi.com, Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <matthew.r.wilcox@intel.com>
Subject: Re: [PATCH v2 02/11] mm: add pmd_mkclean()
Date: Tue, 17 Nov 2015 10:52:43 -0700 [thread overview]
Message-ID: <20151117175243.GA28024@linux.intel.com> (raw)
In-Reply-To: <56468838.6010506@intel.com>
On Fri, Nov 13, 2015 at 05:02:48PM -0800, Dave Hansen wrote:
> On 11/13/2015 04:06 PM, Ross Zwisler wrote:
> > +static inline pmd_t pmd_mkclean(pmd_t pmd)
> > +{
> > + return pmd_clear_flags(pmd, _PAGE_DIRTY | _PAGE_SOFT_DIRTY);
> > +}
>
> pte_mkclean() doesn't clear _PAGE_SOFT_DIRTY. What the thought behind
> doing it here?
I just wrote it to undo the work done by pmd_mkdirty() - you're right, it
should mirror the work done by pte_mkclean() and not clear _PAGE_SOFT_DIRTY.
I'll fix this for v3, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
linux-mm@kvack.org, Andreas Dilger <adilger.kernel@dilger.ca>,
"H. Peter Anvin" <hpa@zytor.com>,
Jeff Layton <jlayton@poochiereds.net>,
Dan Williams <dan.j.williams@intel.com>,
linux-nvdimm@lists.01.org, x86@kernel.org,
Ingo Molnar <mingo@redhat.com>,
Matthew Wilcox <willy@linux.intel.com>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
linux-ext4@vger.kernel.org, xfs@oss.sgi.com,
Alexander Viro <viro@zeniv.linux.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
Theodore Ts'o <tytso@mit.edu>,
linux-kernel@vger.kernel.org, Jan Kara <jack@suse.com>,
linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <matthew.r.wilcox@intel.com>
Subject: Re: [PATCH v2 02/11] mm: add pmd_mkclean()
Date: Tue, 17 Nov 2015 10:52:43 -0700 [thread overview]
Message-ID: <20151117175243.GA28024@linux.intel.com> (raw)
In-Reply-To: <56468838.6010506@intel.com>
On Fri, Nov 13, 2015 at 05:02:48PM -0800, Dave Hansen wrote:
> On 11/13/2015 04:06 PM, Ross Zwisler wrote:
> > +static inline pmd_t pmd_mkclean(pmd_t pmd)
> > +{
> > + return pmd_clear_flags(pmd, _PAGE_DIRTY | _PAGE_SOFT_DIRTY);
> > +}
>
> pte_mkclean() doesn't clear _PAGE_SOFT_DIRTY. What the thought behind
> doing it here?
I just wrote it to undo the work done by pmd_mkdirty() - you're right, it
should mirror the work done by pte_mkclean() and not clear _PAGE_SOFT_DIRTY.
I'll fix this for v3, thanks!
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-11-17 17:52 UTC|newest]
Thread overview: 132+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-14 0:06 [PATCH v2 00/11] DAX fsynx/msync support Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-14 0:06 ` [PATCH v2 01/11] pmem: add wb_cache_pmem() to the PMEM API Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-14 0:06 ` [PATCH v2 02/11] mm: add pmd_mkclean() Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-14 1:02 ` Dave Hansen
2015-11-14 1:02 ` Dave Hansen
2015-11-14 1:02 ` Dave Hansen
2015-11-17 17:52 ` Ross Zwisler [this message]
2015-11-17 17:52 ` Ross Zwisler
2015-11-17 17:52 ` Ross Zwisler
2015-11-14 0:06 ` [PATCH v2 03/11] pmem: enable REQ_FUA/REQ_FLUSH handling Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-14 0:20 ` Dan Williams
2015-11-14 0:20 ` Dan Williams
2015-11-14 0:20 ` Dan Williams
2015-11-14 0:43 ` Andreas Dilger
2015-11-14 0:43 ` Andreas Dilger
2015-11-14 0:43 ` Andreas Dilger
2015-11-14 2:32 ` Dan Williams
2015-11-14 2:32 ` Dan Williams
2015-11-14 2:32 ` Dan Williams
2015-11-16 13:37 ` Jan Kara
2015-11-16 13:37 ` Jan Kara
2015-11-16 13:37 ` Jan Kara
2015-11-16 13:37 ` Jan Kara
2015-11-16 14:05 ` Jan Kara
2015-11-16 14:05 ` Jan Kara
2015-11-16 14:05 ` Jan Kara
2015-11-16 17:28 ` Dan Williams
2015-11-16 17:28 ` Dan Williams
2015-11-16 17:28 ` Dan Williams
2015-11-16 19:48 ` Ross Zwisler
2015-11-16 19:48 ` Ross Zwisler
2015-11-16 19:48 ` Ross Zwisler
2015-11-16 19:48 ` Ross Zwisler
2015-11-16 20:34 ` Dan Williams
2015-11-16 20:34 ` Dan Williams
2015-11-16 20:34 ` Dan Williams
2015-11-16 20:34 ` Dan Williams
2015-11-16 23:57 ` Ross Zwisler
2015-11-16 23:57 ` Ross Zwisler
2015-11-16 23:57 ` Ross Zwisler
2015-11-16 23:57 ` Ross Zwisler
2015-11-16 22:14 ` Dave Chinner
2015-11-16 22:14 ` Dave Chinner
2015-11-16 22:14 ` Dave Chinner
2015-11-16 23:29 ` Ross Zwisler
2015-11-16 23:29 ` Ross Zwisler
2015-11-16 23:29 ` Ross Zwisler
2015-11-16 23:29 ` Ross Zwisler
2015-11-16 23:42 ` Dave Chinner
2015-11-16 23:42 ` Dave Chinner
2015-11-16 23:42 ` Dave Chinner
2015-11-16 23:42 ` Dave Chinner
2015-11-16 20:09 ` Ross Zwisler
2015-11-16 20:09 ` Ross Zwisler
2015-11-16 20:09 ` Ross Zwisler
2015-11-18 10:40 ` Jan Kara
2015-11-18 10:40 ` Jan Kara
2015-11-18 10:40 ` Jan Kara
2015-11-18 10:40 ` Jan Kara
2015-11-18 16:16 ` Ross Zwisler
2015-11-18 16:16 ` Ross Zwisler
2015-11-18 16:16 ` Ross Zwisler
2015-11-18 16:16 ` Ross Zwisler
2015-11-18 16:16 ` Ross Zwisler
2015-11-14 0:06 ` [PATCH v2 04/11] dax: support dirty DAX entries in radix tree Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-14 0:06 ` [PATCH v2 05/11] mm: add follow_pte_pmd() Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-14 0:06 ` [PATCH v2 06/11] mm: add pgoff_mkclean() Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-14 0:06 ` [PATCH v2 07/11] mm: add find_get_entries_tag() Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-16 22:42 ` Dave Chinner
2015-11-16 22:42 ` Dave Chinner
2015-11-16 22:42 ` Dave Chinner
2015-11-17 18:08 ` Ross Zwisler
2015-11-17 18:08 ` Ross Zwisler
2015-11-17 18:08 ` Ross Zwisler
2015-11-14 0:06 ` [PATCH v2 08/11] dax: add support for fsync/sync Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-16 22:58 ` Dave Chinner
2015-11-16 22:58 ` Dave Chinner
2015-11-16 22:58 ` Dave Chinner
2015-11-17 18:30 ` Ross Zwisler
2015-11-17 18:30 ` Ross Zwisler
2015-11-17 18:30 ` Ross Zwisler
2015-11-14 0:06 ` [PATCH v2 09/11] ext2: add support for DAX fsync/msync Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-14 0:06 ` [PATCH v2 10/11] ext4: " Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-14 0:06 ` [PATCH v2 11/11] xfs: " Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-14 0:06 ` Ross Zwisler
2015-11-16 23:12 ` Dave Chinner
2015-11-16 23:12 ` Dave Chinner
2015-11-16 23:12 ` Dave Chinner
2015-11-16 23:12 ` Dave Chinner
2015-11-17 19:03 ` Ross Zwisler
2015-11-17 19:03 ` Ross Zwisler
2015-11-17 19:03 ` Ross Zwisler
2015-11-17 19:03 ` Ross Zwisler
2015-11-20 0:37 ` Dave Chinner
2015-11-20 0:37 ` Dave Chinner
2015-11-20 0:37 ` Dave Chinner
2015-11-16 14:41 ` [PATCH v2 00/11] DAX fsynx/msync support Jan Kara
2015-11-16 14:41 ` Jan Kara
2015-11-16 14:41 ` Jan Kara
2015-11-16 16:58 ` Dan Williams
2015-11-16 16:58 ` Dan Williams
2015-11-16 16:58 ` Dan Williams
2015-11-16 16:58 ` Dan Williams
2015-11-16 20:01 ` Ross Zwisler
2015-11-16 20:01 ` Ross Zwisler
2015-11-16 20:01 ` Ross Zwisler
2015-11-16 20:01 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151117175243.GA28024@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=david@fromorbit.com \
--cc=hpa@zytor.com \
--cc=jack@suse.com \
--cc=jlayton@poochiereds.net \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=matthew.r.wilcox@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@linux.intel.com \
--cc=x86@kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.