[nftables] goto vs jump documentation

[nftables] goto vs jump documentation

[Arturo Borrero Gonzalez]

Hi,

I've documented the difference between goto and jump in the nftables wiki [0].

Let me know if that's OK.

regards.

[0] http://wiki.nftables.org/wiki-nftables/index.php/Jumping_to_chain

-- 
Arturo Borrero González
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [nftables] goto vs jump documentation

[Pablo Neira Ayuso]

On Fri, Nov 20, 2015 at 02:45:31PM +0100, Arturo Borrero Gonzalez wrote:
> Hi,
> 
> I've documented the difference between goto and jump in the nftables wiki [0].
> 
> Let me know if that's OK.

This looks good.

I'd suggest you place this into add this into a new article:

"Going to chain"

just after the existing "Jumping to chain". No changes in the content,
I like that you use the jump concept as reference to explain this new
one.

Re: [nftables] goto vs jump documentation

[Patrick McHardy]

On 24.11, Pablo Neira Ayuso wrote:
> On Fri, Nov 20, 2015 at 02:45:31PM +0100, Arturo Borrero Gonzalez wrote:
> > Hi,
> > 
> > I've documented the difference between goto and jump in the nftables wiki [0].
> > 
> > Let me know if that's OK.
> 
> This looks good.
> 
> I'd suggest you place this into add this into a new article:
> 
> "Going to chain"
> 
> just after the existing "Jumping to chain". No changes in the content,
> I like that you use the jump concept as reference to explain this new
> one.

Really in a new article? The difference is not really about the jumping,
both do that, the difference is in returning. "Going to" sounds a
unfamiliar to me.

Re: [nftables] goto vs jump documentation

[Jan Engelhardt]

On Tuesday 2015-11-24 18:02, Patrick McHardy wrote:
>On 24.11, Pablo Neira Ayuso wrote:
>> On Fri, Nov 20, 2015 at 02:45:31PM +0100, Arturo Borrero Gonzalez wrote:
>> > Hi,
>> > 
>> > I've documented the difference between goto and jump in the nftables wiki [0].
>> > 
>> > Let me know if that's OK.
>> 
>> This looks good.
>> 
>> I'd suggest you place this into add this into a new article:
>> 
>> "Going to chain"
>> 
>> just after the existing "Jumping to chain". No changes in the content,
>> I like that you use the jump concept as reference to explain this new
>> one.
>
>Really in a new article? The difference is not really about the jumping,
>both do that, the difference is in returning. "Going to" sounds a
>unfamiliar to me.

I concur, in particular because of the curious choice of keywords once 
upon many moons. I would even suggest to name the section title 
"Invoking other chains" so as to avoid using terms with 
implementation-specific meaning before they are explained. Think someone 
skimming through the TOC..

Re: [nftables] goto vs jump documentation

[Patrick McHardy]

On 25.11, Jan Engelhardt wrote:
> 
> On Tuesday 2015-11-24 18:02, Patrick McHardy wrote:
> >On 24.11, Pablo Neira Ayuso wrote:
> >> On Fri, Nov 20, 2015 at 02:45:31PM +0100, Arturo Borrero Gonzalez wrote:
> >> > Hi,
> >> > 
> >> > I've documented the difference between goto and jump in the nftables wiki [0].
> >> > 
> >> > Let me know if that's OK.
> >> 
> >> This looks good.
> >> 
> >> I'd suggest you place this into add this into a new article:
> >> 
> >> "Going to chain"
> >> 
> >> just after the existing "Jumping to chain". No changes in the content,
> >> I like that you use the jump concept as reference to explain this new
> >> one.
> >
> >Really in a new article? The difference is not really about the jumping,
> >both do that, the difference is in returning. "Going to" sounds a
> >unfamiliar to me.
> 
> I concur, in particular because of the curious choice of keywords once 
> upon many moons. I would even suggest to name the section title 
> "Invoking other chains" so as to avoid using terms with 
> implementation-specific meaning before they are explained. Think someone 
> skimming through the TOC..

I agree, that's way better.