All of lore.kernel.org
 help / color / mirror / Atom feed
From: Francois Romieu <romieu@fr.zoreil.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>,
	jcliburn@gmail.com, chris.snook@gmail.com,
	netdev@vger.kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	linux-mm@kvack.org, nic-devel@qualcomm.com, ronangeles@gmail.com,
	ebiederm@xmission.com, David Miller <davem@davemloft.net>
Subject: Re: 4.3+: Atheros ethernet fails after resume from s2ram, due to order 4 allocation
Date: Thu, 26 Nov 2015 22:56:39 +0100	[thread overview]
Message-ID: <20151126215638.GA22801@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20151126163413.GA3816@amd>

Pavel Machek <pavel@ucw.cz> :
[...]
> Ok, so what went on is easy.. any ideas how to fix it ?

The driver should 1) prohibit holes in its receive ring, 2) allocate before
pushing data up in the stack 3) drop packets when it can't allocate a
fresh buffer and 4) stop releasing receive buffers - and any resource for
that matter - during suspend.

Really.

-- 
Ueimor

WARNING: multiple messages have this Message-ID (diff)
From: Francois Romieu <romieu@fr.zoreil.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>,
	jcliburn@gmail.com, chris.snook@gmail.com,
	netdev@vger.kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	linux-mm@kvack.org, nic-devel@qualcomm.com, ronangeles@gmail.com,
	ebiederm@xmission.com, David Miller <davem@davemloft.net>
Subject: Re: 4.3+: Atheros ethernet fails after resume from s2ram, due to order 4 allocation
Date: Thu, 26 Nov 2015 22:56:39 +0100	[thread overview]
Message-ID: <20151126215638.GA22801@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20151126163413.GA3816@amd>

Pavel Machek <pavel@ucw.cz> :
[...]
> Ok, so what went on is easy.. any ideas how to fix it ?

The driver should 1) prohibit holes in its receive ring, 2) allocate before
pushing data up in the stack 3) drop packets when it can't allocate a
fresh buffer and 4) stop releasing receive buffers - and any resource for
that matter - during suspend.

Really.

-- 
Ueimor

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2015-11-26 21:56 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-26 16:34 4.3+: Atheros ethernet fails after resume from s2ram, due to order 4 allocation Pavel Machek
2015-11-26 16:34 ` Pavel Machek
2015-11-26 16:34 ` Pavel Machek
2015-11-26 21:56 ` Francois Romieu [this message]
2015-11-26 21:56   ` Francois Romieu
2015-11-27  8:20 ` Michal Hocko
2015-11-27  8:20   ` Michal Hocko
2015-11-28 14:50   ` Pavel Machek
2015-11-28 14:50     ` Pavel Machek
2015-11-28 14:51   ` [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation Pavel Machek
2015-11-28 14:51     ` Pavel Machek
2015-11-29 21:58     ` Sergei Shtylyov
2015-11-29 21:58       ` Sergei Shtylyov
2015-11-30 13:21     ` Michal Hocko
2015-11-30 13:21       ` Michal Hocko
2015-12-01 20:35       ` David Miller
2015-12-01 20:35         ` David Miller
2015-12-02 22:43         ` Chris Snook
2015-12-03  7:49           ` Pavel Machek
2015-12-03  7:49             ` Pavel Machek
2015-12-03  7:49             ` Pavel Machek
2015-12-03  8:16           ` Michal Hocko
2015-12-03  8:16             ` Michal Hocko
2015-12-03  8:16             ` Michal Hocko
2015-12-03 19:26             ` Chris Snook
2015-11-30 17:58     ` Eric Dumazet
2015-11-30 17:58       ` Eric Dumazet
2015-11-30 17:58       ` Eric Dumazet
2015-12-01 20:36       ` David Miller
2015-12-01 20:36         ` David Miller
2015-12-03 15:59         ` Pavel Machek
2015-12-03 15:59           ` Pavel Machek
2015-12-03 15:59     ` [PATCH net] atl1c: Improve " Pavel Machek
2015-12-03 15:59       ` Pavel Machek
2015-12-03 16:13       ` Michal Hocko
2015-12-03 16:13         ` Michal Hocko
2015-12-03 17:17       ` Eric Dumazet
2015-12-03 17:17         ` Eric Dumazet
2015-12-03 17:17         ` Eric Dumazet
2015-12-03 17:32         ` David Miller
2015-12-03 17:32           ` David Miller
2015-12-04  8:11           ` Pavel Machek
2015-12-04  8:11             ` Pavel Machek
2015-12-04 16:21             ` David Miller
2015-12-04 16:21               ` David Miller
2015-12-04 21:30               ` Pavel Machek
2015-12-04 21:30                 ` Pavel Machek
2015-12-04 22:01                 ` David Miller
2015-12-04 22:01                   ` David Miller
2015-12-04  8:50       ` Pavel Machek
2015-12-04  8:50         ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151126215638.GA22801@electric-eye.fr.zoreil.com \
    --to=romieu@fr.zoreil.com \
    --cc=chris.snook@gmail.com \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=jcliburn@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=netdev@vger.kernel.org \
    --cc=nic-devel@qualcomm.com \
    --cc=pavel@ucw.cz \
    --cc=rjw@rjwysocki.net \
    --cc=ronangeles@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.