From: Alexandre Belloni <alexandre.belloni@free-electrons.com> To: Julius Werner <jwerner@chromium.org> Cc: Andrew Morton <akpm@linux-foundation.org>, Alessandro Zummo <a.zummo@towertech.it>, Doug Anderson <dianders@chromium.org>, Sonny Rao <sonnyrao@chromium.org>, Chris Zhong <zyw@rock-chips.com>, Heiko Stuebner <heiko@sntech.de>, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Subject: Re: [rtc-linux] [PATCH] RTC: RK808: Work around hardware bug on November 31st Date: Thu, 3 Dec 2015 15:42:03 +0100 [thread overview] Message-ID: <20151203144203.GA3515@piout.net> (raw) In-Reply-To: <1449107584-3192-1-git-send-email-jwerner@chromium.org> Hi, I would have liked to be in copy of that mail. Maybe you used get_maintainers on an old tree? On 02/12/2015 at 17:53:04 -0800, Julius Werner wrote : > In Fuzhou, China, the month of November seems to be having 31 days. > That's nice and all (I'm sure you can get a lot more done in a year that > way), but back here in other parts of the world we are not so lucky. > Therefore, if we read that date from the RTC we should correct it to > December 1st. > Wow, nice one... I hope reading the time properly fails thanks to the rtc_valid_tm(tm) in __rtc_read_time(). > This is not a full workaround. Since the RTC actually ticks all the way > through that imaginary day, there's no easy way to detect and correct > this issue if the device was offline the whole time and allowed it to > tick through to December 1st on the Rockchip calendar (which would be > December 2nd on the Gregorian one). Those edge cases can only really be > solved by regularly syncing to an external time source (e.g. NTP). > It will also happen if nobody reads the RTC time for that day (highly improbable in a default configuration). Do you need that patch for 4.4 or can it wait 4.5? > Signed-off-by: Julius Werner <jwerner@chromium.org> > Reviewed-by: Chris Zhong <zyw@rock-chips.com> > --- > drivers/rtc/rtc-rk808.c | 93 ++++++++++++++++++++++++++----------------------- > 1 file changed, 50 insertions(+), 43 deletions(-) > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com> To: Julius Werner <jwerner@chromium.org> Cc: Andrew Morton <akpm@linux-foundation.org>, Alessandro Zummo <a.zummo@towertech.it>, Doug Anderson <dianders@chromium.org>, Sonny Rao <sonnyrao@chromium.org>, Chris Zhong <zyw@rock-chips.com>, Heiko Stuebner <heiko@sntech.de>, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Subject: Re: [rtc-linux] [PATCH] RTC: RK808: Work around hardware bug on November 31st Date: Thu, 3 Dec 2015 15:42:03 +0100 [thread overview] Message-ID: <20151203144203.GA3515@piout.net> (raw) In-Reply-To: <1449107584-3192-1-git-send-email-jwerner@chromium.org> Hi, I would have liked to be in copy of that mail. Maybe you used get_maintainers on an old tree? On 02/12/2015 at 17:53:04 -0800, Julius Werner wrote : > In Fuzhou, China, the month of November seems to be having 31 days. > That's nice and all (I'm sure you can get a lot more done in a year that > way), but back here in other parts of the world we are not so lucky. > Therefore, if we read that date from the RTC we should correct it to > December 1st. > Wow, nice one... I hope reading the time properly fails thanks to the rtc_valid_tm(tm) in __rtc_read_time(). > This is not a full workaround. Since the RTC actually ticks all the way > through that imaginary day, there's no easy way to detect and correct > this issue if the device was offline the whole time and allowed it to > tick through to December 1st on the Rockchip calendar (which would be > December 2nd on the Gregorian one). Those edge cases can only really be > solved by regularly syncing to an external time source (e.g. NTP). > It will also happen if nobody reads the RTC time for that day (highly improbable in a default configuration). Do you need that patch for 4.4 or can it wait 4.5? > Signed-off-by: Julius Werner <jwerner@chromium.org> > Reviewed-by: Chris Zhong <zyw@rock-chips.com> > --- > drivers/rtc/rtc-rk808.c | 93 ++++++++++++++++++++++++++----------------------- > 1 file changed, 50 insertions(+), 43 deletions(-) > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2015-12-03 14:42 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-12-03 1:53 [PATCH] RTC: RK808: Work around hardware bug on November 31st Julius Werner 2015-12-03 1:53 ` [rtc-linux] " Julius Werner 2015-12-03 14:42 ` Alexandre Belloni [this message] 2015-12-03 14:42 ` Alexandre Belloni 2015-12-03 16:53 ` Julius Werner 2015-12-03 16:53 ` Julius Werner 2015-12-04 23:50 ` Doug Anderson 2015-12-04 23:50 ` [rtc-linux] " Doug Anderson 2015-12-05 0:25 ` Julius Werner 2015-12-05 0:25 ` [rtc-linux] " Julius Werner 2015-12-05 0:58 ` Doug Anderson 2015-12-05 0:58 ` [rtc-linux] " Doug Anderson 2015-12-05 1:54 ` Julius Werner 2015-12-05 1:54 ` [rtc-linux] " Julius Werner 2015-12-05 4:02 ` Doug Anderson 2015-12-05 4:02 ` [rtc-linux] " Doug Anderson 2015-12-05 4:53 ` Doug Anderson 2015-12-05 4:53 ` [rtc-linux] " Doug Anderson 2015-12-05 7:17 ` Julius Werner 2015-12-05 7:17 ` [rtc-linux] " Julius Werner 2015-12-06 0:36 ` Doug Anderson 2015-12-06 0:36 ` [rtc-linux] " Doug Anderson 2015-12-07 1:33 ` Chris Zhong 2015-12-07 1:33 ` [rtc-linux] " Chris Zhong 2015-12-07 2:50 ` Doug Anderson 2015-12-07 2:50 ` [rtc-linux] " Doug Anderson 2015-12-07 2:52 ` Doug Anderson 2015-12-07 2:52 ` [rtc-linux] " Doug Anderson 2015-12-07 3:08 ` Chris Zhong 2015-12-07 3:08 ` [rtc-linux] " Chris Zhong 2015-12-07 20:28 ` Julius Werner 2015-12-07 20:28 ` [rtc-linux] " Julius Werner 2015-12-07 22:40 ` Julius Werner 2015-12-07 22:40 ` [rtc-linux] " Julius Werner 2015-12-08 1:17 ` Doug Anderson 2015-12-08 1:17 ` [rtc-linux] " Doug Anderson 2015-12-08 1:41 ` Julius Werner 2015-12-08 1:41 ` [rtc-linux] " Julius Werner 2015-12-08 5:19 ` Julius Werner 2015-12-08 5:19 ` [rtc-linux] " Julius Werner 2015-12-08 5:21 ` [PATCH v2] " Julius Werner 2015-12-08 5:21 ` [rtc-linux] " Julius Werner 2015-12-09 5:44 ` Doug Anderson 2015-12-09 5:44 ` [rtc-linux] " Doug Anderson 2015-12-09 21:32 ` Julius Werner 2015-12-09 21:32 ` [rtc-linux] " Julius Werner 2015-12-10 18:41 ` Alexandre Belloni 2015-12-10 18:41 ` [rtc-linux] " Alexandre Belloni 2015-12-10 18:57 ` Julius Werner 2015-12-10 18:57 ` [rtc-linux] " Julius Werner 2015-12-15 23:02 ` [PATCHv3] RTC: RK808: Compensate for Rockchip calendar deviation " Julius Werner 2015-12-15 23:02 ` [rtc-linux] " Julius Werner 2015-12-15 23:14 ` Julius Werner 2015-12-15 23:14 ` [rtc-linux] " Julius Werner 2015-12-19 0:25 ` Doug Anderson 2015-12-19 0:25 ` [rtc-linux] " Doug Anderson 2015-12-19 0:31 ` Julius Werner 2015-12-19 0:31 ` [rtc-linux] " Julius Werner 2015-12-19 0:26 ` Doug Anderson 2015-12-19 0:26 ` [rtc-linux] " Doug Anderson 2015-12-21 8:16 ` Alexandre Belloni 2015-12-21 8:16 ` [rtc-linux] " Alexandre Belloni
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20151203144203.GA3515@piout.net \ --to=alexandre.belloni@free-electrons.com \ --cc=a.zummo@towertech.it \ --cc=akpm@linux-foundation.org \ --cc=dianders@chromium.org \ --cc=heiko@sntech.de \ --cc=jwerner@chromium.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rtc-linux@googlegroups.com \ --cc=sonnyrao@chromium.org \ --cc=zyw@rock-chips.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.