From: Andrew Morton <akpm@linux-foundation.org>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
"Theodore Ts'o" <tytso@mit.edu>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Dave Chinner <david@fromorbit.com>,
Ingo Molnar <mingo@redhat.com>, Jan Kara <jack@suse.com>,
Jeff Layton <jlayton@poochiereds.net>,
Matthew Wilcox <willy@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-nvdimm@ml01.01.org, x86@kernel.org,
xfs@oss.sgi.com, Dan Williams <dan.j.williams@intel.com>,
Matthew Wilcox <matthew.r.wilcox@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v5 3/7] mm: add find_get_entries_tag()
Date: Tue, 22 Dec 2015 14:46:11 -0800 [thread overview]
Message-ID: <20151222144611.07002cfde41d035125da2fa5@linux-foundation.org> (raw)
In-Reply-To: <1450502540-8744-4-git-send-email-ross.zwisler@linux.intel.com>
On Fri, 18 Dec 2015 22:22:16 -0700 Ross Zwisler <ross.zwisler@linux.intel.com> wrote:
> Add find_get_entries_tag() to the family of functions that include
> find_get_entries(), find_get_pages() and find_get_pages_tag(). This is
> needed for DAX dirty page handling because we need a list of both page
> offsets and radix tree entries ('indices' and 'entries' in this function)
> that are marked with the PAGECACHE_TAG_TOWRITE tag.
>
> ...
>
> +EXPORT_SYMBOL(find_get_entries_tag);
This is actually a pretty crappy name because it doesn't describe what
subsystem it belongs to. scheduler? scatter/gather? filesystem?
But given what we've already done, I don't see an obvious fix.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
"Theodore Ts'o" <tytso@mit.edu>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Dave Chinner <david@fromorbit.com>,
Ingo Molnar <mingo@redhat.com>, Jan Kara <jack@suse.com>,
Jeff Layton <jlayton@poochiereds.net>,
Matthew Wilcox <willy@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-nvdimm@ml01.01.org, x86@kernel.org,
xfs@oss.sgi.com, Dan Williams <dan.j.williams@intel.com>,
Matthew Wilcox <matthew.r.wilcox@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v5 3/7] mm: add find_get_entries_tag()
Date: Tue, 22 Dec 2015 14:46:11 -0800 [thread overview]
Message-ID: <20151222144611.07002cfde41d035125da2fa5@linux-foundation.org> (raw)
In-Reply-To: <1450502540-8744-4-git-send-email-ross.zwisler@linux.intel.com>
On Fri, 18 Dec 2015 22:22:16 -0700 Ross Zwisler <ross.zwisler@linux.intel.com> wrote:
> Add find_get_entries_tag() to the family of functions that include
> find_get_entries(), find_get_pages() and find_get_pages_tag(). This is
> needed for DAX dirty page handling because we need a list of both page
> offsets and radix tree entries ('indices' and 'entries' in this function)
> that are marked with the PAGECACHE_TAG_TOWRITE tag.
>
> ...
>
> +EXPORT_SYMBOL(find_get_entries_tag);
This is actually a pretty crappy name because it doesn't describe what
subsystem it belongs to. scheduler? scatter/gather? filesystem?
But given what we've already done, I don't see an obvious fix.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: x86@kernel.org, Theodore Ts'o <tytso@mit.edu>,
linux-nvdimm@ml01.01.org, Jan Kara <jack@suse.com>,
linux-kernel@vger.kernel.org,
Dave Hansen <dave.hansen@linux.intel.com>,
xfs@oss.sgi.com, "J. Bruce Fields" <bfields@fieldses.org>,
linux-mm@kvack.org, Ingo Molnar <mingo@redhat.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Alexander Viro <viro@zeniv.linux.org.uk>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-fsdevel@vger.kernel.org,
Matthew Wilcox <willy@linux.intel.com>,
Jeff Layton <jlayton@poochiereds.net>,
linux-ext4@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Dan Williams <dan.j.williams@intel.com>,
Matthew Wilcox <matthew.r.wilcox@intel.com>
Subject: Re: [PATCH v5 3/7] mm: add find_get_entries_tag()
Date: Tue, 22 Dec 2015 14:46:11 -0800 [thread overview]
Message-ID: <20151222144611.07002cfde41d035125da2fa5@linux-foundation.org> (raw)
In-Reply-To: <1450502540-8744-4-git-send-email-ross.zwisler@linux.intel.com>
On Fri, 18 Dec 2015 22:22:16 -0700 Ross Zwisler <ross.zwisler@linux.intel.com> wrote:
> Add find_get_entries_tag() to the family of functions that include
> find_get_entries(), find_get_pages() and find_get_pages_tag(). This is
> needed for DAX dirty page handling because we need a list of both page
> offsets and radix tree entries ('indices' and 'entries' in this function)
> that are marked with the PAGECACHE_TAG_TOWRITE tag.
>
> ...
>
> +EXPORT_SYMBOL(find_get_entries_tag);
This is actually a pretty crappy name because it doesn't describe what
subsystem it belongs to. scheduler? scatter/gather? filesystem?
But given what we've already done, I don't see an obvious fix.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-12-22 22:46 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-19 5:22 [PATCH v5 0/7] DAX fsync/msync support Ross Zwisler
2015-12-19 5:22 ` Ross Zwisler
2015-12-19 5:22 ` Ross Zwisler
2015-12-19 5:22 ` [PATCH v5 1/7] pmem: add wb_cache_pmem() to the PMEM API Ross Zwisler
2015-12-19 5:22 ` Ross Zwisler
2015-12-19 5:22 ` Ross Zwisler
2015-12-22 22:44 ` Andrew Morton
2015-12-22 22:44 ` Andrew Morton
2015-12-22 22:44 ` Andrew Morton
2015-12-23 0:00 ` Ross Zwisler
2015-12-23 0:00 ` Ross Zwisler
2015-12-23 0:00 ` Ross Zwisler
2015-12-19 5:22 ` [PATCH v5 2/7] dax: support dirty DAX entries in radix tree Ross Zwisler
2015-12-19 5:22 ` Ross Zwisler
2015-12-19 5:22 ` Ross Zwisler
2015-12-21 17:15 ` Jan Kara
2015-12-21 17:15 ` Jan Kara
2015-12-21 17:15 ` Jan Kara
2015-12-21 17:15 ` Jan Kara
2015-12-21 17:45 ` Ross Zwisler
2015-12-21 17:45 ` Ross Zwisler
2015-12-21 17:45 ` Ross Zwisler
2015-12-22 22:46 ` Andrew Morton
2015-12-22 22:46 ` Andrew Morton
2015-12-22 22:46 ` Andrew Morton
2015-12-23 0:16 ` Ross Zwisler
2015-12-23 0:16 ` Ross Zwisler
2015-12-23 0:16 ` Ross Zwisler
2015-12-19 5:22 ` [PATCH v5 3/7] mm: add find_get_entries_tag() Ross Zwisler
2015-12-19 5:22 ` Ross Zwisler
2015-12-19 5:22 ` Ross Zwisler
2015-12-22 22:46 ` Andrew Morton [this message]
2015-12-22 22:46 ` Andrew Morton
2015-12-22 22:46 ` Andrew Morton
2015-12-19 5:22 ` [PATCH v5 4/7] dax: add support for fsync/sync Ross Zwisler
2015-12-19 5:22 ` Ross Zwisler
2015-12-19 5:22 ` Ross Zwisler
2015-12-19 18:37 ` Dan Williams
2015-12-19 18:37 ` Dan Williams
2015-12-19 18:37 ` Dan Williams
2015-12-21 17:05 ` Ross Zwisler
2015-12-21 17:05 ` Ross Zwisler
2015-12-21 17:05 ` Ross Zwisler
2015-12-21 17:49 ` Dan Williams
2015-12-21 17:49 ` Dan Williams
2015-12-21 17:49 ` Dan Williams
2015-12-21 17:49 ` Dan Williams
2015-12-21 19:27 ` Dan Williams
2015-12-21 19:27 ` Dan Williams
2015-12-21 19:27 ` Dan Williams
2015-12-21 19:27 ` Dan Williams
2015-12-22 22:46 ` Andrew Morton
2015-12-22 22:46 ` Andrew Morton
2015-12-22 22:46 ` Andrew Morton
2015-12-22 23:51 ` Ross Zwisler
2015-12-22 23:51 ` Ross Zwisler
2015-12-22 23:51 ` Ross Zwisler
2015-12-19 5:22 ` [PATCH v5 5/7] ext2: call dax_pfn_mkwrite() for DAX fsync/msync Ross Zwisler
2015-12-19 5:22 ` Ross Zwisler
2015-12-19 5:22 ` Ross Zwisler
2015-12-21 17:32 ` Jan Kara
2015-12-21 17:32 ` Jan Kara
2015-12-21 17:32 ` Jan Kara
2015-12-21 17:32 ` Jan Kara
2015-12-19 5:22 ` [PATCH v5 6/7] ext4: " Ross Zwisler
2015-12-19 5:22 ` Ross Zwisler
2015-12-19 5:22 ` Ross Zwisler
2015-12-21 17:32 ` Jan Kara
2015-12-21 17:32 ` Jan Kara
2015-12-21 17:32 ` Jan Kara
2015-12-19 5:22 ` [PATCH v5 7/7] xfs: " Ross Zwisler
2015-12-19 5:22 ` Ross Zwisler
2015-12-19 5:22 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151222144611.07002cfde41d035125da2fa5@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adilger.kernel@dilger.ca \
--cc=bfields@fieldses.org \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@fromorbit.com \
--cc=hpa@zytor.com \
--cc=jack@suse.com \
--cc=jlayton@poochiereds.net \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=matthew.r.wilcox@intel.com \
--cc=mingo@redhat.com \
--cc=ross.zwisler@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@linux.intel.com \
--cc=x86@kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.