All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: "Uwe Kleine-König"
	<u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	LABBE Corentin
	<montjoie.mailing-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	LABBE Corentin
	<clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
	swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c: tegra: fix a possible NULL dereference
Date: Sat, 23 Jan 2016 11:56:46 +0100	[thread overview]
Message-ID: <20160123105645.GA2036@katana> (raw)
In-Reply-To: <20151112134519.GJ24008-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

Hi Uwe,

> That's equivalent to
> 
> 	if (dev->of_node)
> 		return of_driver_match_device(dev, drv);
> 
> and was already suggested in the thread referenced from my reply to
> http://article.gmane.org/gmane.linux.kernel/2083641 :-)

Did you make a proper patch out of it? Can't find it, though I also
think this would be useful.

Acked-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>

All the best,

   Wolfram

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	LABBE Corentin <montjoie.mailing@gmail.com>,
	LABBE Corentin <clabbe.montjoie@gmail.com>,
	gnurou@gmail.com, ldewangan@nvidia.com, swarren@wwwdotorg.org,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-tegra@vger.kernel.org
Subject: Re: [PATCH] i2c: tegra: fix a possible NULL dereference
Date: Sat, 23 Jan 2016 11:56:46 +0100	[thread overview]
Message-ID: <20160123105645.GA2036@katana> (raw)
In-Reply-To: <20151112134519.GJ24008@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

Hi Uwe,

> That's equivalent to
> 
> 	if (dev->of_node)
> 		return of_driver_match_device(dev, drv);
> 
> and was already suggested in the thread referenced from my reply to
> http://article.gmane.org/gmane.linux.kernel/2083641 :-)

Did you make a proper patch out of it? Can't find it, though I also
think this would be useful.

Acked-by: Wolfram Sang <wsa@the-dreams.de>

All the best,

   Wolfram

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2016-01-23 10:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-12  7:26 [PATCH] i2c: tegra: fix a possible NULL dereference LABBE Corentin
2015-11-12 12:29 ` Thierry Reding
2015-11-12 12:54   ` LABBE Corentin
2015-11-12 13:28     ` Thierry Reding
2015-11-12 13:28       ` Thierry Reding
2015-11-12 13:45       ` Uwe Kleine-König
     [not found]         ` <20151112134519.GJ24008-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2015-11-12 13:55           ` Thierry Reding
2015-11-12 13:55             ` Thierry Reding
2015-11-12 14:54             ` LABBE Corentin
2015-11-12 16:14               ` Thierry Reding
2015-11-12 16:14                 ` Thierry Reding
2016-01-23 11:07               ` Wolfram Sang
2016-01-23 11:07                 ` Wolfram Sang
2016-01-23 10:56           ` Wolfram Sang [this message]
2016-01-23 10:56             ` Wolfram Sang
2015-11-12 13:40   ` Jon Hunter
2015-11-12 13:40     ` Jon Hunter
2015-11-12 13:55     ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160123105645.GA2036@katana \
    --to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
    --cc=clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=montjoie.mailing-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.