From: Mark Brown <broonie@kernel.org> To: Michal Suchanek <hramrach@gmail.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Ingo Molnar <mingo@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, Kees Cook <keescook@chromium.org>, Thomas Gleixner <tglx@linutronix.de>, Dan Williams <dan.j.williams@intel.com>, Tejun Heo <tj@kernel.org>, "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>, Davidlohr Bueso <dave@stgolabs.net>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Nikolay Aleksandrov <nikolay@cumulusnetworks.com>, Dmitry Vyukov <dvyukov@google.com>, Adrien Schildknecht <adrien+dev@schischi.me>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-spi <linux-spi@vger.kernel.org> Subject: Re: [PATCH 2/3] spi: of: allow instantiating slaves without a driver Date: Sun, 26 Jun 2016 12:21:33 +0100 [thread overview] Message-ID: <20160626112133.GJ28202@sirena.org.uk> (raw) In-Reply-To: <CAOMqctSA0G+fBKNgAizqWvEUfJLr9Fh0SsN0Pn-cQv=zeu7iFg@mail.gmail.com> [-- Attachment #1: Type: text/plain, Size: 1534 bytes --] On Sun, Jun 26, 2016 at 04:23:41AM +0200, Michal Suchanek wrote: > On 26 June 2016 at 03:15, Mark Brown <broonie@kernel.org> wrote: > > I can't relate this hunk to the changelog and there's a coding style > > problem, if there's { } on one side of an if statement it should be on > > both sides. Why are we making this change? > The intention is that you can specify that your SPI master controller > has a CS available without setting up the slave This is completely unrelated to the rest of the change and needs describing in the changelog. > Then you can amend the slave node with an overlay or bind a driver > that can deal with the node having no configuration. You can just add the entire slave node in the overlay, it's not clear that this buys us anything useful (and typically you'd want to as the maximum speed here is more a function of the slave device than the master), and this needs to be joined up with the work going on to allow expansion connector overlays to be loaded in the first place. > The check here isn't very effective anyway since slaves with zero > speed somehow creep into the kernel. I have seen people reporting > division by zero in SPI master driver as a result. The proper way to > fix this is to specify the master minimum and maximum speed limit so > the SPI core can reject transfers with speed outside of the allowed > range. That's a separate argument which is again unrelated to the changelog. If the check isn't working it would be better to have an analysis of why it's not working. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> To: Michal Suchanek <hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Cc: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>, Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>, Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>, Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>, Dan Williams <dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "Paul E. McKenney" <paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>, Davidlohr Bueso <dave-h16yJtLeMjHk1uMJSBkQmQ@public.gmane.org>, Andrey Ryabinin <aryabinin-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>, Nikolay Aleksandrov <nikolay-qUQiAmfTcIp+XZJcv9eMoEEOCMrvLtNR@public.gmane.org>, Dmitry Vyukov <dvyukov-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, Adrien Schildknecht <adrien+dev-Yk6CzqVXkG6lnMjI0IkVqw@public.gmane.org>, Linux Kernel Mailing List <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, linux-spi <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH 2/3] spi: of: allow instantiating slaves without a driver Date: Sun, 26 Jun 2016 12:21:33 +0100 [thread overview] Message-ID: <20160626112133.GJ28202@sirena.org.uk> (raw) In-Reply-To: <CAOMqctSA0G+fBKNgAizqWvEUfJLr9Fh0SsN0Pn-cQv=zeu7iFg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> [-- Attachment #1: Type: text/plain, Size: 1563 bytes --] On Sun, Jun 26, 2016 at 04:23:41AM +0200, Michal Suchanek wrote: > On 26 June 2016 at 03:15, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote: > > I can't relate this hunk to the changelog and there's a coding style > > problem, if there's { } on one side of an if statement it should be on > > both sides. Why are we making this change? > The intention is that you can specify that your SPI master controller > has a CS available without setting up the slave This is completely unrelated to the rest of the change and needs describing in the changelog. > Then you can amend the slave node with an overlay or bind a driver > that can deal with the node having no configuration. You can just add the entire slave node in the overlay, it's not clear that this buys us anything useful (and typically you'd want to as the maximum speed here is more a function of the slave device than the master), and this needs to be joined up with the work going on to allow expansion connector overlays to be loaded in the first place. > The check here isn't very effective anyway since slaves with zero > speed somehow creep into the kernel. I have seen people reporting > division by zero in SPI master driver as a result. The proper way to > fix this is to specify the master minimum and maximum speed limit so > the SPI core can reject transfers with speed outside of the allowed > range. That's a separate argument which is again unrelated to the changelog. If the check isn't working it would be better to have an analysis of why it's not working. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-06-26 11:22 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-24 14:20 [PATCH 0/3] Another stab at making spidev usable with devicetree Michal Suchanek 2016-06-24 14:20 ` Michal Suchanek 2016-06-24 14:20 ` [PATCH 1/3] spi: spidev: fix the check for spidev in dt Michal Suchanek 2016-06-26 1:09 ` Mark Brown 2016-06-26 1:56 ` Michal Suchanek 2016-06-26 1:56 ` Michal Suchanek 2016-06-26 1:13 ` Mark Brown 2016-06-26 1:13 ` Mark Brown 2016-06-26 2:12 ` Michal Suchanek 2016-06-26 2:12 ` Michal Suchanek 2016-06-26 11:05 ` Mark Brown 2016-06-26 11:05 ` Mark Brown 2016-06-24 14:20 ` [PATCH 2/3] spi: of: allow instantiating slaves without a driver Michal Suchanek 2016-06-26 1:15 ` Mark Brown 2016-06-26 1:15 ` Mark Brown 2016-06-26 2:23 ` Michal Suchanek 2016-06-26 2:23 ` Michal Suchanek 2016-06-26 11:21 ` Mark Brown [this message] 2016-06-26 11:21 ` Mark Brown 2016-06-26 11:35 ` Michal Suchanek 2016-06-26 11:58 ` Mark Brown 2016-06-26 12:39 ` Michal Suchanek 2016-06-26 12:39 ` Michal Suchanek 2016-06-26 12:45 ` Mark Brown 2016-06-26 12:45 ` Mark Brown 2016-06-26 12:53 ` Michal Suchanek 2016-06-26 12:57 ` Mark Brown 2016-06-26 12:57 ` Mark Brown 2016-06-26 15:19 ` Michal Suchanek 2016-06-26 15:19 ` Michal Suchanek 2016-06-26 17:25 ` Mark Brown 2016-06-26 17:25 ` Mark Brown 2016-06-24 14:20 ` [PATCH 3/3] drivers core: allow id match override when manually binding driver Michal Suchanek 2016-06-26 1:17 ` Mark Brown 2016-06-26 1:17 ` Mark Brown 2016-06-26 4:14 ` Dan Williams 2016-06-26 6:44 ` Michal Suchanek 2016-06-26 6:44 ` Michal Suchanek 2016-06-26 9:26 ` Geert Uytterhoeven 2016-06-26 9:26 ` Geert Uytterhoeven 2016-06-26 18:28 ` Greg Kroah-Hartman 2016-06-26 18:28 ` Greg Kroah-Hartman 2016-06-26 19:07 ` Michal Suchanek 2016-06-26 19:07 ` Michal Suchanek 2016-06-27 19:09 ` Greg Kroah-Hartman 2016-06-27 19:09 ` Greg Kroah-Hartman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160626112133.GJ28202@sirena.org.uk \ --to=broonie@kernel.org \ --cc=adrien+dev@schischi.me \ --cc=akpm@linux-foundation.org \ --cc=aryabinin@virtuozzo.com \ --cc=dan.j.williams@intel.com \ --cc=dave@stgolabs.net \ --cc=dvyukov@google.com \ --cc=gregkh@linuxfoundation.org \ --cc=hramrach@gmail.com \ --cc=keescook@chromium.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=mingo@kernel.org \ --cc=nikolay@cumulusnetworks.com \ --cc=paulmck@linux.vnet.ibm.com \ --cc=tglx@linutronix.de \ --cc=tj@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.