From: Fam Zheng <famz@redhat.com> To: linux-kernel@vger.kernel.org Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>, Paul Mackerras <paulus@samba.org>, Michael Ellerman <mpe@ellerman.id.au>, Jens Axboe <axboe@kernel.dk>, "Ed L. Cashin" <ed.cashin@acm.org>, Jiri Kosina <jikos@kernel.org>, "Michael S. Tsirkin" <mst@redhat.com>, Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>, Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>, Shaohua Li <shli@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>, David Woodhouse <dwmw2@infradead.org>, Brian Norris <computersforpeace@gmail.com>, Keith Busch <keith.busch@intel.com>, linuxppc-dev@lists.ozlabs.org, linux-block@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-nvme@lists.infradead.org, Christoph Hellwig <hch@infradead.org>, famz@redhat.com Subject: [PATCH v2 12/12] nvme: Generate uevent after attribute available Date: Thu, 30 Jun 2016 09:59:53 +0800 [thread overview] Message-ID: <20160630015953.6888-13-famz@redhat.com> (raw) In-Reply-To: <20160630015953.6888-1-famz@redhat.com> It is documented that KOBJ_ADD should be generated after the object's attributes and children are ready. We can achieve this with the new disk_gen_uevents interface. Signed-off-by: Fam Zheng <famz@redhat.com> --- drivers/nvme/host/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index fd70894..2655521 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -1462,11 +1462,12 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, unsigned nsid) if (ns->type == NVME_NS_LIGHTNVM) return; - add_disk(ns->disk, true); + add_disk(ns->disk, false); if (sysfs_create_group(&disk_to_dev(ns->disk)->kobj, &nvme_ns_attr_group)) pr_warn("%s: failed to create sysfs group for identification\n", ns->disk->disk_name); + disk_gen_uevents(ns->disk); return; out_free_disk: kfree(disk); -- 2.9.0
WARNING: multiple messages have this Message-ID (diff)
From: famz@redhat.com (Fam Zheng) Subject: [PATCH v2 12/12] nvme: Generate uevent after attribute available Date: Thu, 30 Jun 2016 09:59:53 +0800 [thread overview] Message-ID: <20160630015953.6888-13-famz@redhat.com> (raw) In-Reply-To: <20160630015953.6888-1-famz@redhat.com> It is documented that KOBJ_ADD should be generated after the object's attributes and children are ready. We can achieve this with the new disk_gen_uevents interface. Signed-off-by: Fam Zheng <famz at redhat.com> --- drivers/nvme/host/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index fd70894..2655521 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -1462,11 +1462,12 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, unsigned nsid) if (ns->type == NVME_NS_LIGHTNVM) return; - add_disk(ns->disk, true); + add_disk(ns->disk, false); if (sysfs_create_group(&disk_to_dev(ns->disk)->kobj, &nvme_ns_attr_group)) pr_warn("%s: failed to create sysfs group for identification\n", ns->disk->disk_name); + disk_gen_uevents(ns->disk); return; out_free_disk: kfree(disk); -- 2.9.0
next prev parent reply other threads:[~2016-06-30 1:59 UTC|newest] Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-06-30 1:59 [PATCH v2 00/12] gendisk: Generate uevent after attribute available Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-06-30 1:59 ` [PATCH v2 01/12] genhd: Add "gen_uevent" parameter to add_disk Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-06-30 1:59 ` [PATCH v2 02/12] genhd: Honor gen_uevent and add disk_gen_uevents Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-06-30 3:26 ` kbuild test robot 2016-06-30 3:26 ` kbuild test robot 2016-06-30 3:26 ` kbuild test robot 2016-06-30 1:59 ` [PATCH v2 03/12] virtio-blk: Generate uevent after attribute available Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-06-30 1:59 ` [PATCH v2 04/12] axonrom: " Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-06-30 22:10 ` Dan Williams 2016-06-30 22:10 ` Dan Williams 2016-06-30 22:10 ` Dan Williams 2016-07-01 1:03 ` Fam Zheng 2016-07-01 1:03 ` Fam Zheng 2016-07-01 1:03 ` Fam Zheng 2016-06-30 22:10 ` Dan Williams 2016-06-30 1:59 ` [PATCH v2 05/12] aoeblk: " Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-07-01 0:57 ` Ed Cashin 2016-07-01 0:57 ` Ed Cashin 2016-07-01 0:57 ` Ed Cashin 2016-07-01 0:57 ` Ed Cashin 2016-06-30 1:59 ` [PATCH v2 06/12] mtip32xx: " Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-06-30 1:59 ` [PATCH v2 07/12] pktcdvd: " Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-06-30 1:59 ` [PATCH v2 08/12] zram: " Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-06-30 1:59 ` [PATCH v2 09/12] md: " Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-06-30 1:59 ` [PATCH v2 10/12] mmc: " Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-06-30 1:59 ` [PATCH v2 11/12] mtd: " Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-06-30 1:59 ` Fam Zheng 2016-06-30 1:59 ` [PATCH v2 12/12] nvme: " Fam Zheng 2016-06-30 1:59 ` Fam Zheng [this message] 2016-06-30 1:59 ` Fam Zheng 2016-06-30 6:24 ` [PATCH v2 00/12] gendisk: " Christoph Hellwig 2016-06-30 6:24 ` Christoph Hellwig 2016-06-30 6:24 ` Christoph Hellwig 2016-06-30 6:24 ` Christoph Hellwig 2016-06-30 6:35 ` Fam Zheng 2016-06-30 6:35 ` Fam Zheng 2016-06-30 6:35 ` Fam Zheng 2016-06-30 6:38 ` Christoph Hellwig 2016-06-30 6:38 ` Christoph Hellwig 2016-06-30 6:38 ` Christoph Hellwig 2016-07-01 1:01 ` Fam Zheng 2016-07-01 1:01 ` Fam Zheng 2016-07-01 1:01 ` Fam Zheng 2016-07-01 1:29 ` Dan Williams 2016-07-01 1:29 ` Dan Williams 2016-07-01 1:29 ` Dan Williams 2016-07-01 1:29 ` Dan Williams 2016-07-01 1:29 ` Dan Williams
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20160630015953.6888-13-famz@redhat.com \ --to=famz@redhat.com \ --cc=axboe@kernel.dk \ --cc=benh@kernel.crashing.org \ --cc=computersforpeace@gmail.com \ --cc=dwmw2@infradead.org \ --cc=ed.cashin@acm.org \ --cc=hch@infradead.org \ --cc=jikos@kernel.org \ --cc=keith.busch@intel.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-nvme@lists.infradead.org \ --cc=linux-raid@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=minchan@kernel.org \ --cc=mpe@ellerman.id.au \ --cc=mst@redhat.com \ --cc=ngupta@vflare.org \ --cc=paulus@samba.org \ --cc=sergey.senozhatsky.work@gmail.com \ --cc=shli@kernel.org \ --cc=ulf.hansson@linaro.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.