From: kbuild test robot <lkp@intel.com>
To: Ed Swierk <eswierk@skyportsystems.com>
Cc: kbuild-all@01.org, tpmdd-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
jarkko.sakkinen@linux.intel.com, jgunthorpe@obsidianresearch.com,
stefanb@us.ibm.com, eswierk@skyportsystems.com
Subject: Re: [PATCH v9 4/5] tpm: Allow TPM chip drivers to override reported command durations
Date: Thu, 14 Jul 2016 01:04:22 +0800 [thread overview]
Message-ID: <201607140110.TFmeezcv%fengguang.wu@intel.com> (raw)
In-Reply-To: <1468426776-42762-5-git-send-email-eswierk@skyportsystems.com>
[-- Attachment #1: Type: text/plain, Size: 3257 bytes --]
Hi,
[auto build test WARNING on next-20160712]
[cannot apply to char-misc/char-misc-testing v4.7-rc7 v4.7-rc6 v4.7-rc5 v4.7-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Ed-Swierk/tpm-Command-duration-logging-and-chip-specific-override/20160714-002547
config: i386-randconfig-s1-201628 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
drivers/char/tpm/tpm_tis_core.c: In function 'tpm_tis_update_timeouts':
>> drivers/char/tpm/tpm_tis_core.c:414:10: warning: 'return' with a value, in function returning void
return rc;
^~
drivers/char/tpm/tpm_tis_core.c:406:13: note: declared here
static void tpm_tis_update_timeouts(struct tpm_chip *chip)
^~~~~~~~~~~~~~~~~~~~~~~
vim +/return +414 drivers/char/tpm/tpm_tis_core.c
41a5e1cf Christophe Ricard 2016-05-19 398 if (!priv->irq_tested)
41a5e1cf Christophe Ricard 2016-05-19 399 msleep(1);
41a5e1cf Christophe Ricard 2016-05-19 400 if (!priv->irq_tested)
41a5e1cf Christophe Ricard 2016-05-19 401 disable_interrupts(chip);
41a5e1cf Christophe Ricard 2016-05-19 402 priv->irq_tested = true;
41a5e1cf Christophe Ricard 2016-05-19 403 return rc;
41a5e1cf Christophe Ricard 2016-05-19 404 }
41a5e1cf Christophe Ricard 2016-05-19 405
a7da7fe7 Ed Swierk 2016-07-13 406 static void tpm_tis_update_timeouts(struct tpm_chip *chip)
41a5e1cf Christophe Ricard 2016-05-19 407 {
41a5e1cf Christophe Ricard 2016-05-19 408 struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
a7da7fe7 Ed Swierk 2016-07-13 409 int rc;
41a5e1cf Christophe Ricard 2016-05-19 410 u32 did_vid;
41a5e1cf Christophe Ricard 2016-05-19 411
41a5e1cf Christophe Ricard 2016-05-19 412 rc = tpm_tis_read32(priv, TPM_DID_VID(0), &did_vid);
41a5e1cf Christophe Ricard 2016-05-19 413 if (rc < 0)
41a5e1cf Christophe Ricard 2016-05-19 @414 return rc;
41a5e1cf Christophe Ricard 2016-05-19 415
a7da7fe7 Ed Swierk 2016-07-13 416 switch (did_vid) {
a7da7fe7 Ed Swierk 2016-07-13 417 case 0x32041114: /* Atmel 3204 */
a7da7fe7 Ed Swierk 2016-07-13 418 chip->timeout_a = msecs_to_jiffies(TIS_SHORT_TIMEOUT);
a7da7fe7 Ed Swierk 2016-07-13 419 chip->timeout_b = msecs_to_jiffies(TIS_LONG_TIMEOUT);
a7da7fe7 Ed Swierk 2016-07-13 420 chip->timeout_c = msecs_to_jiffies(TIS_SHORT_TIMEOUT);
a7da7fe7 Ed Swierk 2016-07-13 421 chip->timeout_d = msecs_to_jiffies(TIS_SHORT_TIMEOUT);
a7da7fe7 Ed Swierk 2016-07-13 422 chip->timeout_adjusted = true;
:::::: The code at line 414 was first introduced by commit
:::::: 41a5e1cf1fe151ed48b4b3106c748d03a85133ce tpm/tpm_tis: Split tpm_tis driver into a core and TCG TIS compliant phy
:::::: TO: Christophe Ricard <christophe.ricard@gmail.com>
:::::: CC: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 22818 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, tpmdd-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
jarkko.sakkinen@linux.intel.com, jgunthorpe@obsidianresearch.com,
stefanb@us.ibm.com, eswierk@skyportsystems.com
Subject: Re: [PATCH v9 4/5] tpm: Allow TPM chip drivers to override reported command durations
Date: Thu, 14 Jul 2016 01:04:22 +0800 [thread overview]
Message-ID: <201607140110.TFmeezcv%fengguang.wu@intel.com> (raw)
In-Reply-To: <1468426776-42762-5-git-send-email-eswierk@skyportsystems.com>
[-- Attachment #1: Type: text/plain, Size: 3257 bytes --]
Hi,
[auto build test WARNING on next-20160712]
[cannot apply to char-misc/char-misc-testing v4.7-rc7 v4.7-rc6 v4.7-rc5 v4.7-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Ed-Swierk/tpm-Command-duration-logging-and-chip-specific-override/20160714-002547
config: i386-randconfig-s1-201628 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
drivers/char/tpm/tpm_tis_core.c: In function 'tpm_tis_update_timeouts':
>> drivers/char/tpm/tpm_tis_core.c:414:10: warning: 'return' with a value, in function returning void
return rc;
^~
drivers/char/tpm/tpm_tis_core.c:406:13: note: declared here
static void tpm_tis_update_timeouts(struct tpm_chip *chip)
^~~~~~~~~~~~~~~~~~~~~~~
vim +/return +414 drivers/char/tpm/tpm_tis_core.c
41a5e1cf Christophe Ricard 2016-05-19 398 if (!priv->irq_tested)
41a5e1cf Christophe Ricard 2016-05-19 399 msleep(1);
41a5e1cf Christophe Ricard 2016-05-19 400 if (!priv->irq_tested)
41a5e1cf Christophe Ricard 2016-05-19 401 disable_interrupts(chip);
41a5e1cf Christophe Ricard 2016-05-19 402 priv->irq_tested = true;
41a5e1cf Christophe Ricard 2016-05-19 403 return rc;
41a5e1cf Christophe Ricard 2016-05-19 404 }
41a5e1cf Christophe Ricard 2016-05-19 405
a7da7fe7 Ed Swierk 2016-07-13 406 static void tpm_tis_update_timeouts(struct tpm_chip *chip)
41a5e1cf Christophe Ricard 2016-05-19 407 {
41a5e1cf Christophe Ricard 2016-05-19 408 struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
a7da7fe7 Ed Swierk 2016-07-13 409 int rc;
41a5e1cf Christophe Ricard 2016-05-19 410 u32 did_vid;
41a5e1cf Christophe Ricard 2016-05-19 411
41a5e1cf Christophe Ricard 2016-05-19 412 rc = tpm_tis_read32(priv, TPM_DID_VID(0), &did_vid);
41a5e1cf Christophe Ricard 2016-05-19 413 if (rc < 0)
41a5e1cf Christophe Ricard 2016-05-19 @414 return rc;
41a5e1cf Christophe Ricard 2016-05-19 415
a7da7fe7 Ed Swierk 2016-07-13 416 switch (did_vid) {
a7da7fe7 Ed Swierk 2016-07-13 417 case 0x32041114: /* Atmel 3204 */
a7da7fe7 Ed Swierk 2016-07-13 418 chip->timeout_a = msecs_to_jiffies(TIS_SHORT_TIMEOUT);
a7da7fe7 Ed Swierk 2016-07-13 419 chip->timeout_b = msecs_to_jiffies(TIS_LONG_TIMEOUT);
a7da7fe7 Ed Swierk 2016-07-13 420 chip->timeout_c = msecs_to_jiffies(TIS_SHORT_TIMEOUT);
a7da7fe7 Ed Swierk 2016-07-13 421 chip->timeout_d = msecs_to_jiffies(TIS_SHORT_TIMEOUT);
a7da7fe7 Ed Swierk 2016-07-13 422 chip->timeout_adjusted = true;
:::::: The code at line 414 was first introduced by commit
:::::: 41a5e1cf1fe151ed48b4b3106c748d03a85133ce tpm/tpm_tis: Split tpm_tis driver into a core and TCG TIS compliant phy
:::::: TO: Christophe Ricard <christophe.ricard@gmail.com>
:::::: CC: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 22818 bytes --]
next prev parent reply other threads:[~2016-07-13 17:07 UTC|newest]
Thread overview: 121+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 0:45 [PATCH v4 0/4] tpm: Command duration logging and chip-specific override Ed Swierk
2016-06-08 0:45 ` Ed Swierk
2016-06-08 0:45 ` [PATCH v4 1/4] tpm_tis: Improve reporting of IO errors Ed Swierk
2016-06-08 0:45 ` Ed Swierk
2016-06-08 0:45 ` [PATCH v4 2/4] tpm: Add optional logging of TPM command durations Ed Swierk
2016-06-08 0:45 ` Ed Swierk
2016-06-08 0:45 ` [PATCH v4 3/4] tpm: Allow TPM chip drivers to override reported " Ed Swierk
2016-06-08 0:45 ` Ed Swierk
2016-06-08 19:05 ` [tpmdd-devel] " Jason Gunthorpe
2016-06-08 19:05 ` Jason Gunthorpe
2016-06-08 20:41 ` [tpmdd-devel] " Ed Swierk
2016-06-08 0:45 ` [PATCH v4 4/4] tpm_tis: Increase ST19NP18 TPM command duration to avoid chip lockup Ed Swierk
2016-06-08 0:45 ` Ed Swierk
2016-06-08 23:00 ` [PATCH v5 0/4] tpm: Command duration logging and chip-specific override Ed Swierk
2016-06-08 23:00 ` Ed Swierk
2016-06-08 23:00 ` [PATCH v5 1/4] tpm_tis: Improve reporting of IO errors Ed Swierk
2016-06-08 23:00 ` Ed Swierk
2016-06-08 23:00 ` [PATCH v5 2/4] tpm: Add optional logging of TPM command durations Ed Swierk
2016-06-08 23:00 ` Ed Swierk
2016-06-08 23:00 ` [PATCH v5 3/4] tpm: Allow TPM chip drivers to override reported " Ed Swierk
2016-06-08 23:00 ` Ed Swierk
2016-06-10 12:19 ` Jarkko Sakkinen
2016-06-10 17:34 ` Ed Swierk
2016-06-10 19:42 ` Jarkko Sakkinen
2016-06-10 19:42 ` Jarkko Sakkinen
2016-06-11 1:54 ` Ed Swierk
2016-06-11 1:54 ` Ed Swierk
2016-06-08 23:00 ` [PATCH v5 4/4] tpm_tis: Increase ST19NP18 TPM command duration to avoid chip lockup Ed Swierk
2016-06-08 23:00 ` Ed Swierk
2016-06-11 1:55 ` [PATCH v6 0/5] tpm: Command duration logging and chip-specific override Ed Swierk
2016-06-11 1:55 ` Ed Swierk
2016-06-11 1:55 ` [PATCH v6 1/5] tpm_tis: Improve reporting of IO errors Ed Swierk
2016-06-11 1:55 ` Ed Swierk
2016-06-11 1:55 ` [PATCH v6 2/5] tpm: Add optional logging of TPM command durations Ed Swierk
2016-06-11 1:55 ` Ed Swierk
2016-06-11 1:55 ` [PATCH v6 3/5] tpm: Factor out reading of timeout and duration capabilities Ed Swierk
2016-06-11 1:55 ` Ed Swierk
2016-06-16 20:20 ` Jarkko Sakkinen
2016-06-16 20:20 ` Jarkko Sakkinen
2016-06-19 12:12 ` Jarkko Sakkinen
2016-06-19 12:12 ` Jarkko Sakkinen
[not found] ` <20160619120157.GA29626-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-06-21 1:46 ` Ed Swierk
2016-06-11 1:55 ` [PATCH v6 4/5] tpm: Allow TPM chip drivers to override reported command durations Ed Swierk
2016-06-11 1:55 ` Ed Swierk
2016-06-16 20:26 ` Jarkko Sakkinen
2016-06-11 1:55 ` [PATCH v6 5/5] tpm_tis: Increase ST19NP18 TPM command duration to avoid chip lockup Ed Swierk
2016-06-11 1:55 ` Ed Swierk
2016-06-21 1:53 ` [PATCH v7 0/5] tpm: Command duration logging and chip-specific override Ed Swierk
2016-06-21 1:53 ` Ed Swierk
2016-06-21 1:53 ` [PATCH v7 1/5] tpm_tis: Improve reporting of IO errors Ed Swierk
2016-06-21 1:53 ` Ed Swierk
2016-06-21 1:53 ` [PATCH v7 2/5] tpm: Add optional logging of TPM command durations Ed Swierk
2016-06-21 1:53 ` Ed Swierk
2016-06-21 1:54 ` [PATCH v7 3/5] tpm: Clean up reading of timeout and duration capabilities Ed Swierk
2016-06-21 1:54 ` Ed Swierk
2016-06-21 20:52 ` Jarkko Sakkinen
2016-06-21 20:52 ` Jarkko Sakkinen
2016-06-22 0:21 ` Ed Swierk
2016-06-22 0:21 ` Ed Swierk
2016-06-22 10:46 ` Jarkko Sakkinen
2016-06-22 10:46 ` Jarkko Sakkinen
2016-06-21 1:54 ` [PATCH v7 4/5] tpm: Allow TPM chip drivers to override reported command durations Ed Swierk
2016-06-21 1:54 ` Ed Swierk
2016-06-21 20:54 ` Jarkko Sakkinen
2016-06-21 20:54 ` Jarkko Sakkinen
2016-06-21 1:54 ` [PATCH v7 5/5] tpm_tis: Increase ST19NP18 TPM command duration to avoid chip lockup Ed Swierk
2016-06-21 1:54 ` Ed Swierk
2016-06-21 20:55 ` Jarkko Sakkinen
2016-06-21 20:55 ` Jarkko Sakkinen
2016-06-22 1:10 ` [PATCH v8 0/5] tpm: Command duration logging and chip-specific override Ed Swierk
2016-06-22 1:10 ` Ed Swierk
2016-06-22 1:10 ` [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors Ed Swierk
2016-06-22 1:10 ` Ed Swierk
2016-06-24 18:25 ` Jason Gunthorpe
2016-06-24 18:25 ` Jason Gunthorpe
2016-06-24 20:21 ` Jarkko Sakkinen
2016-06-24 20:23 ` Jarkko Sakkinen
2016-06-24 20:26 ` Jason Gunthorpe
2016-06-24 20:26 ` Jason Gunthorpe
2016-06-25 15:24 ` Jarkko Sakkinen
2016-06-25 15:24 ` Jarkko Sakkinen
2016-06-25 15:47 ` Jarkko Sakkinen
2016-06-25 15:47 ` Jarkko Sakkinen
2016-06-27 17:55 ` Jason Gunthorpe
2016-06-27 17:55 ` Jason Gunthorpe
2016-06-22 1:10 ` [PATCH v8 2/5] tpm: Add optional logging of TPM command durations Ed Swierk
2016-06-22 1:10 ` Ed Swierk
2016-06-24 18:27 ` Jason Gunthorpe
2016-06-24 18:27 ` Jason Gunthorpe
2016-06-24 20:24 ` Jarkko Sakkinen
2016-06-24 20:24 ` Jarkko Sakkinen
2016-06-22 1:10 ` [PATCH v8 3/5] tpm: Clean up reading of timeout and duration capabilities Ed Swierk
2016-06-22 1:10 ` Ed Swierk
2016-06-22 1:10 ` [PATCH v8 4/5] tpm: Allow TPM chip drivers to override reported command durations Ed Swierk
2016-06-22 1:10 ` Ed Swierk
2016-06-22 1:10 ` [PATCH v8 5/5] tpm_tis: Increase ST19NP18 TPM command duration to avoid chip lockup Ed Swierk
2016-06-22 1:10 ` Ed Swierk
2016-07-13 16:19 ` [PATCH v9 0/5] tpm: Command duration logging and chip-specific override Ed Swierk
2016-07-13 16:19 ` [PATCH v9 1/5] tpm_tis: Improve reporting of IO errors Ed Swierk
2016-07-13 16:19 ` [PATCH v9 2/5] tpm: Add optional logging of TPM command durations Ed Swierk
2016-07-13 16:19 ` [PATCH v9 3/5] tpm: Clean up reading of timeout and duration capabilities Ed Swierk
2016-07-18 18:15 ` Jarkko Sakkinen
2016-07-18 18:19 ` Jarkko Sakkinen
2016-07-18 18:19 ` Jarkko Sakkinen
2016-07-18 18:20 ` Jarkko Sakkinen
2016-07-18 18:20 ` Jarkko Sakkinen
2016-07-13 16:19 ` [PATCH v9 4/5] tpm: Allow TPM chip drivers to override reported command durations Ed Swierk
2016-07-13 17:04 ` kbuild test robot [this message]
2016-07-13 17:04 ` kbuild test robot
2016-07-18 18:40 ` Jarkko Sakkinen
2016-07-18 18:40 ` Jarkko Sakkinen
2016-07-13 16:19 ` [PATCH v9 5/5] tpm_tis: Increase ST19NP18 TPM command duration to avoid chip lockup Ed Swierk
2016-07-13 16:44 ` [PATCH v9 0/5] tpm: Command duration logging and chip-specific override Ed Swierk
2016-07-13 17:36 ` Jason Gunthorpe
2016-07-13 17:36 ` Jason Gunthorpe
2016-07-13 20:00 ` Ed Swierk
2016-07-13 20:00 ` Ed Swierk
2016-07-13 20:58 ` Eric W. Biederman
2016-07-13 20:59 ` Jason Gunthorpe
2016-07-18 18:07 ` Jarkko Sakkinen
2016-07-18 18:07 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201607140110.TFmeezcv%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=eswierk@skyportsystems.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=stefanb@us.ibm.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.