* [v2 0/2] i2c: brcmstb: Add support for BMIPS_GENERIC
@ 2016-07-15 3:45 Jaedon Shin
2016-07-15 3:45 ` [v2 1/2] i2c: brcmstb: Make the driver buildable on BMIPS_GENERIC Jaedon Shin
2016-07-15 3:45 ` [v2 2/2] i2c: brcmstb: Remove superfluous size check Jaedon Shin
0 siblings, 2 replies; 5+ messages in thread
From: Jaedon Shin @ 2016-07-15 3:45 UTC (permalink / raw)
To: Wolfram Sang
Cc: Kamal Dasu, Brian Norris, Gregory Fong, Florian Fainelli,
linux-i2c, Jaedon Shin
Hi all,
This patch series adds support for Broadcom BCM7xxx MIPS based SoCs, and a fix.
Changes in v2:
* Rebase on lastest driver
* Remove already applied patches
Jaedon Shin (2):
i2c: brcmstb: Make the driver buildable on BMIPS_GENERIC
i2c: brcmstb: Remove superfluous size check
drivers/i2c/busses/Kconfig | 2 +-
drivers/i2c/busses/i2c-brcmstb.c | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
--
2.9.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [v2 1/2] i2c: brcmstb: Make the driver buildable on BMIPS_GENERIC
2016-07-15 3:45 [v2 0/2] i2c: brcmstb: Add support for BMIPS_GENERIC Jaedon Shin
@ 2016-07-15 3:45 ` Jaedon Shin
2016-07-15 6:02 ` Wolfram Sang
2016-07-15 3:45 ` [v2 2/2] i2c: brcmstb: Remove superfluous size check Jaedon Shin
1 sibling, 1 reply; 5+ messages in thread
From: Jaedon Shin @ 2016-07-15 3:45 UTC (permalink / raw)
To: Wolfram Sang
Cc: Kamal Dasu, Brian Norris, Gregory Fong, Florian Fainelli,
linux-i2c, Jaedon Shin
The BCM7xxx ARM and MIPS based SoCs share a similar I2C hardware block.
Signed-off-by: Jaedon Shin <jaedon.shin@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/i2c/busses/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index f167021b8c21..1fdb0c8b0697 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -397,7 +397,7 @@ config I2C_BCM_KONA
config I2C_BRCMSTB
tristate "BRCM Settop I2C controller"
- depends on ARCH_BRCMSTB || COMPILE_TEST
+ depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
default y
help
If you say yes to this option, support will be included for the
--
2.9.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [v2 2/2] i2c: brcmstb: Remove superfluous size check
2016-07-15 3:45 [v2 0/2] i2c: brcmstb: Add support for BMIPS_GENERIC Jaedon Shin
2016-07-15 3:45 ` [v2 1/2] i2c: brcmstb: Make the driver buildable on BMIPS_GENERIC Jaedon Shin
@ 2016-07-15 3:45 ` Jaedon Shin
2016-07-15 6:03 ` Wolfram Sang
1 sibling, 1 reply; 5+ messages in thread
From: Jaedon Shin @ 2016-07-15 3:45 UTC (permalink / raw)
To: Wolfram Sang
Cc: Kamal Dasu, Brian Norris, Gregory Fong, Florian Fainelli,
linux-i2c, Jaedon Shin
The driver transfer to a message with NOACK always in any size.
If client (eg. EDID segment point message) needs NOACK condition, it can
use I2C_M_IGNORE_NAK flag.
Signed-off-by: Jaedon Shin <jaedon.shin@gmail.com>
---
drivers/i2c/busses/i2c-brcmstb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-brcmstb.c b/drivers/i2c/busses/i2c-brcmstb.c
index 6a8cfc1344b2..3f5a4d71d3bf 100644
--- a/drivers/i2c/busses/i2c-brcmstb.c
+++ b/drivers/i2c/busses/i2c-brcmstb.c
@@ -343,10 +343,9 @@ static int brcmstb_i2c_xfer_bsc_data(struct brcmstb_i2c_dev *dev,
struct bsc_regs *pi2creg = dev->bsc_regmap;
int no_ack = pmsg->flags & I2C_M_IGNORE_NAK;
int data_regsz = brcmstb_i2c_get_data_regsz(dev);
- int xfersz = brcmstb_i2c_get_xfersz(dev);
/* see if the transaction needs to check NACK conditions */
- if (no_ack || len <= xfersz) {
+ if (no_ack) {
cmd = (pmsg->flags & I2C_M_RD) ? CMD_RD_NOACK
: CMD_WR_NOACK;
pi2creg->ctlhi_reg |= BSC_CTLHI_REG_IGNORE_ACK_MASK;
--
2.9.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [v2 1/2] i2c: brcmstb: Make the driver buildable on BMIPS_GENERIC
2016-07-15 3:45 ` [v2 1/2] i2c: brcmstb: Make the driver buildable on BMIPS_GENERIC Jaedon Shin
@ 2016-07-15 6:02 ` Wolfram Sang
0 siblings, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2016-07-15 6:02 UTC (permalink / raw)
To: Jaedon Shin
Cc: Kamal Dasu, Brian Norris, Gregory Fong, Florian Fainelli, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 282 bytes --]
On Fri, Jul 15, 2016 at 12:45:08PM +0900, Jaedon Shin wrote:
> The BCM7xxx ARM and MIPS based SoCs share a similar I2C hardware block.
>
> Signed-off-by: Jaedon Shin <jaedon.shin@gmail.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [v2 2/2] i2c: brcmstb: Remove superfluous size check
2016-07-15 3:45 ` [v2 2/2] i2c: brcmstb: Remove superfluous size check Jaedon Shin
@ 2016-07-15 6:03 ` Wolfram Sang
0 siblings, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2016-07-15 6:03 UTC (permalink / raw)
To: Jaedon Shin
Cc: Kamal Dasu, Brian Norris, Gregory Fong, Florian Fainelli, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 327 bytes --]
On Fri, Jul 15, 2016 at 12:45:09PM +0900, Jaedon Shin wrote:
> The driver transfer to a message with NOACK always in any size.
> If client (eg. EDID segment point message) needs NOACK condition, it can
> use I2C_M_IGNORE_NAK flag.
>
> Signed-off-by: Jaedon Shin <jaedon.shin@gmail.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-07-15 6:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-15 3:45 [v2 0/2] i2c: brcmstb: Add support for BMIPS_GENERIC Jaedon Shin
2016-07-15 3:45 ` [v2 1/2] i2c: brcmstb: Make the driver buildable on BMIPS_GENERIC Jaedon Shin
2016-07-15 6:02 ` Wolfram Sang
2016-07-15 3:45 ` [v2 2/2] i2c: brcmstb: Remove superfluous size check Jaedon Shin
2016-07-15 6:03 ` Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.