From: Jiri Olsa <jolsa@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
x86@kernel.org, Ingo Molnar <mingo@kernel.org>,
Frank Ramsay <framsay@redhat.com>,
Prarit Bhargava <prarit@redhat.com>
Subject: Re: [PATCH] x86/smp: Fix __max_logical_packages value setup
Date: Fri, 12 Aug 2016 15:12:31 +0200 [thread overview]
Message-ID: <20160812131231.GA15943@krava> (raw)
In-Reply-To: <20160812122457.GC8062@krava>
On Fri, Aug 12, 2016 at 02:24:57PM +0200, Jiri Olsa wrote:
> On Thu, Aug 11, 2016 at 03:46:51PM +0200, Peter Zijlstra wrote:
> > On Thu, Aug 11, 2016 at 03:05:21PM +0200, Jiri Olsa wrote:
> > > hum, so we either need some acpi solution to get number of all
> > > sockets or
> >
> > This.. So the problem here is that the BIOS completely screws us over.
> >
> > It wrecks the ACPI-ID table with that option to limit the number of CPUs
> > exposed to the OS (note that it didn't need to do that, it could have
> > enumerated them as empty, instead of not there at all) while keeping the
> > CPUID of the CPUs as reporting they have many (12? was it) cores.
> >
> > This results in inconsistent state, and we're left with nothing useful.
> >
> > > fix the uncore code to initialize pmu boxes on cpu hotplug as well
> >
> > Can't.. it uses the boxes at STARTING time, and we can't do allocs
> > there. Not can we alloc earlier, because we don't know max_packages is
> > going to increase.
>
> I still need to test this, but would this be something
> like you proposed on irc?
works on my test machine:
[ 0.742505] smpboot: APIC(0) Converting physical 0 to logical package 0
[ 0.749902] smpboot: APIC(20) Converting physical 1 to logical package 1
[ 0.757390] smpboot: APIC(40) Converting physical 2 to logical package 2
[ 0.764879] smpboot: APIC(60) Converting physical 3 to logical package 3
[ 0.772368] smpboot: Detected more packages (4), then computed by BIOS data (1).
[ 0.780630] smpboot: Max logical packages: 4
jirka
next prev parent reply other threads:[~2016-08-12 13:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 16:23 [RFC][PATCH] x86/smp: Fix __max_logical_packages value setup Jiri Olsa
2016-08-10 11:41 ` Jiri Olsa
2016-08-10 13:54 ` Peter Zijlstra
2016-08-10 14:00 ` Jiri Olsa
2016-08-10 14:15 ` Jiri Olsa
2016-08-10 15:52 ` Peter Zijlstra
2016-08-10 16:14 ` [PATCH] " Jiri Olsa
2016-08-11 12:48 ` Peter Zijlstra
2016-08-11 13:05 ` Jiri Olsa
2016-08-11 13:46 ` Peter Zijlstra
2016-08-12 12:24 ` Jiri Olsa
2016-08-12 13:12 ` Jiri Olsa [this message]
2016-08-15 9:04 ` Peter Zijlstra
2016-08-15 10:17 ` Jiri Olsa
2016-08-15 11:46 ` Prarit Bhargava
2016-08-18 10:50 ` [tip:x86/urgent] " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160812131231.GA15943@krava \
--to=jolsa@redhat.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=framsay@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=prarit@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.