All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bhelgaas@google.com>
To: Jesper Nilsson <jesper.nilsson@axis.com>,
	Niklas Cassel <niklas.cassel@axis.com>
Cc: linux-pci@vger.kernel.org, linux-arm-kernel@axis.com
Subject: [PATCH 7/8] PCI: artpec6: Add local struct device pointers
Date: Fri, 07 Oct 2016 11:33:24 -0500	[thread overview]
Message-ID: <20161007163324.24751.68214.stgit@bhelgaas-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <20161007163233.24751.17505.stgit@bhelgaas-glaptop2.roam.corp.google.com>

Use a local "struct device *dev" for brevity and consistency with other
drivers.  No functional change intended.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/pci/host/pcie-artpec6.c |   18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/drivers/pci/host/pcie-artpec6.c b/drivers/pci/host/pcie-artpec6.c
index c3dd571..e3f828f 100644
--- a/drivers/pci/host/pcie-artpec6.c
+++ b/drivers/pci/host/pcie-artpec6.c
@@ -197,21 +197,22 @@ static int artpec6_add_pcie_port(struct artpec6_pcie *artpec6,
 				 struct platform_device *pdev)
 {
 	struct pcie_port *pp = &artpec6->pp;
+	struct device *dev = pp->dev;
 	int ret;
 
 	if (IS_ENABLED(CONFIG_PCI_MSI)) {
 		pp->msi_irq = platform_get_irq_byname(pdev, "msi");
 		if (pp->msi_irq <= 0) {
-			dev_err(&pdev->dev, "failed to get MSI irq\n");
+			dev_err(dev, "failed to get MSI irq\n");
 			return -ENODEV;
 		}
 
-		ret = devm_request_irq(&pdev->dev, pp->msi_irq,
+		ret = devm_request_irq(dev, pp->msi_irq,
 				       artpec6_pcie_msi_handler,
 				       IRQF_SHARED | IRQF_NO_THREAD,
 				       "artpec6-pcie-msi", artpec6);
 		if (ret) {
-			dev_err(&pdev->dev, "failed to request MSI irq\n");
+			dev_err(dev, "failed to request MSI irq\n");
 			return ret;
 		}
 	}
@@ -221,7 +222,7 @@ static int artpec6_add_pcie_port(struct artpec6_pcie *artpec6,
 
 	ret = dw_pcie_host_init(pp);
 	if (ret) {
-		dev_err(&pdev->dev, "failed to initialize host\n");
+		dev_err(dev, "failed to initialize host\n");
 		return ret;
 	}
 
@@ -230,26 +231,27 @@ static int artpec6_add_pcie_port(struct artpec6_pcie *artpec6,
 
 static int artpec6_pcie_probe(struct platform_device *pdev)
 {
+	struct device *dev = &pdev->dev;
 	struct artpec6_pcie *artpec6;
 	struct pcie_port *pp;
 	struct resource *dbi_base;
 	struct resource *phy_base;
 	int ret;
 
-	artpec6 = devm_kzalloc(&pdev->dev, sizeof(*artpec6), GFP_KERNEL);
+	artpec6 = devm_kzalloc(dev, sizeof(*artpec6), GFP_KERNEL);
 	if (!artpec6)
 		return -ENOMEM;
 
 	pp = &artpec6->pp;
-	pp->dev = &pdev->dev;
+	pp->dev = dev;
 
 	dbi_base = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dbi");
-	pp->dbi_base = devm_ioremap_resource(&pdev->dev, dbi_base);
+	pp->dbi_base = devm_ioremap_resource(dev, dbi_base);
 	if (IS_ERR(pp->dbi_base))
 		return PTR_ERR(pp->dbi_base);
 
 	phy_base = platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy");
-	artpec6->phy_base = devm_ioremap_resource(&pdev->dev, phy_base);
+	artpec6->phy_base = devm_ioremap_resource(dev, phy_base);
 	if (IS_ERR(artpec6->phy_base))
 		return PTR_ERR(artpec6->phy_base);
 


  parent reply	other threads:[~2016-10-07 16:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-07 16:32 [PATCH 1/8] PCI: artpec6: Name private struct pointer "artpec6" consistently Bjorn Helgaas
2016-10-07 16:32 ` [PATCH 2/8] PCI: artpec6: Add register accessors Bjorn Helgaas
2016-10-08  7:41   ` Jesper Nilsson
2016-10-07 16:32 ` [PATCH 3/8] PCI: artpec6: Pass device-specific struct to internal functions Bjorn Helgaas
2016-10-08  7:41   ` Jesper Nilsson
2016-10-07 16:33 ` [PATCH 4/8] PCI: artpec6: Add resource name comments Bjorn Helgaas
2016-10-08  7:42   ` Jesper Nilsson
2016-10-07 16:33 ` [PATCH 5/8] PCI: artpec6: Remove unnecessary artpec6_pcie_link_up() Bjorn Helgaas
2016-10-08  7:53   ` Jesper Nilsson
2016-10-07 16:33 ` [PATCH 6/8] PCI: artpec6: Use dw_pcie_readl_rc() and dw_pcie_pcie_writel_rc() Bjorn Helgaas
2016-10-08  7:53   ` Jesper Nilsson
2016-10-07 16:33 ` Bjorn Helgaas [this message]
2016-10-08  7:54   ` [PATCH 7/8] PCI: artpec6: Add local struct device pointers Jesper Nilsson
2016-10-07 16:33 ` [PATCH 8/8] PCI: artpec6: Remove unused platform data Bjorn Helgaas
2016-10-08  8:13   ` Jesper Nilsson
2016-10-08  7:40 ` [PATCH 1/8] PCI: artpec6: Name private struct pointer "artpec6" consistently Jesper Nilsson
2016-10-10 17:28   ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161007163324.24751.68214.stgit@bhelgaas-glaptop2.roam.corp.google.com \
    --to=bhelgaas@google.com \
    --cc=jesper.nilsson@axis.com \
    --cc=linux-arm-kernel@axis.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=niklas.cassel@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.