All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Lee Jones <lee.jones@linaro.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Sebastian Reichel <sre@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Daniel Mack <daniel@zonque.org>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	patches@opensource.wolfsonmicro.com, linux-pm@vger.kernel.org,
	alsa-devel@alsa-project.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 8/9] mfd: wm97xx-core: core support for wm97xx Codec
Date: Tue, 6 Dec 2016 11:13:53 +0000	[thread overview]
Message-ID: <20161206111353.fq5445yuzsy7li4i@sirena.org.uk> (raw)
In-Reply-To: <87y406ppjl.fsf@belgarion.home>

[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]

On Sat, Nov 26, 2016 at 10:18:38AM +0100, Robert Jarzmik wrote:

> >> >> +#define WM9705_VENDOR_ID 0x574d4c05
> >> >> +#define WM9712_VENDOR_ID 0x574d4c12
> >> >> +#define WM9713_VENDOR_ID 0x574d4c13
> >> >> +#define WM97xx_VENDOR_ID_MASK 0xffffffff

> >> > These are probably better represented as enums.
> >> These are ids, just as devicetree ids, or PCI ids, I don't think an enum will
> >> fit.

> > That's fine.  We can use enums to simply group items of a similar
> > type.  Representing these as enums would only serve to benefit code
> > cleanliness.  What makes you think they won't fit?

That would be like having all PCI or USB identifiers in an enum, it's
doable but it means having one big table that all drivers need to
modify.

> >> >> +static int wm97xx_ac97_probe(struct ac97_codec_device *adev)

> >> As for the "sound specific part", it's because AC97 bus is mainly used in sound
> >> oriented drivers, but still the codec IPs provide more than just sound, as the
> >> Wolfson codecs for instance.

> > I'd like to get Mark Brown's opinion on this.

I'm not sure what the question is, sorry.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/9] mfd: wm97xx-core: core support for wm97xx Codec
Date: Tue, 6 Dec 2016 11:13:53 +0000	[thread overview]
Message-ID: <20161206111353.fq5445yuzsy7li4i@sirena.org.uk> (raw)
In-Reply-To: <87y406ppjl.fsf@belgarion.home>

On Sat, Nov 26, 2016 at 10:18:38AM +0100, Robert Jarzmik wrote:

> >> >> +#define WM9705_VENDOR_ID 0x574d4c05
> >> >> +#define WM9712_VENDOR_ID 0x574d4c12
> >> >> +#define WM9713_VENDOR_ID 0x574d4c13
> >> >> +#define WM97xx_VENDOR_ID_MASK 0xffffffff

> >> > These are probably better represented as enums.
> >> These are ids, just as devicetree ids, or PCI ids, I don't think an enum will
> >> fit.

> > That's fine.  We can use enums to simply group items of a similar
> > type.  Representing these as enums would only serve to benefit code
> > cleanliness.  What makes you think they won't fit?

That would be like having all PCI or USB identifiers in an enum, it's
doable but it means having one big table that all drivers need to
modify.

> >> >> +static int wm97xx_ac97_probe(struct ac97_codec_device *adev)

> >> As for the "sound specific part", it's because AC97 bus is mainly used in sound
> >> oriented drivers, but still the codec IPs provide more than just sound, as the
> >> Wolfson codecs for instance.

> > I'd like to get Mark Brown's opinion on this.

I'm not sure what the question is, sorry.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161206/bb87a688/attachment.sig>

  reply	other threads:[~2016-12-06 11:15 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-26 19:41 [PATCH 0/9] AC97 device/driver model revamp Robert Jarzmik
2016-10-26 19:41 ` Robert Jarzmik
2016-10-26 19:41 ` [PATCH 1/9] ALSA: ac97: split out the generic ac97 registers Robert Jarzmik
2016-10-26 19:41   ` Robert Jarzmik
2016-10-26 19:41 ` [PATCH 2/9] ALSA: ac97: add an ac97 bus Robert Jarzmik
2016-10-26 19:41   ` Robert Jarzmik
2016-11-08 13:37   ` [alsa-devel] " Lars-Peter Clausen
2016-11-08 13:37     ` Lars-Peter Clausen
2016-11-08 21:18     ` Robert Jarzmik
2016-11-08 21:18       ` Robert Jarzmik
2016-11-08 21:18       ` Robert Jarzmik
2016-11-09 13:11       ` Lars-Peter Clausen
2016-11-09 13:11         ` Lars-Peter Clausen
2016-11-09 21:27         ` Robert Jarzmik
2016-11-09 21:27           ` Robert Jarzmik
2016-11-10 11:38           ` Lars-Peter Clausen
2016-11-10 11:38             ` Lars-Peter Clausen
2016-11-22 18:08             ` Mark Brown
2016-11-22 18:08               ` Mark Brown
2016-11-25 19:58             ` Robert Jarzmik
2016-11-25 19:58               ` Robert Jarzmik
2016-10-26 19:41 ` [PATCH 3/9] ASoC: add new ac97 bus support Robert Jarzmik
2016-10-26 19:41   ` Robert Jarzmik
2016-10-26 19:41 ` [PATCH 4/9] ASoC: wm9713: add ac97 new " Robert Jarzmik
2016-10-26 19:41   ` Robert Jarzmik
2016-10-27  8:39   ` Charles Keepax
2016-10-27  8:39     ` Charles Keepax
2016-10-27  8:39     ` Charles Keepax
2016-10-26 19:41 ` [PATCH 5/9] ASoC: pxa: switch to new ac97 " Robert Jarzmik
2016-10-26 19:41   ` Robert Jarzmik
2016-10-31  8:37   ` Robert Jarzmik
2016-10-31  8:37     ` Robert Jarzmik
2016-11-01 19:55     ` Robert Jarzmik
2016-11-01 19:55       ` Robert Jarzmik
2016-10-26 19:41 ` [PATCH 6/9] power_supply: wm97xx_battery: use power_supply_get_drvdata Robert Jarzmik
2016-10-26 19:41   ` Robert Jarzmik
2016-10-27  8:41   ` Charles Keepax
2016-10-27  8:41     ` Charles Keepax
2016-11-23 23:13   ` Sebastian Reichel
2016-11-23 23:13     ` Sebastian Reichel
2016-11-25 19:54     ` Robert Jarzmik
2016-11-25 19:54       ` Robert Jarzmik
2017-01-23 18:38   ` Kevin Hilman
2017-01-23 18:38     ` Kevin Hilman
2017-01-24  7:31     ` Robert Jarzmik
2017-01-24  7:31       ` Robert Jarzmik
2017-01-24 20:40       ` Dmitry Torokhov
2017-01-24 20:40         ` Dmitry Torokhov
2017-01-24 23:39         ` Kevin Hilman
2017-01-24 23:39           ` Kevin Hilman
2016-10-26 19:41 ` [PATCH 7/9] Input: wm97xx: split out touchscreen registering Robert Jarzmik
2016-10-26 19:41   ` Robert Jarzmik
2016-10-26 19:41   ` Robert Jarzmik
2016-10-27  9:02   ` Charles Keepax
2016-10-27  9:02     ` Charles Keepax
2016-10-27  9:02     ` Charles Keepax
2016-10-27 19:27     ` Robert Jarzmik
2016-10-27 19:27       ` Robert Jarzmik
2016-10-27 19:27       ` Robert Jarzmik
2016-10-26 19:41 ` [PATCH 8/9] mfd: wm97xx-core: core support for wm97xx Codec Robert Jarzmik
2016-10-26 19:41   ` Robert Jarzmik
2016-10-27  9:11   ` Charles Keepax
2016-10-27  9:11     ` Charles Keepax
2016-10-27  9:11     ` Charles Keepax
2016-11-18 16:50   ` Lee Jones
2016-11-18 16:50     ` Lee Jones
2016-11-19 11:39     ` Robert Jarzmik
2016-11-19 11:39       ` Robert Jarzmik
2016-11-21 10:12       ` Lee Jones
2016-11-21 10:12         ` Lee Jones
2016-11-26  9:18         ` Robert Jarzmik
2016-11-26  9:18           ` Robert Jarzmik
2016-12-06 11:13           ` Mark Brown [this message]
2016-12-06 11:13             ` Mark Brown
2017-02-03  8:37             ` Robert Jarzmik
2017-02-03  8:37               ` Robert Jarzmik
2016-10-26 19:41 ` [PATCH 9/9] Input: wm97xx: add new AC97 bus support Robert Jarzmik
2016-10-26 19:41   ` Robert Jarzmik
2016-10-27  9:13   ` Charles Keepax
2016-10-27  9:13     ` Charles Keepax
2016-10-27  9:13     ` Charles Keepax
2017-09-19 16:11   ` Applied "Input: wm97xx: add new AC97 bus support" to the asoc tree Mark Brown
2017-09-19 16:11     ` Mark Brown
2017-09-19 16:11     ` Mark Brown
2016-11-22 18:13 ` [PATCH 0/9] AC97 device/driver model revamp Mark Brown
2016-11-22 18:13   ` Mark Brown
2016-11-22 18:13   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161206111353.fq5445yuzsy7li4i@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=daniel@zonque.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=haojian.zhuang@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=perex@perex.cz \
    --cc=robert.jarzmik@free.fr \
    --cc=sre@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.