From: Michal Hocko <mhocko@kernel.org> To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> Cc: Peter Zijlstra <peterz@infradead.org>, Rik van Riel <riel@redhat.com>, Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] mm: drop zap_details::ignore_dirty Date: Mon, 19 Dec 2016 15:22:16 +0100 [thread overview] Message-ID: <20161219142216.GH5164@dhcp22.suse.cz> (raw) In-Reply-To: <20161216141556.75130-1-kirill.shutemov@linux.intel.com> On Fri 16-12-16 17:15:53, Kirill A. Shutemov wrote: > The only user of ignore_dirty is oom-reaper. But it doesn't really use > it. > > ignore_dirty only has effect on file pages mapped with dirty pte. > But oom-repear skips shared VMAs, so there's no way we can dirty file > pte in them. Hmm, I am trying to rememeber why I've done that and it seems I was just too paranoid and wanted to make sure that we never touch dirty mapped pages. As you say this is not possible with the current implementation so the patch should be OK. > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Acked-by: Michal Hocko <mhocko@suse.com> > --- > include/linux/mm.h | 1 - > mm/memory.c | 6 ------ > mm/oom_kill.c | 3 +-- > 3 files changed, 1 insertion(+), 9 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 4424784ac374..7b8e425ac41c 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1148,7 +1148,6 @@ struct zap_details { > struct address_space *check_mapping; /* Check page->mapping if set */ > pgoff_t first_index; /* Lowest page->index to unmap */ > pgoff_t last_index; /* Highest page->index to unmap */ > - bool ignore_dirty; /* Ignore dirty pages */ > bool check_swap_entries; /* Check also swap entries */ > }; > > diff --git a/mm/memory.c b/mm/memory.c > index 455c3e628d52..6ac8fa56080f 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -1155,12 +1155,6 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb, > > if (!PageAnon(page)) { > if (pte_dirty(ptent)) { > - /* > - * oom_reaper cannot tear down dirty > - * pages > - */ > - if (unlikely(details && details->ignore_dirty)) > - continue; > force_flush = 1; > set_page_dirty(page); > } > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index ec9f11d4f094..f101db68e760 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -465,8 +465,7 @@ static bool __oom_reap_task_mm(struct task_struct *tsk, struct mm_struct *mm) > { > struct mmu_gather tlb; > struct vm_area_struct *vma; > - struct zap_details details = {.check_swap_entries = true, > - .ignore_dirty = true}; > + struct zap_details details = {.check_swap_entries = true}; > bool ret = true; > > /* > -- > 2.10.2 > -- Michal Hocko SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org> To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> Cc: Peter Zijlstra <peterz@infradead.org>, Rik van Riel <riel@redhat.com>, Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] mm: drop zap_details::ignore_dirty Date: Mon, 19 Dec 2016 15:22:16 +0100 [thread overview] Message-ID: <20161219142216.GH5164@dhcp22.suse.cz> (raw) In-Reply-To: <20161216141556.75130-1-kirill.shutemov@linux.intel.com> On Fri 16-12-16 17:15:53, Kirill A. Shutemov wrote: > The only user of ignore_dirty is oom-reaper. But it doesn't really use > it. > > ignore_dirty only has effect on file pages mapped with dirty pte. > But oom-repear skips shared VMAs, so there's no way we can dirty file > pte in them. Hmm, I am trying to rememeber why I've done that and it seems I was just too paranoid and wanted to make sure that we never touch dirty mapped pages. As you say this is not possible with the current implementation so the patch should be OK. > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Acked-by: Michal Hocko <mhocko@suse.com> > --- > include/linux/mm.h | 1 - > mm/memory.c | 6 ------ > mm/oom_kill.c | 3 +-- > 3 files changed, 1 insertion(+), 9 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 4424784ac374..7b8e425ac41c 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1148,7 +1148,6 @@ struct zap_details { > struct address_space *check_mapping; /* Check page->mapping if set */ > pgoff_t first_index; /* Lowest page->index to unmap */ > pgoff_t last_index; /* Highest page->index to unmap */ > - bool ignore_dirty; /* Ignore dirty pages */ > bool check_swap_entries; /* Check also swap entries */ > }; > > diff --git a/mm/memory.c b/mm/memory.c > index 455c3e628d52..6ac8fa56080f 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -1155,12 +1155,6 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb, > > if (!PageAnon(page)) { > if (pte_dirty(ptent)) { > - /* > - * oom_reaper cannot tear down dirty > - * pages > - */ > - if (unlikely(details && details->ignore_dirty)) > - continue; > force_flush = 1; > set_page_dirty(page); > } > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index ec9f11d4f094..f101db68e760 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -465,8 +465,7 @@ static bool __oom_reap_task_mm(struct task_struct *tsk, struct mm_struct *mm) > { > struct mmu_gather tlb; > struct vm_area_struct *vma; > - struct zap_details details = {.check_swap_entries = true, > - .ignore_dirty = true}; > + struct zap_details details = {.check_swap_entries = true}; > bool ret = true; > > /* > -- > 2.10.2 > -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-12-19 14:22 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-12-16 14:15 [PATCH 1/4] mm: drop zap_details::ignore_dirty Kirill A. Shutemov 2016-12-16 14:15 ` Kirill A. Shutemov 2016-12-16 14:15 ` [PATCH 2/4] mm: drop zap_details::check_swap_entries Kirill A. Shutemov 2016-12-16 14:15 ` Kirill A. Shutemov 2016-12-19 14:29 ` Michal Hocko 2016-12-19 14:29 ` Michal Hocko 2016-12-16 14:15 ` [PATCH 3/4] mm: drop unused argument of zap_page_range() Kirill A. Shutemov 2016-12-16 14:15 ` Kirill A. Shutemov 2016-12-16 17:02 ` kbuild test robot 2016-12-16 17:02 ` kbuild test robot 2016-12-19 14:35 ` Michal Hocko 2016-12-19 14:35 ` Michal Hocko 2016-12-16 14:15 ` [PATCH 4/4] oom-reaper: use madvise_dontneed() instead of unmap_page_range() Kirill A. Shutemov 2016-12-16 14:15 ` Kirill A. Shutemov 2016-12-16 16:10 ` kbuild test robot 2016-12-16 16:10 ` kbuild test robot 2016-12-16 16:45 ` kbuild test robot 2016-12-16 16:45 ` kbuild test robot 2016-12-19 11:39 ` Tetsuo Handa 2016-12-19 11:39 ` Tetsuo Handa 2016-12-19 14:00 ` Michal Hocko 2016-12-19 14:00 ` Michal Hocko 2016-12-19 14:38 ` Michal Hocko 2016-12-19 14:38 ` Michal Hocko 2016-12-19 14:22 ` Michal Hocko [this message] 2016-12-19 14:22 ` [PATCH 1/4] mm: drop zap_details::ignore_dirty Michal Hocko 2016-12-19 17:17 Kirill A. Shutemov 2016-12-19 17:17 ` Kirill A. Shutemov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20161219142216.GH5164@dhcp22.suse.cz \ --to=mhocko@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=kirill.shutemov@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=peterz@infradead.org \ --cc=riel@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.