From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: James Simmons <jsimmons@infradead.org> Cc: Joe Perches <joe@perches.com>, devel@driverdev.osuosl.org, James Simmons <uja.ornl@yahoo.com>, Andreas Dilger <andreas.dilger@intel.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Oleg Drokin <oleg.drokin@intel.com>, Lustre Development List <lustre-devel@lists.lustre.org> Subject: Re: [PATCH 0/8] staging: lustre: lnet: change wire protocol typedefs to proper structure Date: Mon, 30 Jan 2017 07:40:19 +0100 [thread overview] Message-ID: <20170130064018.GA4108@kroah.com> (raw) In-Reply-To: <alpine.LFD.2.20.1701292354160.7496@casper.infradead.org> On Sun, Jan 29, 2017 at 11:56:38PM +0000, James Simmons wrote: > > > On Sat, 2017-01-21 at 19:40 -0500, James Simmons wrote: > > > The upstream kernel requires proper structures so > > > convert nearly all the LNet wire protocols typedefs in > > > the LNet core. > > > > Thanks. > > > > Perhaps s/\bWIRE_ATTR\b/__packed/g one day too > > I liked to keep that one. Sorry, but no. > The point of WIRE_ATTR isn't to be some abstraction but to label that > struct as something that goes over the wire. This lets people know > that it would break something if you change that structure. Looks like > I need to send a patch that adds a comment explaning the meaning of > WIRE_ATTR. No, please remove it, it's not anything that any other kernel subsystem uses. It's easy to know if you will break something, anything that crosses the user/kernel boundry falls into that category, so if it is in a uapi .h file, that's going to be the case. thanks, greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: James Simmons <jsimmons@infradead.org> Cc: Joe Perches <joe@perches.com>, devel@driverdev.osuosl.org, James Simmons <uja.ornl@yahoo.com>, Andreas Dilger <andreas.dilger@intel.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Oleg Drokin <oleg.drokin@intel.com>, Lustre Development List <lustre-devel@lists.lustre.org> Subject: [lustre-devel] [PATCH 0/8] staging: lustre: lnet: change wire protocol typedefs to proper structure Date: Mon, 30 Jan 2017 07:40:19 +0100 [thread overview] Message-ID: <20170130064018.GA4108@kroah.com> (raw) In-Reply-To: <alpine.LFD.2.20.1701292354160.7496@casper.infradead.org> On Sun, Jan 29, 2017 at 11:56:38PM +0000, James Simmons wrote: > > > On Sat, 2017-01-21 at 19:40 -0500, James Simmons wrote: > > > The upstream kernel requires proper structures so > > > convert nearly all the LNet wire protocols typedefs in > > > the LNet core. > > > > Thanks. > > > > Perhaps s/\bWIRE_ATTR\b/__packed/g one day too > > I liked to keep that one. Sorry, but no. > The point of WIRE_ATTR isn't to be some abstraction but to label that > struct as something that goes over the wire. This lets people know > that it would break something if you change that structure. Looks like > I need to send a patch that adds a comment explaning the meaning of > WIRE_ATTR. No, please remove it, it's not anything that any other kernel subsystem uses. It's easy to know if you will break something, anything that crosses the user/kernel boundry falls into that category, so if it is in a uapi .h file, that's going to be the case. thanks, greg k-h
next prev parent reply other threads:[~2017-01-30 6:40 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-22 0:40 [PATCH 0/8] staging: lustre: lnet: change wire protocol typedefs to proper structure James Simmons 2017-01-22 0:40 ` [lustre-devel] " James Simmons 2017-01-22 0:40 ` [PATCH 1/8] staging: lustre: lnet: change lnet_handle_wire_t " James Simmons 2017-01-22 0:40 ` [lustre-devel] " James Simmons 2017-01-22 0:40 ` [PATCH 2/8] staging: lustre: lnet: change lnet_ping_info_t " James Simmons 2017-01-22 0:40 ` [lustre-devel] " James Simmons 2017-01-22 0:40 ` [PATCH 3/8] staging: lustre: lnet: change lnet_ni_status_t " James Simmons 2017-01-22 0:40 ` [lustre-devel] " James Simmons 2017-01-22 0:40 ` [PATCH 4/8] staging: lustre: lnet: change lnet_process_id_packed_t " James Simmons 2017-01-22 0:40 ` [lustre-devel] " James Simmons 2017-01-22 0:40 ` [PATCH 5/8] staging: lustre: lnet: change lnet_acceptor_connreq_t " James Simmons 2017-01-22 0:40 ` [lustre-devel] " James Simmons 2017-01-22 0:40 ` [PATCH 6/8] staging: lustre: lnet: change lnet_magicversion_t " James Simmons 2017-01-22 0:40 ` [lustre-devel] " James Simmons 2017-01-22 0:40 ` [PATCH 7/8] staging: lustre: lnet: change lnet_hdr_t " James Simmons 2017-01-22 0:40 ` [lustre-devel] " James Simmons 2017-01-22 0:40 ` [PATCH 8/8] staging: lustre: lnet: change msg union in struct lnet_hdr " James Simmons 2017-01-22 0:40 ` [lustre-devel] " James Simmons 2017-01-23 21:01 ` [PATCH 0/8] staging: lustre: lnet: change wire protocol typedefs " Joe Perches 2017-01-23 21:01 ` [lustre-devel] " Joe Perches 2017-01-29 23:56 ` James Simmons 2017-01-29 23:56 ` [lustre-devel] " James Simmons 2017-01-30 6:40 ` Greg Kroah-Hartman [this message] 2017-01-30 6:40 ` Greg Kroah-Hartman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170130064018.GA4108@kroah.com \ --to=gregkh@linuxfoundation.org \ --cc=andreas.dilger@intel.com \ --cc=devel@driverdev.osuosl.org \ --cc=joe@perches.com \ --cc=jsimmons@infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lustre-devel@lists.lustre.org \ --cc=oleg.drokin@intel.com \ --cc=uja.ornl@yahoo.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.