* [PATCH] Input: zet6223 - Export OF device ID as module aliases
@ 2017-02-20 20:08 Javier Martinez Canillas
2017-02-20 23:28 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2017-02-20 20:08 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Jelle van der Waa, Rob Herring,
Dmitry Torokhov, linux-input
The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
device was registered via OF, this means that exporting the OF device ID
table device aliases in the module is not needed. But in order to change
how the core reports modaliases to user-space, it's better to export it.
Before this patch:
$ modinfo drivers/input/touchscreen/zet6223.ko | grep alias
alias: i2c:zet6223
After this patch:
$ modinfo drivers/input/touchscreen/zet6223.ko | grep alias
alias: of:N*T*Czeitec,zet6223C*
alias: of:N*T*Czeitec,zet6223
alias: i2c:zet6223
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/input/touchscreen/zet6223.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/zet6223.c b/drivers/input/touchscreen/zet6223.c
index e7fb00b511ec..19ffcc7b886c 100644
--- a/drivers/input/touchscreen/zet6223.c
+++ b/drivers/input/touchscreen/zet6223.c
@@ -245,6 +245,7 @@ static const struct of_device_id zet6223_of_match[] = {
{ .compatible = "zeitec,zet6223" },
{ }
};
+MODULE_DEVICE_TABLE(of, zet6223_of_match);
static const struct i2c_device_id zet6223_id[] = {
{ "zet6223", 0},
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: zet6223 - Export OF device ID as module aliases
2017-02-20 20:08 [PATCH] Input: zet6223 - Export OF device ID as module aliases Javier Martinez Canillas
@ 2017-02-20 23:28 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2017-02-20 23:28 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel, Jelle van der Waa, Rob Herring, linux-input
On Mon, Feb 20, 2017 at 05:08:55PM -0300, Javier Martinez Canillas wrote:
> The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
> device was registered via OF, this means that exporting the OF device ID
> table device aliases in the module is not needed. But in order to change
> how the core reports modaliases to user-space, it's better to export it.
>
> Before this patch:
>
> $ modinfo drivers/input/touchscreen/zet6223.ko | grep alias
> alias: i2c:zet6223
>
> After this patch:
>
> $ modinfo drivers/input/touchscreen/zet6223.ko | grep alias
> alias: of:N*T*Czeitec,zet6223C*
> alias: of:N*T*Czeitec,zet6223
> alias: i2c:zet6223
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied, thank you.
> ---
>
> drivers/input/touchscreen/zet6223.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/zet6223.c b/drivers/input/touchscreen/zet6223.c
> index e7fb00b511ec..19ffcc7b886c 100644
> --- a/drivers/input/touchscreen/zet6223.c
> +++ b/drivers/input/touchscreen/zet6223.c
> @@ -245,6 +245,7 @@ static const struct of_device_id zet6223_of_match[] = {
> { .compatible = "zeitec,zet6223" },
> { }
> };
> +MODULE_DEVICE_TABLE(of, zet6223_of_match);
>
> static const struct i2c_device_id zet6223_id[] = {
> { "zet6223", 0},
> --
> 2.9.3
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-20 23:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-20 20:08 [PATCH] Input: zet6223 - Export OF device ID as module aliases Javier Martinez Canillas
2017-02-20 23:28 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.