From: Michal Hocko <mhocko@kernel.org> To: Shaohua Li <shli@fb.com> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kernel-team@fb.com, minchan@kernel.org, hughd@google.com, hannes@cmpxchg.org, riel@redhat.com, mgorman@techsingularity.net, akpm@linux-foundation.org Subject: Re: [PATCH V5 5/6] mm: enable MADV_FREE for swapless system Date: Mon, 27 Feb 2017 16:06:24 +0100 [thread overview] Message-ID: <20170227150623.GH26504@dhcp22.suse.cz> (raw) In-Reply-To: <155648585589300bfae1d45078e7aebb3d988b87.1487965799.git.shli@fb.com> On Fri 24-02-17 13:31:48, Shaohua Li wrote: > Now MADV_FREE pages can be easily reclaimed even for swapless system. We > can safely enable MADV_FREE for all systems. > > Cc: Michal Hocko <mhocko@suse.com> > Cc: Minchan Kim <minchan@kernel.org> > Cc: Hugh Dickins <hughd@google.com> > Cc: Rik van Riel <riel@redhat.com> > Cc: Mel Gorman <mgorman@techsingularity.net> > Cc: Andrew Morton <akpm@linux-foundation.org> > Acked-by: Johannes Weiner <hannes@cmpxchg.org> > Signed-off-by: Shaohua Li <shli@fb.com> Acked-by: Michal Hocko <mhocko@suse.com> > --- > mm/madvise.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index 225af7d..5ab4b7b 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -612,13 +612,7 @@ madvise_vma(struct vm_area_struct *vma, struct vm_area_struct **prev, > case MADV_WILLNEED: > return madvise_willneed(vma, prev, start, end); > case MADV_FREE: > - /* > - * XXX: In this implementation, MADV_FREE works like > - * MADV_DONTNEED on swapless system or full swap. > - */ > - if (get_nr_swap_pages() > 0) > - return madvise_free(vma, prev, start, end); > - /* passthrough */ > + return madvise_free(vma, prev, start, end); > case MADV_DONTNEED: > return madvise_dontneed(vma, prev, start, end); > default: > -- > 2.9.3 > -- Michal Hocko SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org> To: Shaohua Li <shli@fb.com> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kernel-team@fb.com, minchan@kernel.org, hughd@google.com, hannes@cmpxchg.org, riel@redhat.com, mgorman@techsingularity.net, akpm@linux-foundation.org Subject: Re: [PATCH V5 5/6] mm: enable MADV_FREE for swapless system Date: Mon, 27 Feb 2017 16:06:24 +0100 [thread overview] Message-ID: <20170227150623.GH26504@dhcp22.suse.cz> (raw) In-Reply-To: <155648585589300bfae1d45078e7aebb3d988b87.1487965799.git.shli@fb.com> On Fri 24-02-17 13:31:48, Shaohua Li wrote: > Now MADV_FREE pages can be easily reclaimed even for swapless system. We > can safely enable MADV_FREE for all systems. > > Cc: Michal Hocko <mhocko@suse.com> > Cc: Minchan Kim <minchan@kernel.org> > Cc: Hugh Dickins <hughd@google.com> > Cc: Rik van Riel <riel@redhat.com> > Cc: Mel Gorman <mgorman@techsingularity.net> > Cc: Andrew Morton <akpm@linux-foundation.org> > Acked-by: Johannes Weiner <hannes@cmpxchg.org> > Signed-off-by: Shaohua Li <shli@fb.com> Acked-by: Michal Hocko <mhocko@suse.com> > --- > mm/madvise.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index 225af7d..5ab4b7b 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -612,13 +612,7 @@ madvise_vma(struct vm_area_struct *vma, struct vm_area_struct **prev, > case MADV_WILLNEED: > return madvise_willneed(vma, prev, start, end); > case MADV_FREE: > - /* > - * XXX: In this implementation, MADV_FREE works like > - * MADV_DONTNEED on swapless system or full swap. > - */ > - if (get_nr_swap_pages() > 0) > - return madvise_free(vma, prev, start, end); > - /* passthrough */ > + return madvise_free(vma, prev, start, end); > case MADV_DONTNEED: > return madvise_dontneed(vma, prev, start, end); > default: > -- > 2.9.3 > -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-02-27 15:24 UTC|newest] Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-24 21:31 [PATCH V5 0/6] mm: fix some MADV_FREE issues Shaohua Li 2017-02-24 21:31 ` Shaohua Li 2017-02-24 21:31 ` [PATCH V5 1/6] mm: delete unnecessary TTU_* flags Shaohua Li 2017-02-24 21:31 ` Shaohua Li 2017-02-27 13:48 ` Michal Hocko 2017-02-27 13:48 ` Michal Hocko 2017-02-24 21:31 ` [PATCH V5 2/6] mm: don't assume anonymous pages have SwapBacked flag Shaohua Li 2017-02-24 21:31 ` Shaohua Li 2017-02-27 6:48 ` Hillf Danton 2017-02-27 6:48 ` Hillf Danton 2017-02-27 14:35 ` Michal Hocko 2017-02-27 14:35 ` Michal Hocko 2017-02-27 16:10 ` Shaohua Li 2017-02-27 16:10 ` Shaohua Li 2017-02-27 16:28 ` Michal Hocko 2017-02-27 16:28 ` Michal Hocko 2017-02-24 21:31 ` [PATCH V5 3/6] mm: move MADV_FREE pages into LRU_INACTIVE_FILE list Shaohua Li 2017-02-24 21:31 ` Shaohua Li 2017-02-27 6:28 ` Minchan Kim 2017-02-27 6:28 ` Minchan Kim 2017-02-27 16:13 ` Shaohua Li 2017-02-27 16:13 ` Shaohua Li 2017-02-27 16:30 ` Michal Hocko 2017-02-27 16:30 ` Michal Hocko 2017-02-28 2:53 ` Minchan Kim 2017-02-28 2:53 ` Minchan Kim 2017-02-27 14:53 ` Michal Hocko 2017-02-27 14:53 ` Michal Hocko 2017-02-27 17:15 ` Johannes Weiner 2017-02-27 17:15 ` Johannes Weiner 2017-02-28 3:19 ` Hillf Danton 2017-02-28 3:19 ` Hillf Danton 2017-02-24 21:31 ` [PATCH V5 4/6] mm: reclaim MADV_FREE pages Shaohua Li 2017-02-24 21:31 ` Shaohua Li 2017-02-27 6:33 ` Minchan Kim 2017-02-27 6:33 ` Minchan Kim 2017-02-27 16:19 ` Shaohua Li 2017-02-27 16:19 ` Shaohua Li 2017-02-27 16:32 ` Michal Hocko 2017-02-27 16:32 ` Michal Hocko 2017-02-28 5:02 ` Minchan Kim 2017-02-28 5:02 ` Minchan Kim 2017-02-27 15:05 ` Michal Hocko 2017-02-27 15:05 ` Michal Hocko 2017-02-27 17:21 ` Johannes Weiner 2017-02-27 17:21 ` Johannes Weiner 2017-02-28 3:21 ` Hillf Danton 2017-02-28 3:21 ` Hillf Danton 2017-02-24 21:31 ` [PATCH V5 5/6] mm: enable MADV_FREE for swapless system Shaohua Li 2017-02-24 21:31 ` Shaohua Li 2017-02-27 15:06 ` Michal Hocko [this message] 2017-02-27 15:06 ` Michal Hocko 2017-02-28 3:22 ` Hillf Danton 2017-02-28 3:22 ` Hillf Danton 2017-02-28 5:02 ` Minchan Kim 2017-02-28 5:02 ` Minchan Kim 2017-02-24 21:31 ` [PATCH V5 6/6] proc: show MADV_FREE pages info in smaps Shaohua Li 2017-02-24 21:31 ` Shaohua Li 2017-02-27 15:06 ` Michal Hocko 2017-02-27 15:06 ` Michal Hocko 2017-02-28 3:23 ` Hillf Danton 2017-02-28 3:23 ` Hillf Danton 2017-03-01 13:36 ` Michal Hocko 2017-03-01 13:36 ` Michal Hocko 2017-03-01 17:37 ` Shaohua Li 2017-03-01 17:37 ` Shaohua Li 2017-03-01 17:49 ` Michal Hocko 2017-03-01 17:49 ` Michal Hocko 2017-03-01 18:18 ` Shaohua Li 2017-03-01 18:18 ` Shaohua Li 2017-03-01 18:31 ` Johannes Weiner 2017-03-01 18:31 ` Johannes Weiner 2017-03-01 18:57 ` Michal Hocko 2017-03-01 18:57 ` Michal Hocko 2017-03-02 7:39 ` Minchan Kim 2017-03-02 7:39 ` Minchan Kim 2017-03-02 14:01 ` Johannes Weiner 2017-03-02 14:01 ` Johannes Weiner 2017-03-02 16:30 ` Michal Hocko 2017-03-02 16:30 ` Michal Hocko 2017-03-04 0:10 ` Andrew Morton 2017-03-04 0:10 ` Andrew Morton 2017-03-07 10:05 ` Michal Hocko 2017-03-07 10:05 ` Michal Hocko 2017-03-07 22:43 ` Andrew Morton 2017-03-07 22:43 ` Andrew Morton 2017-03-08 5:36 ` Minchan Kim 2017-03-08 5:36 ` Minchan Kim
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170227150623.GH26504@dhcp22.suse.cz \ --to=mhocko@kernel.org \ --cc=Kernel-team@fb.com \ --cc=akpm@linux-foundation.org \ --cc=hannes@cmpxchg.org \ --cc=hughd@google.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@techsingularity.net \ --cc=minchan@kernel.org \ --cc=riel@redhat.com \ --cc=shli@fb.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.