All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Marco Franchi <marco.franchi@nxp.com>
Cc: linux@roeck-us.net, devicetree@vger.kernel.org,
	linux-hwmon@vger.kernel.org, marcofrk@gmail.com,
	FoxPeter@kabelbw.de
Subject: Re: [PATCH v4 2/2] hwmon: (sht15) Add device tree support
Date: Mon, 27 Feb 2017 09:57:52 -0600	[thread overview]
Message-ID: <20170227155752.b6yshpowa4ioty6a@rob-hp-laptop> (raw)
In-Reply-To: <1487247824-10005-1-git-send-email-marco.franchi@nxp.com>

On Thu, Feb 16, 2017 at 10:23:43AM -0200, Marco Franchi wrote:
> Allow the driver to work with device tree support.
> 
> Based on initial patch submission from Peter Fox.
> 
> Tested on a imx7d-sdb board connected to a SHT15 board via Mikro Bus.
> 
> Signed-off-by: Marco Franchi <marco.franchi@nxp.com>
> ---
> Changes since v3:
> -Remove the optional properties because they are not hardware description
> -Change the sensor node name
> 
>  Documentation/devicetree/bindings/hwmon/sht15.txt | 19 +++++++
>  drivers/hwmon/sht15.c                             | 64 +++++++++++++++++++++--
>  2 files changed, 79 insertions(+), 4 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/sht15.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/sht15.txt b/Documentation/devicetree/bindings/hwmon/sht15.txt
> new file mode 100644
> index 0000000..6a80277
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/sht15.txt
> @@ -0,0 +1,19 @@
> +Sensirion SHT15 Humidity and Temperature Sensor
> +
> +Required properties:
> +
> + - "compatible": must be "sensirion,sht15".
> + - "data-gpios": GPIO connected to the data line.
> + - "clk-gpios": GPIO connected to the clock line.

Looks like this device is I2C perhaps? Though I'm not sure the waveforms 
before and after transactions are compliant.

> + - "vcc-supply": regulator that drives the VCC pin.
> +
> +Example:
> +
> +	sensor {
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_sensor>;
> +		compatible = "sensirion,sht15";
> +		clk-gpios = <&gpio4 12 0>;
> +		data-gpios = <&gpio4 13 0>;
> +		vcc-supply = <&reg_sht15>;
> +	};

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Marco Franchi <marco.franchi-3arQi8VN3Tc@public.gmane.org>
Cc: linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-hwmon-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	marcofrk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	FoxPeter-5t/GDYzpMLSELgA04lAiVw@public.gmane.org
Subject: Re: [PATCH v4 2/2] hwmon: (sht15) Add device tree support
Date: Mon, 27 Feb 2017 09:57:52 -0600	[thread overview]
Message-ID: <20170227155752.b6yshpowa4ioty6a@rob-hp-laptop> (raw)
In-Reply-To: <1487247824-10005-1-git-send-email-marco.franchi-3arQi8VN3Tc@public.gmane.org>

On Thu, Feb 16, 2017 at 10:23:43AM -0200, Marco Franchi wrote:
> Allow the driver to work with device tree support.
> 
> Based on initial patch submission from Peter Fox.
> 
> Tested on a imx7d-sdb board connected to a SHT15 board via Mikro Bus.
> 
> Signed-off-by: Marco Franchi <marco.franchi-3arQi8VN3Tc@public.gmane.org>
> ---
> Changes since v3:
> -Remove the optional properties because they are not hardware description
> -Change the sensor node name
> 
>  Documentation/devicetree/bindings/hwmon/sht15.txt | 19 +++++++
>  drivers/hwmon/sht15.c                             | 64 +++++++++++++++++++++--
>  2 files changed, 79 insertions(+), 4 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/sht15.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/sht15.txt b/Documentation/devicetree/bindings/hwmon/sht15.txt
> new file mode 100644
> index 0000000..6a80277
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/sht15.txt
> @@ -0,0 +1,19 @@
> +Sensirion SHT15 Humidity and Temperature Sensor
> +
> +Required properties:
> +
> + - "compatible": must be "sensirion,sht15".
> + - "data-gpios": GPIO connected to the data line.
> + - "clk-gpios": GPIO connected to the clock line.

Looks like this device is I2C perhaps? Though I'm not sure the waveforms 
before and after transactions are compliant.

> + - "vcc-supply": regulator that drives the VCC pin.
> +
> +Example:
> +
> +	sensor {
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_sensor>;
> +		compatible = "sensirion,sht15";
> +		clk-gpios = <&gpio4 12 0>;
> +		data-gpios = <&gpio4 13 0>;
> +		vcc-supply = <&reg_sht15>;
> +	};
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-02-27 15:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-16 12:23 [PATCH v4 2/2] hwmon: (sht15) Add device tree support Marco Franchi
2017-02-16 12:23 ` Marco Franchi
2017-02-16 12:23 ` [PATCH v4 1/2] dt: Add vendor prefix for Sensirion Marco Franchi
2017-02-16 12:23   ` Marco Franchi
2017-02-16 14:43   ` Guenter Roeck
2017-02-16 14:43     ` Guenter Roeck
2017-02-27 15:58     ` Rob Herring
2017-02-27 17:32       ` Rob Herring
2017-02-16 12:53 ` [PATCH v4 2/2] hwmon: (sht15) Add device tree support Fabio Estevam
2017-02-16 12:53   ` Fabio Estevam
2017-02-16 14:48 ` Guenter Roeck
2017-02-27 15:57 ` Rob Herring [this message]
2017-02-27 15:57   ` Rob Herring
2017-02-27 16:46   ` Fabio Estevam
2017-02-27 16:46     ` Fabio Estevam
2017-02-27 17:31     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170227155752.b6yshpowa4ioty6a@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=FoxPeter@kabelbw.de \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=marco.franchi@nxp.com \
    --cc=marcofrk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.