All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Hogan <james.hogan@imgtec.com>
To: Marcel Apfelbaum <marcel@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>,
	virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] [BUG] virtio-net linux driver fails to probe on MIPS Malta since 'hw/virtio-pci: fix virtio behaviour'
Date: Mon, 27 Mar 2017 19:45:28 +0100	[thread overview]
Message-ID: <20170327184528.GQ31606@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <c92a77f3-7ddc-c0b8-7046-6d8f1c56aec7@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1023 bytes --]

Hi Marcel,

On Tue, Mar 21, 2017 at 04:16:58PM +0200, Marcel Apfelbaum wrote:
> Can you please check if the below patch fixes the problem?
> Please note it is not a solution.
> 
> diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
> index f9b7244..5b4d429 100644
> --- a/hw/virtio/virtio-pci.c
> +++ b/hw/virtio/virtio-pci.c
> @@ -1671,9 +1671,7 @@ static void virtio_pci_device_plugged(DeviceState *d, Error **errp)
>           }
> 
>           pci_register_bar(&proxy->pci_dev, proxy->modern_mem_bar_idx,
> -                         PCI_BASE_ADDRESS_SPACE_MEMORY |
> -                         PCI_BASE_ADDRESS_MEM_PREFETCH |
> -                         PCI_BASE_ADDRESS_MEM_TYPE_64,
> +                         PCI_BASE_ADDRESS_SPACE_MEMORY,
>                            &proxy->modern_bar);
> 
>           proxy->config_cap = virtio_pci_add_mem_cap(proxy, &cfg.cap);

Sorry for the delay trying this, I was away last week.

No, it doesn't seem to make any difference.

Thanks
James

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Marcel Apfelbaum <marcel@redhat.com>
Cc: virtualization@lists.linux-foundation.org, qemu-devel@nongnu.org,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [BUG] virtio-net linux driver fails to probe on MIPS Malta since 'hw/virtio-pci: fix virtio behaviour'
Date: Mon, 27 Mar 2017 19:45:28 +0100	[thread overview]
Message-ID: <20170327184528.GQ31606@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <c92a77f3-7ddc-c0b8-7046-6d8f1c56aec7@redhat.com>


[-- Attachment #1.1: Type: text/plain, Size: 1023 bytes --]

Hi Marcel,

On Tue, Mar 21, 2017 at 04:16:58PM +0200, Marcel Apfelbaum wrote:
> Can you please check if the below patch fixes the problem?
> Please note it is not a solution.
> 
> diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
> index f9b7244..5b4d429 100644
> --- a/hw/virtio/virtio-pci.c
> +++ b/hw/virtio/virtio-pci.c
> @@ -1671,9 +1671,7 @@ static void virtio_pci_device_plugged(DeviceState *d, Error **errp)
>           }
> 
>           pci_register_bar(&proxy->pci_dev, proxy->modern_mem_bar_idx,
> -                         PCI_BASE_ADDRESS_SPACE_MEMORY |
> -                         PCI_BASE_ADDRESS_MEM_PREFETCH |
> -                         PCI_BASE_ADDRESS_MEM_TYPE_64,
> +                         PCI_BASE_ADDRESS_SPACE_MEMORY,
>                            &proxy->modern_bar);
> 
>           proxy->config_cap = virtio_pci_add_mem_cap(proxy, &cfg.cap);

Sorry for the delay trying this, I was away last week.

No, it doesn't seem to make any difference.

Thanks
James

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

[-- Attachment #2: Type: text/plain, Size: 183 bytes --]

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  reply	other threads:[~2017-03-27 18:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-17 21:57 [Qemu-devel] [BUG] virtio-net linux driver fails to probe on MIPS Malta since 'hw/virtio-pci: fix virtio behaviour' James Hogan
2017-03-17 21:57 ` James Hogan
2017-03-20 15:21 ` [Qemu-devel] " Marcel Apfelbaum
2017-03-20 15:21   ` Marcel Apfelbaum
2017-03-20 15:43   ` [Qemu-devel] " Michael S. Tsirkin
2017-03-20 15:43     ` Michael S. Tsirkin
2017-03-20 16:02     ` [Qemu-devel] " Marcel Apfelbaum
2017-03-20 16:02       ` Marcel Apfelbaum
2017-03-21 14:16     ` [Qemu-devel] " Marcel Apfelbaum
2017-03-21 14:16       ` Marcel Apfelbaum
2017-03-27 18:45       ` James Hogan [this message]
2017-03-27 18:45         ` James Hogan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170327184528.GQ31606@jhogan-linux.le.imgtec.org \
    --to=james.hogan@imgtec.com \
    --cc=jasowang@redhat.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.