From: Simon Wunderlich <sw@simonwunderlich.de> To: davem@davemloft.net Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org, Sven Eckelmann <sven@narfation.org>, Simon Wunderlich <sw@simonwunderlich.de> Subject: [PATCH 06/19] batman-adv: Use __func__ to add function names to messages Date: Thu, 6 Apr 2017 16:07:28 +0200 [thread overview] Message-ID: <20170406140741.30745-7-sw@simonwunderlich.de> (raw) In-Reply-To: <20170406140741.30745-1-sw@simonwunderlich.de> From: Sven Eckelmann <sven@narfation.org> The name of the function might change in which these messages are printed. It is therefore better to let the compiler handle the insertion of the correct function name. Signed-off-by: Sven Eckelmann <sven@narfation.org> Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de> --- net/batman-adv/tp_meter.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/batman-adv/tp_meter.c b/net/batman-adv/tp_meter.c index c94ebdecdc3d..556f9a865ddf 100644 --- a/net/batman-adv/tp_meter.c +++ b/net/batman-adv/tp_meter.c @@ -873,8 +873,8 @@ static int batadv_tp_send(void *arg) /* something went wrong during the preparation/transmission */ if (unlikely(err && err != BATADV_TP_REASON_CANT_SEND)) { batadv_dbg(BATADV_DBG_TP_METER, bat_priv, - "Meter: batadv_tp_send() cannot send packets (%d)\n", - err); + "Meter: %s() cannot send packets (%d)\n", + __func__, err); /* ensure nobody else tries to stop the thread now */ if (atomic_dec_and_test(&tp_vars->sending)) tp_vars->reason = err; @@ -979,7 +979,8 @@ void batadv_tp_start(struct batadv_priv *bat_priv, const u8 *dst, if (!tp_vars) { spin_unlock_bh(&bat_priv->tp_list_lock); batadv_dbg(BATADV_DBG_TP_METER, bat_priv, - "Meter: batadv_tp_start cannot allocate list elements\n"); + "Meter: %s cannot allocate list elements\n", + __func__); batadv_tp_batctl_error_notify(BATADV_TP_REASON_MEMORY_ERROR, dst, bat_priv, session_cookie); return; -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: Simon Wunderlich <sw@simonwunderlich.de> To: davem@davemloft.net Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org Subject: [B.A.T.M.A.N.] [PATCH 06/19] batman-adv: Use __func__ to add function names to messages Date: Thu, 6 Apr 2017 16:07:28 +0200 [thread overview] Message-ID: <20170406140741.30745-7-sw@simonwunderlich.de> (raw) In-Reply-To: <20170406140741.30745-1-sw@simonwunderlich.de> From: Sven Eckelmann <sven@narfation.org> The name of the function might change in which these messages are printed. It is therefore better to let the compiler handle the insertion of the correct function name. Signed-off-by: Sven Eckelmann <sven@narfation.org> Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de> --- net/batman-adv/tp_meter.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/batman-adv/tp_meter.c b/net/batman-adv/tp_meter.c index c94ebdecdc3d..556f9a865ddf 100644 --- a/net/batman-adv/tp_meter.c +++ b/net/batman-adv/tp_meter.c @@ -873,8 +873,8 @@ static int batadv_tp_send(void *arg) /* something went wrong during the preparation/transmission */ if (unlikely(err && err != BATADV_TP_REASON_CANT_SEND)) { batadv_dbg(BATADV_DBG_TP_METER, bat_priv, - "Meter: batadv_tp_send() cannot send packets (%d)\n", - err); + "Meter: %s() cannot send packets (%d)\n", + __func__, err); /* ensure nobody else tries to stop the thread now */ if (atomic_dec_and_test(&tp_vars->sending)) tp_vars->reason = err; @@ -979,7 +979,8 @@ void batadv_tp_start(struct batadv_priv *bat_priv, const u8 *dst, if (!tp_vars) { spin_unlock_bh(&bat_priv->tp_list_lock); batadv_dbg(BATADV_DBG_TP_METER, bat_priv, - "Meter: batadv_tp_start cannot allocate list elements\n"); + "Meter: %s cannot allocate list elements\n", + __func__); batadv_tp_batctl_error_notify(BATADV_TP_REASON_MEMORY_ERROR, dst, bat_priv, session_cookie); return; -- 2.11.0
next prev parent reply other threads:[~2017-04-06 14:07 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-06 14:07 [PATCH 00/19] pull request for net-next: batman-adv 2017-04-06 Simon Wunderlich 2017-04-06 14:07 ` [B.A.T.M.A.N.] " Simon Wunderlich 2017-04-06 14:07 ` [PATCH 01/19] batman-adv: Start new development cycle Simon Wunderlich 2017-04-06 14:07 ` [B.A.T.M.A.N.] " Simon Wunderlich 2017-04-06 14:07 ` [PATCH 02/19] batman-adv: Reduce preprocessor checks in multicast.c Simon Wunderlich 2017-04-06 14:07 ` [B.A.T.M.A.N.] " Simon Wunderlich [not found] ` <20170406140741.30745-1-sw-2YrNx6rUIHYiY0qSoAWiAoQuADTiUCJX@public.gmane.org> 2017-04-06 14:07 ` [PATCH 03/19] batman-adv: Fix unbalanced braces around else statement Simon Wunderlich 2017-04-06 14:07 ` [B.A.T.M.A.N.] " Simon Wunderlich 2017-04-06 14:07 ` [PATCH 04/19] batman-adv: Fix possible side-effects in _batadv_dbg Simon Wunderlich 2017-04-06 14:07 ` [B.A.T.M.A.N.] " Simon Wunderlich 2017-04-06 14:07 ` [PATCH 05/19] batman-adv: Convert BATADV_PRINT_VID macro to function Simon Wunderlich 2017-04-06 14:07 ` [B.A.T.M.A.N.] " Simon Wunderlich 2017-04-06 14:07 ` Simon Wunderlich [this message] 2017-04-06 14:07 ` [B.A.T.M.A.N.] [PATCH 06/19] batman-adv: Use __func__ to add function names to messages Simon Wunderlich 2017-04-06 14:07 ` [PATCH 07/19] batman-adv: Omit unnecessary memset of netdev private data Simon Wunderlich 2017-04-06 14:07 ` [B.A.T.M.A.N.] " Simon Wunderlich 2017-04-06 14:07 ` [PATCH 08/19] batman-adv: prevent multiple ARP replies sent by gateways if dat enabled Simon Wunderlich 2017-04-06 14:07 ` [B.A.T.M.A.N.] " Simon Wunderlich 2017-04-06 14:07 ` [PATCH 09/19] batman-adv: prevent duplication of ARP replies when DAT is used Simon Wunderlich 2017-04-06 14:07 ` [B.A.T.M.A.N.] " Simon Wunderlich 2017-04-06 14:07 ` [PATCH 10/19] batman-adv: drop unicast packets from other backbone gw Simon Wunderlich 2017-04-06 14:07 ` [B.A.T.M.A.N.] " Simon Wunderlich 2017-04-06 14:07 ` [PATCH 11/19] batman-adv: changed debug messages for easier bla debugging Simon Wunderlich 2017-04-06 14:07 ` [B.A.T.M.A.N.] " Simon Wunderlich 2017-04-06 14:07 ` [PATCH 12/19] batman-adv: handle race condition for claims between gateways Simon Wunderlich 2017-04-06 14:07 ` [B.A.T.M.A.N.] " Simon Wunderlich 2017-04-06 14:07 ` [PATCH 13/19] batman-adv: privatize forw_packet skb assignment Simon Wunderlich 2017-04-06 14:07 ` [B.A.T.M.A.N.] " Simon Wunderlich 2017-04-06 14:07 ` [PATCH 14/19] batman-adv: restructure rebroadcast counter into forw_packet API Simon Wunderlich 2017-04-06 14:07 ` [B.A.T.M.A.N.] " Simon Wunderlich 2017-04-06 14:07 ` [PATCH 15/19] batman-adv: Use ethtool helper to get link status Simon Wunderlich 2017-04-06 14:07 ` [B.A.T.M.A.N.] " Simon Wunderlich 2017-04-06 14:07 ` [PATCH 16/19] batman-adv: Remove ethtool msglevel functions Simon Wunderlich 2017-04-06 14:07 ` [B.A.T.M.A.N.] " Simon Wunderlich 2017-04-06 14:07 ` [PATCH 17/19] batman-adv: Remove ethtool .get_settings stub Simon Wunderlich 2017-04-06 14:07 ` [B.A.T.M.A.N.] " Simon Wunderlich 2017-04-06 14:07 ` [PATCH 18/19] batman-adv: Group ethtool related code together Simon Wunderlich 2017-04-06 14:07 ` [B.A.T.M.A.N.] " Simon Wunderlich 2017-04-06 14:07 ` [PATCH 19/19] batman-adv: Use net_device_stats from struct net_device Simon Wunderlich 2017-04-06 14:07 ` [B.A.T.M.A.N.] " Simon Wunderlich 2017-04-06 21:55 ` [PATCH 00/19] pull request for net-next: batman-adv 2017-04-06 David Miller 2017-04-06 21:55 ` [B.A.T.M.A.N.] " David Miller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170406140741.30745-7-sw@simonwunderlich.de \ --to=sw@simonwunderlich.de \ --cc=b.a.t.m.a.n@lists.open-mesh.org \ --cc=davem@davemloft.net \ --cc=netdev@vger.kernel.org \ --cc=sven@narfation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.