From: Robert Richter <rric@kernel.org> To: linucherian@gmail.com Cc: catalin.marinas@arm.com, will.deacon@arm.com, lorenzo.pieralisi@arm.com, hanjun.guo@linaro.org, sudeep.holla@arm.com, rjw@rjwysocki.net, lenb@kernel.org, robin.murphy@arm.com, joro@8bytes.org, robert.moore@intel.com, lv.zheng@intel.com, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org, devel@acpica.org, Sunil.Goutham@cavium.com, Geethasowjanya.Akula@cavium.com, robert.richter@cavium.com, linu.cherian@cavium.com Subject: Re: [RFC PATCH 5/7] iommu/arm-smmu-v3: For ACPI based device probing, set relevant options for different SMMUv3 implementations. Date: Wed, 12 Apr 2017 10:43:36 +0200 [thread overview] Message-ID: <20170412084336.GM4906@rric.localdomain> (raw) In-Reply-To: <1491921765-29475-6-git-send-email-linucherian@gmail.com> Linu, On 11.04.17 20:12:43, linucherian@gmail.com wrote: > From: Linu Cherian <linu.cherian@cavium.com> > > Enable SKIP_PREFETCH option for HiSilicon SMMUv3 model. > Enable PAGE0_REGS_ONLY and USE_SHARED_IRQS options for > Cavium 99xx SMMUv3 model. > > Signed-off-by: Linu Cherian <linu.cherian@cavium.com> > --- > drivers/iommu/arm-smmu-v3.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c > index 1475ad8..00b48b4 100644 > --- a/drivers/iommu/arm-smmu-v3.c > +++ b/drivers/iommu/arm-smmu-v3.c > @@ -2634,18 +2634,45 @@ static int arm_smmu_device_hw_probe(struct arm_smmu_device *smmu) > } > > #ifdef CONFIG_ACPI > +static int acpi_smmu_get_options(u32 model, struct arm_smmu_device *smmu) > +{ > + int ret = 0; > + > + switch (model) { > + case ACPI_IORT_SMMU_V3: > + case ACPI_IORT_SMMU_CORELINK_MMU600: > + break; > + case ACPI_IORT_SMMU_V3_HISILICON: > + smmu->options |= ARM_SMMU_OPT_SKIP_PREFETCH; > + break; > + case ACPI_IORT_SMMU_V3_CAVIUM_CN99XX: > + smmu->options |= (ARM_SMMU_OPT_PAGE0_REGS_ONLY | > + ARM_SMMU_OPT_USE_SHARED_IRQS); > + break; > + default: > + ret = -ENODEV; > + } > + > + return ret; > +} > + > static int arm_smmu_device_acpi_probe(struct platform_device *pdev, > struct arm_smmu_device *smmu) > { > struct acpi_iort_smmu_v3 *iort_smmu; > struct device *dev = smmu->dev; > struct acpi_iort_node *node; > + int ret; > > node = *(struct acpi_iort_node **)dev_get_platdata(dev); > > /* Retrieve SMMUv3 specific data */ > iort_smmu = (struct acpi_iort_smmu_v3 *)node->node_data; > > + ret = acpi_smmu_get_options(iort_smmu->model, smmu); > + if (ret < 0) > + return ret; > + could we add at least: dev_notice(smmu->dev, "option mask 0x%x\n", smmu->options); We need a note to see which options have been enabled. It could be even more fancy and maybe unified with DT code to see the same messages for DT and ACPI. Thanks, -Robert > if (iort_smmu->flags & ACPI_IORT_SMMU_V3_COHACC_OVERRIDE) > smmu->features |= ARM_SMMU_FEAT_COHERENCY; > > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: rric@kernel.org (Robert Richter) To: linux-arm-kernel@lists.infradead.org Subject: [RFC PATCH 5/7] iommu/arm-smmu-v3: For ACPI based device probing, set relevant options for different SMMUv3 implementations. Date: Wed, 12 Apr 2017 10:43:36 +0200 [thread overview] Message-ID: <20170412084336.GM4906@rric.localdomain> (raw) In-Reply-To: <1491921765-29475-6-git-send-email-linucherian@gmail.com> Linu, On 11.04.17 20:12:43, linucherian at gmail.com wrote: > From: Linu Cherian <linu.cherian@cavium.com> > > Enable SKIP_PREFETCH option for HiSilicon SMMUv3 model. > Enable PAGE0_REGS_ONLY and USE_SHARED_IRQS options for > Cavium 99xx SMMUv3 model. > > Signed-off-by: Linu Cherian <linu.cherian@cavium.com> > --- > drivers/iommu/arm-smmu-v3.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c > index 1475ad8..00b48b4 100644 > --- a/drivers/iommu/arm-smmu-v3.c > +++ b/drivers/iommu/arm-smmu-v3.c > @@ -2634,18 +2634,45 @@ static int arm_smmu_device_hw_probe(struct arm_smmu_device *smmu) > } > > #ifdef CONFIG_ACPI > +static int acpi_smmu_get_options(u32 model, struct arm_smmu_device *smmu) > +{ > + int ret = 0; > + > + switch (model) { > + case ACPI_IORT_SMMU_V3: > + case ACPI_IORT_SMMU_CORELINK_MMU600: > + break; > + case ACPI_IORT_SMMU_V3_HISILICON: > + smmu->options |= ARM_SMMU_OPT_SKIP_PREFETCH; > + break; > + case ACPI_IORT_SMMU_V3_CAVIUM_CN99XX: > + smmu->options |= (ARM_SMMU_OPT_PAGE0_REGS_ONLY | > + ARM_SMMU_OPT_USE_SHARED_IRQS); > + break; > + default: > + ret = -ENODEV; > + } > + > + return ret; > +} > + > static int arm_smmu_device_acpi_probe(struct platform_device *pdev, > struct arm_smmu_device *smmu) > { > struct acpi_iort_smmu_v3 *iort_smmu; > struct device *dev = smmu->dev; > struct acpi_iort_node *node; > + int ret; > > node = *(struct acpi_iort_node **)dev_get_platdata(dev); > > /* Retrieve SMMUv3 specific data */ > iort_smmu = (struct acpi_iort_smmu_v3 *)node->node_data; > > + ret = acpi_smmu_get_options(iort_smmu->model, smmu); > + if (ret < 0) > + return ret; > + could we add at least: dev_notice(smmu->dev, "option mask 0x%x\n", smmu->options); We need a note to see which options have been enabled. It could be even more fancy and maybe unified with DT code to see the same messages for DT and ACPI. Thanks, -Robert > if (iort_smmu->flags & ACPI_IORT_SMMU_V3_COHACC_OVERRIDE) > smmu->features |= ARM_SMMU_FEAT_COHERENCY; > > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-04-12 8:43 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-11 14:42 [RFC PATCH 0/7] Cavium CN99xx SMMUv3 Errata workarounds linucherian-Re5JQEeQqe8AvxtiuMwx3w 2017-04-11 14:42 ` linucherian at gmail.com 2017-04-11 14:42 ` [RFC PATCH 1/7] iommu/arm-smmu-v3: Introduce smmu option PAGE0_REGS_ONLY for Silicon errata linucherian 2017-04-11 14:42 ` linucherian at gmail.com 2017-04-11 15:42 ` Robin Murphy 2017-04-11 15:42 ` Robin Murphy 2017-04-12 5:05 ` Linu Cherian 2017-04-12 5:05 ` Linu Cherian 2017-04-11 14:42 ` [RFC PATCH 2/7] iommu/arm-smmu-v3: Do resource size checks based on smmu option PAGE0_REGS_ONLY linucherian 2017-04-11 14:42 ` linucherian at gmail.com 2017-04-11 15:43 ` Robin Murphy 2017-04-11 15:43 ` Robin Murphy 2017-04-11 16:39 ` Sunil Kovvuri 2017-04-11 16:39 ` Sunil Kovvuri 2017-04-11 14:42 ` [RFC PATCH 3/7] iommu/arm-smmu-v3: Introduce smmu option USE_SHARED_IRQS for Silicon errata linucherian 2017-04-11 14:42 ` linucherian at gmail.com 2017-04-11 15:54 ` Robin Murphy 2017-04-11 15:54 ` Robin Murphy 2017-04-11 16:21 ` Will Deacon 2017-04-11 16:21 ` Will Deacon [not found] ` <20170411162123.GF17109-5wv7dgnIgG8@public.gmane.org> 2017-04-11 16:34 ` Sunil Kovvuri 2017-04-11 16:34 ` Sunil Kovvuri 2017-04-11 16:38 ` Robin Murphy 2017-04-11 16:38 ` Robin Murphy [not found] ` <a971af83-10f1-5696-f0c6-0600c04705c3-5wv7dgnIgG8@public.gmane.org> 2017-04-11 16:41 ` Will Deacon 2017-04-11 16:41 ` Will Deacon 2017-04-11 14:42 ` [RFC PATCH 4/7] ACPICA: IORT: Add SMMuV3 model definitions linucherian 2017-04-11 14:42 ` linucherian at gmail.com 2017-04-11 15:59 ` Robin Murphy 2017-04-11 15:59 ` Robin Murphy 2017-04-11 16:57 ` Sunil Kovvuri 2017-04-11 16:57 ` Sunil Kovvuri 2017-04-12 2:33 ` Hanjun Guo 2017-04-12 2:33 ` [Devel] " Hanjun Guo 2017-04-12 2:33 ` Hanjun Guo 2017-04-12 15:21 ` Lorenzo Pieralisi 2017-04-12 15:21 ` Lorenzo Pieralisi 2017-04-11 14:42 ` [RFC PATCH 5/7] iommu/arm-smmu-v3: For ACPI based device probing, set relevant options for different SMMUv3 implementations linucherian 2017-04-11 14:42 ` linucherian at gmail.com 2017-04-12 8:43 ` Robert Richter [this message] 2017-04-12 8:43 ` Robert Richter 2017-04-12 10:32 ` Linu Cherian 2017-04-12 10:32 ` Linu Cherian 2017-04-11 14:42 ` [RFC PATCH 6/7] ACPI/IORT: Fixup SMMUv3 resource size for Cavium 99xx SMMUv3 model linucherian 2017-04-11 14:42 ` linucherian at gmail.com 2017-04-11 14:42 ` [RFC PATCH 7/7] arm64: Documentation: Add Cavium ThunderX2 SMMUv3 erratas linucherian 2017-04-11 14:42 ` linucherian at gmail.com 2017-04-11 16:30 ` [RFC PATCH 0/7] Cavium CN99xx SMMUv3 Errata workarounds Will Deacon 2017-04-11 16:30 ` Will Deacon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170412084336.GM4906@rric.localdomain \ --to=rric@kernel.org \ --cc=Geethasowjanya.Akula@cavium.com \ --cc=Sunil.Goutham@cavium.com \ --cc=catalin.marinas@arm.com \ --cc=devel@acpica.org \ --cc=hanjun.guo@linaro.org \ --cc=iommu@lists.linux-foundation.org \ --cc=joro@8bytes.org \ --cc=lenb@kernel.org \ --cc=linu.cherian@cavium.com \ --cc=linucherian@gmail.com \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=lv.zheng@intel.com \ --cc=rjw@rjwysocki.net \ --cc=robert.moore@intel.com \ --cc=robert.richter@cavium.com \ --cc=robin.murphy@arm.com \ --cc=sudeep.holla@arm.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.