From: Jan Kara <jack@suse.cz> To: Andrey Ryabinin <aryabinin@virtuozzo.com> Cc: Alexander Viro <viro@zeniv.linux.org.uk>, stable@vger.kernel.org, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Ross Zwisler <ross.zwisler@linux.intel.com>, Andrew Morton <akpm@linux-foundation.org>, Jan Kara <jack@suse.cz>, Jens Axboe <axboe@kernel.dk>, Johannes Weiner <hannes@cmpxchg.org>, Alexey Kuznetsov <kuznet@virtuozzo.com>, Christoph Hellwig <hch@lst.de>, Nikolay Borisov <n.borisov.lkml@gmail.com>, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 2/4] fs/block_dev: always invalidate cleancache in invalidate_bdev() Date: Tue, 25 Apr 2017 10:34:46 +0200 [thread overview] Message-ID: <20170425083446.GC2793@quack2.suse.cz> (raw) In-Reply-To: <20170424164135.22350-3-aryabinin@virtuozzo.com> On Mon 24-04-17 19:41:33, Andrey Ryabinin wrote: > invalidate_bdev() calls cleancache_invalidate_inode() iff ->nrpages != 0 > which doen't make any sense. > Make sure that invalidate_bdev() always calls cleancache_invalidate_inode() > regardless of mapping->nrpages value. > > Fixes: c515e1fd361c ("mm/fs: add hooks to support cleancache") > Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com> > Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > Cc: <stable@vger.kernel.org> Looks good. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/block_dev.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/fs/block_dev.c b/fs/block_dev.c > index 065d7c5..f625dce 100644 > --- a/fs/block_dev.c > +++ b/fs/block_dev.c > @@ -104,12 +104,11 @@ void invalidate_bdev(struct block_device *bdev) > { > struct address_space *mapping = bdev->bd_inode->i_mapping; > > - if (mapping->nrpages == 0) > - return; > - > - invalidate_bh_lrus(); > - lru_add_drain_all(); /* make sure all lru add caches are flushed */ > - invalidate_mapping_pages(mapping, 0, -1); > + if (mapping->nrpages) { > + invalidate_bh_lrus(); > + lru_add_drain_all(); /* make sure all lru add caches are flushed */ > + invalidate_mapping_pages(mapping, 0, -1); > + } > /* 99% of the time, we don't need to flush the cleancache on the bdev. > * But, for the strange corners, lets be cautious > */ > -- > 2.10.2 > -- Jan Kara <jack@suse.com> SUSE Labs, CR
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz> To: Andrey Ryabinin <aryabinin@virtuozzo.com> Cc: Alexander Viro <viro@zeniv.linux.org.uk>, stable@vger.kernel.org, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Ross Zwisler <ross.zwisler@linux.intel.com>, Andrew Morton <akpm@linux-foundation.org>, Jan Kara <jack@suse.cz>, Jens Axboe <axboe@kernel.dk>, Johannes Weiner <hannes@cmpxchg.org>, Alexey Kuznetsov <kuznet@virtuozzo.com>, Christoph Hellwig <hch@lst.de>, Nikolay Borisov <n.borisov.lkml@gmail.com>, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 2/4] fs/block_dev: always invalidate cleancache in invalidate_bdev() Date: Tue, 25 Apr 2017 10:34:46 +0200 [thread overview] Message-ID: <20170425083446.GC2793@quack2.suse.cz> (raw) In-Reply-To: <20170424164135.22350-3-aryabinin@virtuozzo.com> On Mon 24-04-17 19:41:33, Andrey Ryabinin wrote: > invalidate_bdev() calls cleancache_invalidate_inode() iff ->nrpages != 0 > which doen't make any sense. > Make sure that invalidate_bdev() always calls cleancache_invalidate_inode() > regardless of mapping->nrpages value. > > Fixes: c515e1fd361c ("mm/fs: add hooks to support cleancache") > Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com> > Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > Cc: <stable@vger.kernel.org> Looks good. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/block_dev.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/fs/block_dev.c b/fs/block_dev.c > index 065d7c5..f625dce 100644 > --- a/fs/block_dev.c > +++ b/fs/block_dev.c > @@ -104,12 +104,11 @@ void invalidate_bdev(struct block_device *bdev) > { > struct address_space *mapping = bdev->bd_inode->i_mapping; > > - if (mapping->nrpages == 0) > - return; > - > - invalidate_bh_lrus(); > - lru_add_drain_all(); /* make sure all lru add caches are flushed */ > - invalidate_mapping_pages(mapping, 0, -1); > + if (mapping->nrpages) { > + invalidate_bh_lrus(); > + lru_add_drain_all(); /* make sure all lru add caches are flushed */ > + invalidate_mapping_pages(mapping, 0, -1); > + } > /* 99% of the time, we don't need to flush the cleancache on the bdev. > * But, for the strange corners, lets be cautious > */ > -- > 2.10.2 > -- Jan Kara <jack@suse.com> SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-04-25 8:35 UTC|newest] Thread overview: 144+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-14 14:07 [PATCH 0/4] Properly invalidate data in the cleancache Andrey Ryabinin 2017-04-14 14:07 ` Andrey Ryabinin 2017-04-14 14:07 ` Andrey Ryabinin 2017-04-14 14:07 ` Andrey Ryabinin 2017-04-14 14:07 ` [PATCH 1/4] fs: fix data invalidation in the cleancache during direct IO Andrey Ryabinin 2017-04-14 14:07 ` Andrey Ryabinin 2017-04-14 14:07 ` Andrey Ryabinin 2017-04-18 19:38 ` Ross Zwisler 2017-04-18 19:38 ` Ross Zwisler 2017-04-18 19:38 ` Ross Zwisler 2017-04-19 15:11 ` Andrey Ryabinin 2017-04-19 15:11 ` Andrey Ryabinin 2017-04-19 15:11 ` Andrey Ryabinin 2017-04-19 19:28 ` Ross Zwisler 2017-04-19 19:28 ` Ross Zwisler [not found] ` <20170419192836.GA6364-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> 2017-04-20 14:35 ` Jan Kara 2017-04-20 14:35 ` Jan Kara 2017-04-20 14:35 ` Jan Kara [not found] ` <20170420143510.GF22135-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org> 2017-04-20 14:44 ` Jan Kara 2017-04-20 14:44 ` Jan Kara 2017-04-20 14:44 ` Jan Kara 2017-04-20 19:14 ` Ross Zwisler 2017-04-20 19:14 ` Ross Zwisler 2017-04-21 3:44 ` [PATCH 1/2] dax: prevent invalidation of mapped DAX entries Ross Zwisler 2017-04-21 3:44 ` Ross Zwisler 2017-04-21 3:44 ` Ross Zwisler 2017-04-21 3:44 ` Ross Zwisler 2017-04-21 3:44 ` Ross Zwisler 2017-04-21 3:44 ` [PATCH 2/2] dax: fix data corruption due to stale mmap reads Ross Zwisler 2017-04-21 3:44 ` Ross Zwisler 2017-04-21 3:44 ` Ross Zwisler 2017-04-21 3:44 ` Ross Zwisler 2017-04-21 3:44 ` Ross Zwisler 2017-04-25 11:10 ` Jan Kara 2017-04-25 11:10 ` Jan Kara 2017-04-25 11:10 ` Jan Kara 2017-04-25 11:10 ` Jan Kara 2017-04-25 11:10 ` Jan Kara 2017-04-25 22:59 ` Ross Zwisler 2017-04-25 22:59 ` Ross Zwisler 2017-04-25 22:59 ` Ross Zwisler 2017-04-25 22:59 ` Ross Zwisler 2017-04-25 22:59 ` Ross Zwisler 2017-04-26 8:52 ` Jan Kara 2017-04-26 8:52 ` Jan Kara 2017-04-26 8:52 ` Jan Kara 2017-04-26 8:52 ` Jan Kara 2017-04-26 8:52 ` Jan Kara 2017-04-26 22:52 ` Ross Zwisler 2017-04-26 22:52 ` Ross Zwisler 2017-04-26 22:52 ` Ross Zwisler 2017-04-26 22:52 ` Ross Zwisler 2017-04-26 22:52 ` Ross Zwisler 2017-04-27 7:26 ` Jan Kara 2017-04-27 7:26 ` Jan Kara 2017-04-27 7:26 ` Jan Kara 2017-04-27 7:26 ` Jan Kara 2017-04-27 7:26 ` Jan Kara 2017-05-01 22:38 ` Ross Zwisler 2017-05-01 22:38 ` Ross Zwisler 2017-05-01 22:38 ` Ross Zwisler 2017-05-01 22:38 ` Ross Zwisler 2017-05-01 22:38 ` Ross Zwisler 2017-05-04 9:12 ` Jan Kara 2017-05-04 9:12 ` Jan Kara 2017-05-04 9:12 ` Jan Kara 2017-05-04 9:12 ` Jan Kara 2017-05-01 22:59 ` Dan Williams 2017-05-01 22:59 ` Dan Williams 2017-05-01 22:59 ` Dan Williams 2017-05-01 22:59 ` Dan Williams 2017-05-01 22:59 ` Dan Williams 2017-04-24 17:49 ` [PATCH 1/2] xfs: fix incorrect argument count check Ross Zwisler 2017-04-24 17:49 ` Ross Zwisler 2017-04-24 17:49 ` Ross Zwisler 2017-04-24 17:49 ` [PATCH 2/2] dax: add regression test for stale mmap reads Ross Zwisler 2017-04-24 17:49 ` Ross Zwisler 2017-04-24 17:49 ` Ross Zwisler 2017-04-25 11:27 ` Eryu Guan 2017-04-25 11:27 ` Eryu Guan 2017-04-25 11:27 ` Eryu Guan 2017-04-25 20:39 ` Ross Zwisler 2017-04-25 20:39 ` Ross Zwisler 2017-04-25 20:39 ` Ross Zwisler 2017-04-26 3:42 ` Eryu Guan 2017-04-26 3:42 ` Eryu Guan 2017-04-26 3:42 ` Eryu Guan 2017-04-25 10:10 ` [PATCH 1/2] dax: prevent invalidation of mapped DAX entries Jan Kara 2017-04-25 10:10 ` Jan Kara 2017-04-25 10:10 ` Jan Kara 2017-04-25 10:10 ` Jan Kara 2017-04-25 10:10 ` Jan Kara 2017-05-01 16:54 ` Ross Zwisler 2017-05-01 16:54 ` Ross Zwisler 2017-05-01 16:54 ` Ross Zwisler 2017-05-01 16:54 ` Ross Zwisler 2017-05-01 16:54 ` Ross Zwisler [not found] ` <20170414140753.16108-2-aryabinin-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org> 2017-04-18 22:46 ` [PATCH 1/4] fs: fix data invalidation in the cleancache during direct IO Andrew Morton 2017-04-18 22:46 ` Andrew Morton 2017-04-18 22:46 ` Andrew Morton 2017-04-18 22:46 ` Andrew Morton 2017-04-19 15:15 ` Andrey Ryabinin 2017-04-19 15:15 ` Andrey Ryabinin 2017-04-19 15:15 ` Andrey Ryabinin 2017-04-14 14:07 ` [PATCH 2/4] fs/block_dev: always invalidate cleancache in invalidate_bdev() Andrey Ryabinin 2017-04-14 14:07 ` Andrey Ryabinin 2017-04-14 14:07 ` Andrey Ryabinin 2017-04-18 18:51 ` Nikolay Borisov 2017-04-18 18:51 ` Nikolay Borisov 2017-04-19 13:22 ` Andrey Ryabinin 2017-04-19 13:22 ` Andrey Ryabinin 2017-04-19 13:22 ` Andrey Ryabinin 2017-04-14 14:07 ` [PATCH 3/4] mm/truncate: bail out early from invalidate_inode_pages2_range() if mapping is empty Andrey Ryabinin 2017-04-14 14:07 ` Andrey Ryabinin 2017-04-14 14:07 ` Andrey Ryabinin 2017-04-14 14:07 ` [PATCH 4/4] mm/truncate: avoid pointless cleancache_invalidate_inode() calls Andrey Ryabinin 2017-04-14 14:07 ` Andrey Ryabinin 2017-04-14 14:07 ` Andrey Ryabinin [not found] ` <20170414140753.16108-1-aryabinin-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org> 2017-04-18 15:24 ` [PATCH 0/4] Properly invalidate data in the cleancache Konrad Rzeszutek Wilk 2017-04-18 15:24 ` Konrad Rzeszutek Wilk 2017-04-18 15:24 ` Konrad Rzeszutek Wilk 2017-04-24 16:41 ` [PATCH v2 " Andrey Ryabinin 2017-04-24 16:41 ` Andrey Ryabinin 2017-04-24 16:41 ` Andrey Ryabinin 2017-04-24 16:41 ` [PATCH v2 1/4] fs: fix data invalidation in the cleancache during direct IO Andrey Ryabinin 2017-04-24 16:41 ` Andrey Ryabinin 2017-04-24 16:41 ` Andrey Ryabinin 2017-04-25 8:25 ` Jan Kara 2017-04-25 8:25 ` Jan Kara 2017-04-24 16:41 ` [PATCH v2 2/4] fs/block_dev: always invalidate cleancache in invalidate_bdev() Andrey Ryabinin 2017-04-24 16:41 ` Andrey Ryabinin 2017-04-24 16:41 ` Andrey Ryabinin 2017-04-25 8:34 ` Jan Kara [this message] 2017-04-25 8:34 ` Jan Kara 2017-04-24 16:41 ` [PATCH v2 3/4] mm/truncate: bail out early from invalidate_inode_pages2_range() if mapping is empty Andrey Ryabinin 2017-04-24 16:41 ` Andrey Ryabinin 2017-04-24 16:41 ` Andrey Ryabinin 2017-04-25 8:37 ` Jan Kara 2017-04-25 8:37 ` Jan Kara 2017-04-24 16:41 ` [PATCH v2 4/4] mm/truncate: avoid pointless cleancache_invalidate_inode() calls Andrey Ryabinin 2017-04-24 16:41 ` Andrey Ryabinin 2017-04-24 16:41 ` Andrey Ryabinin 2017-04-25 8:41 ` Jan Kara 2017-04-25 8:41 ` Jan Kara
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170425083446.GC2793@quack2.suse.cz \ --to=jack@suse.cz \ --cc=akpm@linux-foundation.org \ --cc=aryabinin@virtuozzo.com \ --cc=axboe@kernel.dk \ --cc=hannes@cmpxchg.org \ --cc=hch@lst.de \ --cc=konrad.wilk@oracle.com \ --cc=kuznet@virtuozzo.com \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=n.borisov.lkml@gmail.com \ --cc=ross.zwisler@linux.intel.com \ --cc=stable@vger.kernel.org \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.