From: jmondi <jacopo-AW8dsiIh9cEdnm+yROfE0A@public.gmane.org> To: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org> Cc: Jacopo Mondi <jacopo+renesas-AW8dsiIh9cEdnm+yROfE0A@public.gmane.org>, Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>, Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>, Chris Brandt <chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>, Linux-Renesas <linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [PATCH v4 2/9] pinctrl: Renesas RZ/A1 pin and gpio controller Date: Wed, 26 Apr 2017 16:28:07 +0200 [thread overview] Message-ID: <20170426142757.GJ11761@w540> (raw) In-Reply-To: <CAMuHMdUy3wo9x=nkpdSVSt34q5yaARc4+kFDC592V2LF7Cxzrg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> Hi Geert, On Wed, Apr 26, 2017 at 02:21:34PM +0200, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Wed, Apr 5, 2017 at 4:07 PM, Jacopo Mondi <jacopo+renesas-AW8dsiIh9cEdnm+yROfE0A@public.gmane.org> wrote: > > Add combined gpio and pin controller driver for Renesas RZ/A1 > > r7s72100 SoC. > > > > Signed-off-by: Jacopo Mondi <jacopo+renesas-AW8dsiIh9cEdnm+yROfE0A@public.gmane.org> > > > --- /dev/null > > +++ b/drivers/pinctrl/pinctrl-rza1.c > > > +/* > > + * Keep this up-to-date with pinconf-generic.h: it performs packing of > > + * pin conf flags and argument during pinconf_generic_parse_dt_config(); > > + * we simply discard pinconf argument here > > + */ > > +#define PIN_CONF_UNPACK(pinconf) ((pinconf) & 0xffUL) > > Perhaps this should be moved to pinconf-generic.h, to make sure it stays > up-to-date? > Not sure, I'm discarding the argument of the configuration flag with this macro... I would keep this internal to this driver, or make two of them, one to retrieve the flag, and one to retrieve argument.. > > +static inline int rza1_get_bit(struct rza1_port *port, unsigned int reg, > > I'd use "unsigned int" as the return type. > It doesn't matter much as register values are 16-bit, but people might copy > from this driver when writing their own. > > > + unsigned int bit) > > +{ > > + void __iomem *mem = RZA1_ADDR(port->base, reg, port->id); > > + > > + return ioread16(mem) & BIT(bit); > > +} > > > +static inline int rza1_pin_get_direction(struct rza1_port *port, > > + unsigned int pin) > > +{ > > + unsigned long irqflags; > > + int input; > > + > > + spin_lock_irqsave(&port->lock, irqflags); > > + input = rza1_get_bit(port, RZA1_PM_REG, pin); > > + spin_unlock_irqrestore(&port->lock, irqflags); > > + > > + return input; > > return !!input; > > gpio_chip.get_direction() should return 0, 1, or a negative error value. > > > +} > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: jmondi <jacopo@jmondi.org> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>, Linus Walleij <linus.walleij@linaro.org>, Geert Uytterhoeven <geert+renesas@glider.be>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Chris Brandt <chris.brandt@renesas.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Russell King <linux@armlinux.org.uk>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v4 2/9] pinctrl: Renesas RZ/A1 pin and gpio controller Date: Wed, 26 Apr 2017 16:28:07 +0200 [thread overview] Message-ID: <20170426142757.GJ11761@w540> (raw) In-Reply-To: <CAMuHMdUy3wo9x=nkpdSVSt34q5yaARc4+kFDC592V2LF7Cxzrg@mail.gmail.com> Hi Geert, On Wed, Apr 26, 2017 at 02:21:34PM +0200, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Wed, Apr 5, 2017 at 4:07 PM, Jacopo Mondi <jacopo+renesas@jmondi.org> wrote: > > Add combined gpio and pin controller driver for Renesas RZ/A1 > > r7s72100 SoC. > > > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > > --- /dev/null > > +++ b/drivers/pinctrl/pinctrl-rza1.c > > > +/* > > + * Keep this up-to-date with pinconf-generic.h: it performs packing of > > + * pin conf flags and argument during pinconf_generic_parse_dt_config(); > > + * we simply discard pinconf argument here > > + */ > > +#define PIN_CONF_UNPACK(pinconf) ((pinconf) & 0xffUL) > > Perhaps this should be moved to pinconf-generic.h, to make sure it stays > up-to-date? > Not sure, I'm discarding the argument of the configuration flag with this macro... I would keep this internal to this driver, or make two of them, one to retrieve the flag, and one to retrieve argument.. > > +static inline int rza1_get_bit(struct rza1_port *port, unsigned int reg, > > I'd use "unsigned int" as the return type. > It doesn't matter much as register values are 16-bit, but people might copy > from this driver when writing their own. > > > + unsigned int bit) > > +{ > > + void __iomem *mem = RZA1_ADDR(port->base, reg, port->id); > > + > > + return ioread16(mem) & BIT(bit); > > +} > > > +static inline int rza1_pin_get_direction(struct rza1_port *port, > > + unsigned int pin) > > +{ > > + unsigned long irqflags; > > + int input; > > + > > + spin_lock_irqsave(&port->lock, irqflags); > > + input = rza1_get_bit(port, RZA1_PM_REG, pin); > > + spin_unlock_irqrestore(&port->lock, irqflags); > > + > > + return input; > > return !!input; > > gpio_chip.get_direction() should return 0, 1, or a negative error value. > > > +} > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
next prev parent reply other threads:[~2017-04-26 14:28 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-05 14:07 [PATCH v4 0/9] Renesas RZ/A1 pin and gpio controller Jacopo Mondi 2017-04-05 14:07 ` [PATCH v4 1/9] pinctrl: generic: Add bi-directional and output-enable Jacopo Mondi 2017-04-10 18:06 ` Rob Herring 2017-04-11 9:01 ` Linus Walleij 2017-04-05 14:07 ` [PATCH v4 2/9] pinctrl: Renesas RZ/A1 pin and gpio controller Jacopo Mondi 2017-04-26 12:21 ` Geert Uytterhoeven [not found] ` <CAMuHMdUy3wo9x=nkpdSVSt34q5yaARc4+kFDC592V2LF7Cxzrg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-04-26 14:28 ` jmondi [this message] 2017-04-26 14:28 ` jmondi 2017-04-28 8:06 ` Linus Walleij 2017-04-05 14:07 ` [PATCH v4 3/9] dt-bindings: pinctrl: Add RZ/A1 bindings doc Jacopo Mondi [not found] ` <1491401247-7030-4-git-send-email-jacopo+renesas-AW8dsiIh9cEdnm+yROfE0A@public.gmane.org> 2017-04-10 18:12 ` Rob Herring 2017-04-10 18:12 ` Rob Herring 2017-04-10 19:19 ` jmondi 2017-04-10 19:19 ` jmondi 2017-04-11 7:54 ` Linus Walleij 2017-04-26 9:02 ` Geert Uytterhoeven 2017-04-26 9:02 ` Geert Uytterhoeven 2017-04-05 14:07 ` [PATCH v4 4/9] arm: dts: dt-bindings: Add Renesas RZ/A1 pinctrl header Jacopo Mondi [not found] ` <1491401247-7030-5-git-send-email-jacopo+renesas-AW8dsiIh9cEdnm+yROfE0A@public.gmane.org> 2017-04-05 14:27 ` Geert Uytterhoeven 2017-04-05 14:27 ` Geert Uytterhoeven [not found] ` <1491401247-7030-1-git-send-email-jacopo+renesas-AW8dsiIh9cEdnm+yROfE0A@public.gmane.org> 2017-04-05 14:07 ` [PATCH v4 5/9] arm: dts: r7s72100: Add pin controller node Jacopo Mondi 2017-04-05 14:07 ` Jacopo Mondi 2017-04-05 14:07 ` [PATCH v4 6/9] arm: dts: genmai: Add SCIF2 pin group Jacopo Mondi 2017-04-05 14:07 ` Jacopo Mondi 2017-04-05 14:07 ` [PATCH v4 7/9] arm: dts: genmai: Add RIIC2 " Jacopo Mondi 2017-04-05 14:07 ` [PATCH v4 8/9] arm: dts: genmai: Add user led device nodes Jacopo Mondi 2017-04-05 14:07 ` [PATCH v4 9/9] arm: dts: genmai: Add ethernet pin group Jacopo Mondi 2017-04-10 2:33 ` [PATCH v4 0/9] Renesas RZ/A1 pin and gpio controller Chris Brandt 2017-04-10 2:33 ` Chris Brandt 2017-04-11 9:05 ` Linus Walleij 2017-04-11 9:14 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170426142757.GJ11761@w540 \ --to=jacopo-aw8dsiih9cednm+yrofe0a@public.gmane.org \ --cc=chris.brandt-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org \ --cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \ --cc=jacopo+renesas-AW8dsiIh9cEdnm+yROfE0A@public.gmane.org \ --cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \ --cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \ --cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.