From: guangrong.xiao@gmail.com To: pbonzini@redhat.com, mtosatti@redhat.com, avi.kivity@gmail.com, rkrcmar@redhat.com Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, Xiao Guangrong <xiaoguangrong@tencent.com> Subject: [PATCH 7/7] KVM: MMU: stop using mmu_spte_get_lockless under mmu-lock Date: Wed, 3 May 2017 18:52:24 +0800 [thread overview] Message-ID: <20170503105224.19049-8-xiaoguangrong@tencent.com> (raw) In-Reply-To: <20170503105224.19049-1-xiaoguangrong@tencent.com> From: Xiao Guangrong <xiaoguangrong@tencent.com> mmu_spte_age() is under the protection of mmu-lock, no reason to use mmu_spte_get_lockless() Signed-off-by: Xiao Guangrong <xiaoguangrong@tencent.com> --- arch/x86/kvm/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index f6a74e7..a8b91ee 100644 --- a/arch/x86/kvm/mmu.c +++ b/arch/x86/kvm/mmu.c @@ -852,7 +852,7 @@ static u64 restore_acc_track_spte(u64 spte) /* Returns the Accessed status of the PTE and resets it at the same time. */ static bool mmu_spte_age(u64 *sptep) { - u64 spte = mmu_spte_get_lockless(sptep); + u64 spte = *sptep; if (!is_accessed_spte(spte)) return false; -- 2.9.3
WARNING: multiple messages have this Message-ID (diff)
From: guangrong.xiao@gmail.com To: pbonzini@redhat.com, mtosatti@redhat.com, avi.kivity@gmail.com, rkrcmar@redhat.com Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, Xiao Guangrong <xiaoguangrong@tencent.com> Subject: [Qemu-devel] [PATCH 7/7] KVM: MMU: stop using mmu_spte_get_lockless under mmu-lock Date: Wed, 3 May 2017 18:52:24 +0800 [thread overview] Message-ID: <20170503105224.19049-8-xiaoguangrong@tencent.com> (raw) In-Reply-To: <20170503105224.19049-1-xiaoguangrong@tencent.com> From: Xiao Guangrong <xiaoguangrong@tencent.com> mmu_spte_age() is under the protection of mmu-lock, no reason to use mmu_spte_get_lockless() Signed-off-by: Xiao Guangrong <xiaoguangrong@tencent.com> --- arch/x86/kvm/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index f6a74e7..a8b91ee 100644 --- a/arch/x86/kvm/mmu.c +++ b/arch/x86/kvm/mmu.c @@ -852,7 +852,7 @@ static u64 restore_acc_track_spte(u64 spte) /* Returns the Accessed status of the PTE and resets it at the same time. */ static bool mmu_spte_age(u64 *sptep) { - u64 spte = mmu_spte_get_lockless(sptep); + u64 spte = *sptep; if (!is_accessed_spte(spte)) return false; -- 2.9.3
next prev parent reply other threads:[~2017-05-03 10:54 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-03 10:52 [PATCH 0/7] KVM: MMU: fast write protect guangrong.xiao 2017-05-03 10:52 ` [Qemu-devel] " guangrong.xiao 2017-05-03 10:52 ` [PATCH 1/7] KVM: MMU: correct the behavior of mmu_spte_update_no_track guangrong.xiao 2017-05-03 10:52 ` [Qemu-devel] " guangrong.xiao 2017-05-03 10:52 ` [PATCH 2/7] KVM: MMU: introduce possible_writable_spte_bitmap guangrong.xiao 2017-05-03 10:52 ` [Qemu-devel] " guangrong.xiao 2017-05-03 10:52 ` [PATCH 3/7] KVM: MMU: introduce kvm_mmu_write_protect_all_pages guangrong.xiao 2017-05-03 10:52 ` [Qemu-devel] " guangrong.xiao 2017-05-03 10:52 ` [PATCH 4/7] KVM: MMU: enable KVM_WRITE_PROTECT_ALL_MEM guangrong.xiao 2017-05-03 10:52 ` [Qemu-devel] " guangrong.xiao 2017-05-03 10:52 ` [PATCH 5/7] KVM: MMU: allow dirty log without write protect guangrong.xiao 2017-05-03 10:52 ` [Qemu-devel] " guangrong.xiao 2017-05-03 10:52 ` [PATCH 6/7] KVM: MMU: clarify fast_pf_fix_direct_spte guangrong.xiao 2017-05-03 10:52 ` [Qemu-devel] " guangrong.xiao 2017-05-03 10:52 ` guangrong.xiao [this message] 2017-05-03 10:52 ` [Qemu-devel] [PATCH 7/7] KVM: MMU: stop using mmu_spte_get_lockless under mmu-lock guangrong.xiao 2017-05-03 12:28 ` [PATCH 0/7] KVM: MMU: fast write protect Paolo Bonzini 2017-05-03 12:28 ` [Qemu-devel] " Paolo Bonzini 2017-05-03 14:50 ` Xiao Guangrong 2017-05-03 14:50 ` [Qemu-devel] " Xiao Guangrong 2017-05-03 14:57 ` Paolo Bonzini 2017-05-03 14:57 ` [Qemu-devel] " Paolo Bonzini 2017-05-04 3:36 ` Xiao Guangrong 2017-05-04 3:36 ` [Qemu-devel] " Xiao Guangrong 2017-05-04 7:06 ` Paolo Bonzini 2017-05-04 7:06 ` [Qemu-devel] " Paolo Bonzini 2017-05-23 2:23 ` Xiao Guangrong 2017-05-23 2:23 ` [Qemu-devel] " Xiao Guangrong 2017-05-29 16:48 ` Paolo Bonzini 2017-05-29 16:48 ` [Qemu-devel] " Paolo Bonzini 2017-06-09 3:19 ` Xiao Guangrong 2017-06-09 3:19 ` [Qemu-devel] " Xiao Guangrong 2017-06-05 7:36 ` Jay Zhou 2017-06-05 7:36 ` Jay Zhou 2017-06-06 2:56 ` Xiao Guangrong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170503105224.19049-8-xiaoguangrong@tencent.com \ --to=guangrong.xiao@gmail.com \ --cc=avi.kivity@gmail.com \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mtosatti@redhat.com \ --cc=pbonzini@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=rkrcmar@redhat.com \ --cc=xiaoguangrong@tencent.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.