* [U-Boot] [PATCH] x86: extend baudrate table with 57600
@ 2017-06-06 11:51 Christian Gmeiner
2017-06-06 20:04 ` Tom Rini
0 siblings, 1 reply; 9+ messages in thread
From: Christian Gmeiner @ 2017-06-06 11:51 UTC (permalink / raw)
To: u-boot
Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
---
include/configs/x86-common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h
index b5ef8b5..9a97714 100644
--- a/include/configs/x86-common.h
+++ b/include/configs/x86-common.h
@@ -56,7 +56,7 @@
* Serial Configuration
*/
#define CONFIG_SYS_BAUDRATE_TABLE {300, 600, 1200, 2400, 4800, \
- 9600, 19200, 38400, 115200}
+ 9600, 19200, 38400, 57600, 115200}
#define CONFIG_SYS_NS16550_PORT_MAPPED
#define CONFIG_CMDLINE_EDITING
--
2.9.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] x86: extend baudrate table with 57600
2017-06-06 11:51 [U-Boot] [PATCH] x86: extend baudrate table with 57600 Christian Gmeiner
@ 2017-06-06 20:04 ` Tom Rini
2017-06-08 7:38 ` Christian Gmeiner
0 siblings, 1 reply; 9+ messages in thread
From: Tom Rini @ 2017-06-06 20:04 UTC (permalink / raw)
To: u-boot
On Tue, Jun 06, 2017 at 01:51:38PM +0200, Christian Gmeiner wrote:
> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> ---
> include/configs/x86-common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h
> index b5ef8b5..9a97714 100644
> --- a/include/configs/x86-common.h
> +++ b/include/configs/x86-common.h
> @@ -56,7 +56,7 @@
> * Serial Configuration
> */
> #define CONFIG_SYS_BAUDRATE_TABLE {300, 600, 1200, 2400, 4800, \
> - 9600, 19200, 38400, 115200}
> + 9600, 19200, 38400, 57600, 115200}
> #define CONFIG_SYS_NS16550_PORT_MAPPED
>
> #define CONFIG_CMDLINE_EDITING
Can we just use the fall back table instead? Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170606/3536ec56/attachment.sig>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] x86: extend baudrate table with 57600
2017-06-06 20:04 ` Tom Rini
@ 2017-06-08 7:38 ` Christian Gmeiner
2017-06-09 0:58 ` Tom Rini
0 siblings, 1 reply; 9+ messages in thread
From: Christian Gmeiner @ 2017-06-08 7:38 UTC (permalink / raw)
To: u-boot
Hi Tom
2017-06-06 22:04 GMT+02:00 Tom Rini <trini@konsulko.com>:
> On Tue, Jun 06, 2017 at 01:51:38PM +0200, Christian Gmeiner wrote:
>
>> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
>> ---
>> include/configs/x86-common.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h
>> index b5ef8b5..9a97714 100644
>> --- a/include/configs/x86-common.h
>> +++ b/include/configs/x86-common.h
>> @@ -56,7 +56,7 @@
>> * Serial Configuration
>> */
>> #define CONFIG_SYS_BAUDRATE_TABLE {300, 600, 1200, 2400, 4800, \
>> - 9600, 19200, 38400, 115200}
>> + 9600, 19200, 38400, 57600, 115200}
>> #define CONFIG_SYS_NS16550_PORT_MAPPED
>>
>> #define CONFIG_CMDLINE_EDITING
>
> Can we just use the fall back table instead? Thanks!
>
Can you point me to the "fall back table"?
thanks
--
Christian Gmeiner, MSc
https://www.youtube.com/user/AloryOFFICIAL
https://soundcloud.com/christian-gmeiner
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] x86: extend baudrate table with 57600
2017-06-08 7:38 ` Christian Gmeiner
@ 2017-06-09 0:58 ` Tom Rini
2017-06-22 6:50 ` Bin Meng
0 siblings, 1 reply; 9+ messages in thread
From: Tom Rini @ 2017-06-09 0:58 UTC (permalink / raw)
To: u-boot
On Thu, Jun 08, 2017 at 09:38:49AM +0200, Christian Gmeiner wrote:
> Hi Tom
>
> 2017-06-06 22:04 GMT+02:00 Tom Rini <trini@konsulko.com>:
> > On Tue, Jun 06, 2017 at 01:51:38PM +0200, Christian Gmeiner wrote:
> >
> >> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> >> ---
> >> include/configs/x86-common.h | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h
> >> index b5ef8b5..9a97714 100644
> >> --- a/include/configs/x86-common.h
> >> +++ b/include/configs/x86-common.h
> >> @@ -56,7 +56,7 @@
> >> * Serial Configuration
> >> */
> >> #define CONFIG_SYS_BAUDRATE_TABLE {300, 600, 1200, 2400, 4800, \
> >> - 9600, 19200, 38400, 115200}
> >> + 9600, 19200, 38400, 57600, 115200}
> >> #define CONFIG_SYS_NS16550_PORT_MAPPED
> >>
> >> #define CONFIG_CMDLINE_EDITING
> >
> > Can we just use the fall back table instead? Thanks!
>
> Can you point me to the "fall back table"?
If one isn't defined the one in <config_fallbacks.h> is used.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170608/646a82a8/attachment.sig>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] x86: extend baudrate table with 57600
2017-06-09 0:58 ` Tom Rini
@ 2017-06-22 6:50 ` Bin Meng
2018-09-04 10:07 ` Christian Gmeiner
0 siblings, 1 reply; 9+ messages in thread
From: Bin Meng @ 2017-06-22 6:50 UTC (permalink / raw)
To: u-boot
Hi Christian,
On Fri, Jun 9, 2017 at 8:58 AM, Tom Rini <trini@konsulko.com> wrote:
> On Thu, Jun 08, 2017 at 09:38:49AM +0200, Christian Gmeiner wrote:
>> Hi Tom
>>
>> 2017-06-06 22:04 GMT+02:00 Tom Rini <trini@konsulko.com>:
>> > On Tue, Jun 06, 2017 at 01:51:38PM +0200, Christian Gmeiner wrote:
>> >
>> >> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
>> >> ---
>> >> include/configs/x86-common.h | 2 +-
>> >> 1 file changed, 1 insertion(+), 1 deletion(-)
>> >>
>> >> diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h
>> >> index b5ef8b5..9a97714 100644
>> >> --- a/include/configs/x86-common.h
>> >> +++ b/include/configs/x86-common.h
>> >> @@ -56,7 +56,7 @@
>> >> * Serial Configuration
>> >> */
>> >> #define CONFIG_SYS_BAUDRATE_TABLE {300, 600, 1200, 2400, 4800, \
>> >> - 9600, 19200, 38400, 115200}
>> >> + 9600, 19200, 38400, 57600, 115200}
>> >> #define CONFIG_SYS_NS16550_PORT_MAPPED
>> >>
>> >> #define CONFIG_CMDLINE_EDITING
>> >
>> > Can we just use the fall back table instead? Thanks!
>>
>> Can you point me to the "fall back table"?
>
> If one isn't defined the one in <config_fallbacks.h> is used.
Can you respin the patch per Tom's suggestion? Thanks!
Regards,
Bin
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] x86: extend baudrate table with 57600
2017-06-22 6:50 ` Bin Meng
@ 2018-09-04 10:07 ` Christian Gmeiner
2018-09-05 4:57 ` Bin Meng
0 siblings, 1 reply; 9+ messages in thread
From: Christian Gmeiner @ 2018-09-04 10:07 UTC (permalink / raw)
To: u-boot
Hi all,
I totally forgot to answer that mail - but as I need this change my
motivation is back.
Am Do., 22. Juni 2017 um 08:50 Uhr schrieb Bin Meng <bmeng.cn@gmail.com>:
>
> Hi Christian,
>
> On Fri, Jun 9, 2017 at 8:58 AM, Tom Rini <trini@konsulko.com> wrote:
> > On Thu, Jun 08, 2017 at 09:38:49AM +0200, Christian Gmeiner wrote:
> >> Hi Tom
> >>
> >> 2017-06-06 22:04 GMT+02:00 Tom Rini <trini@konsulko.com>:
> >> > On Tue, Jun 06, 2017 at 01:51:38PM +0200, Christian Gmeiner wrote:
> >> >
> >> >> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> >> >> ---
> >> >> include/configs/x86-common.h | 2 +-
> >> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >> >>
> >> >> diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h
> >> >> index b5ef8b5..9a97714 100644
> >> >> --- a/include/configs/x86-common.h
> >> >> +++ b/include/configs/x86-common.h
> >> >> @@ -56,7 +56,7 @@
> >> >> * Serial Configuration
> >> >> */
> >> >> #define CONFIG_SYS_BAUDRATE_TABLE {300, 600, 1200, 2400, 4800, \
> >> >> - 9600, 19200, 38400, 115200}
> >> >> + 9600, 19200, 38400, 57600, 115200}
> >> >> #define CONFIG_SYS_NS16550_PORT_MAPPED
> >> >>
> >> >> #define CONFIG_CMDLINE_EDITING
> >> >
> >> > Can we just use the fall back table instead? Thanks!
> >>
> >> Can you point me to the "fall back table"?
> >
> > If one isn't defined the one in <config_fallbacks.h> is used.
>
The fallback table looks okay and has 57600 as baud rate in it. The problematic
part is the xf86-common.h which defines CONFIG_SYS_BAUDRATE_TABLE and
as a result the fallback table plays no role here.
> Can you respin the patch per Tom's suggestion? Thanks!
I think that the current patch is okay as Tom's suggestion does not fly.
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] x86: extend baudrate table with 57600
2018-09-04 10:07 ` Christian Gmeiner
@ 2018-09-05 4:57 ` Bin Meng
2018-09-05 15:10 ` Tom Rini
0 siblings, 1 reply; 9+ messages in thread
From: Bin Meng @ 2018-09-05 4:57 UTC (permalink / raw)
To: u-boot
Hi Christian,
On Tue, Sep 4, 2018 at 6:07 PM Christian Gmeiner
<christian.gmeiner@gmail.com> wrote:
>
> Hi all,
>
> I totally forgot to answer that mail - but as I need this change my
> motivation is back.
>
> Am Do., 22. Juni 2017 um 08:50 Uhr schrieb Bin Meng <bmeng.cn@gmail.com>:
> >
> > Hi Christian,
> >
> > On Fri, Jun 9, 2017 at 8:58 AM, Tom Rini <trini@konsulko.com> wrote:
> > > On Thu, Jun 08, 2017 at 09:38:49AM +0200, Christian Gmeiner wrote:
> > >> Hi Tom
> > >>
> > >> 2017-06-06 22:04 GMT+02:00 Tom Rini <trini@konsulko.com>:
> > >> > On Tue, Jun 06, 2017 at 01:51:38PM +0200, Christian Gmeiner wrote:
> > >> >
> > >> >> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> > >> >> ---
> > >> >> include/configs/x86-common.h | 2 +-
> > >> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > >> >>
> > >> >> diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h
> > >> >> index b5ef8b5..9a97714 100644
> > >> >> --- a/include/configs/x86-common.h
> > >> >> +++ b/include/configs/x86-common.h
> > >> >> @@ -56,7 +56,7 @@
> > >> >> * Serial Configuration
> > >> >> */
> > >> >> #define CONFIG_SYS_BAUDRATE_TABLE {300, 600, 1200, 2400, 4800, \
> > >> >> - 9600, 19200, 38400, 115200}
> > >> >> + 9600, 19200, 38400, 57600, 115200}
> > >> >> #define CONFIG_SYS_NS16550_PORT_MAPPED
> > >> >>
> > >> >> #define CONFIG_CMDLINE_EDITING
> > >> >
> > >> > Can we just use the fall back table instead? Thanks!
> > >>
> > >> Can you point me to the "fall back table"?
> > >
> > > If one isn't defined the one in <config_fallbacks.h> is used.
> >
>
> The fallback table looks okay and has 57600 as baud rate in it. The problematic
> part is the xf86-common.h which defines CONFIG_SYS_BAUDRATE_TABLE and
> as a result the fallback table plays no role here.
>
> > Can you respin the patch per Tom's suggestion? Thanks!
>
> I think that the current patch is okay as Tom's suggestion does not fly.
>
I believe what Tom asked was to update config_fallbacks.h directly,
and then no need to keep x86-specific one.
Regards,
Bin
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] x86: extend baudrate table with 57600
2018-09-05 4:57 ` Bin Meng
@ 2018-09-05 15:10 ` Tom Rini
2018-09-06 7:42 ` Christian Gmeiner
0 siblings, 1 reply; 9+ messages in thread
From: Tom Rini @ 2018-09-05 15:10 UTC (permalink / raw)
To: u-boot
On Wed, Sep 05, 2018 at 12:57:39PM +0800, Bin Meng wrote:
> Hi Christian,
>
> On Tue, Sep 4, 2018 at 6:07 PM Christian Gmeiner
> <christian.gmeiner@gmail.com> wrote:
> >
> > Hi all,
> >
> > I totally forgot to answer that mail - but as I need this change my
> > motivation is back.
> >
> > Am Do., 22. Juni 2017 um 08:50 Uhr schrieb Bin Meng <bmeng.cn@gmail.com>:
> > >
> > > Hi Christian,
> > >
> > > On Fri, Jun 9, 2017 at 8:58 AM, Tom Rini <trini@konsulko.com> wrote:
> > > > On Thu, Jun 08, 2017 at 09:38:49AM +0200, Christian Gmeiner wrote:
> > > >> Hi Tom
> > > >>
> > > >> 2017-06-06 22:04 GMT+02:00 Tom Rini <trini@konsulko.com>:
> > > >> > On Tue, Jun 06, 2017 at 01:51:38PM +0200, Christian Gmeiner wrote:
> > > >> >
> > > >> >> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> > > >> >> ---
> > > >> >> include/configs/x86-common.h | 2 +-
> > > >> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >> >>
> > > >> >> diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h
> > > >> >> index b5ef8b5..9a97714 100644
> > > >> >> --- a/include/configs/x86-common.h
> > > >> >> +++ b/include/configs/x86-common.h
> > > >> >> @@ -56,7 +56,7 @@
> > > >> >> * Serial Configuration
> > > >> >> */
> > > >> >> #define CONFIG_SYS_BAUDRATE_TABLE {300, 600, 1200, 2400, 4800, \
> > > >> >> - 9600, 19200, 38400, 115200}
> > > >> >> + 9600, 19200, 38400, 57600, 115200}
> > > >> >> #define CONFIG_SYS_NS16550_PORT_MAPPED
> > > >> >>
> > > >> >> #define CONFIG_CMDLINE_EDITING
> > > >> >
> > > >> > Can we just use the fall back table instead? Thanks!
> > > >>
> > > >> Can you point me to the "fall back table"?
> > > >
> > > > If one isn't defined the one in <config_fallbacks.h> is used.
> > >
> >
> > The fallback table looks okay and has 57600 as baud rate in it. The problematic
> > part is the xf86-common.h which defines CONFIG_SYS_BAUDRATE_TABLE and
> > as a result the fallback table plays no role here.
> >
> > > Can you respin the patch per Tom's suggestion? Thanks!
> >
> > I think that the current patch is okay as Tom's suggestion does not fly.
> >
>
> I believe what Tom asked was to update config_fallbacks.h directly,
> and then no need to keep x86-specific one.
To be extra clear, drop the table from the x86 file and then the default
will be used.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180905/cc40ac9c/attachment.sig>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] x86: extend baudrate table with 57600
2018-09-05 15:10 ` Tom Rini
@ 2018-09-06 7:42 ` Christian Gmeiner
0 siblings, 0 replies; 9+ messages in thread
From: Christian Gmeiner @ 2018-09-06 7:42 UTC (permalink / raw)
To: u-boot
Am Mi., 5. Sep. 2018 um 17:10 Uhr schrieb Tom Rini <trini@konsulko.com>:
>
> On Wed, Sep 05, 2018 at 12:57:39PM +0800, Bin Meng wrote:
> > Hi Christian,
> >
> > On Tue, Sep 4, 2018 at 6:07 PM Christian Gmeiner
> > <christian.gmeiner@gmail.com> wrote:
> > >
> > > Hi all,
> > >
> > > I totally forgot to answer that mail - but as I need this change my
> > > motivation is back.
> > >
> > > Am Do., 22. Juni 2017 um 08:50 Uhr schrieb Bin Meng <bmeng.cn@gmail.com>:
> > > >
> > > > Hi Christian,
> > > >
> > > > On Fri, Jun 9, 2017 at 8:58 AM, Tom Rini <trini@konsulko.com> wrote:
> > > > > On Thu, Jun 08, 2017 at 09:38:49AM +0200, Christian Gmeiner wrote:
> > > > >> Hi Tom
> > > > >>
> > > > >> 2017-06-06 22:04 GMT+02:00 Tom Rini <trini@konsulko.com>:
> > > > >> > On Tue, Jun 06, 2017 at 01:51:38PM +0200, Christian Gmeiner wrote:
> > > > >> >
> > > > >> >> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> > > > >> >> ---
> > > > >> >> include/configs/x86-common.h | 2 +-
> > > > >> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >> >>
> > > > >> >> diff --git a/include/configs/x86-common.h b/include/configs/x86-common.h
> > > > >> >> index b5ef8b5..9a97714 100644
> > > > >> >> --- a/include/configs/x86-common.h
> > > > >> >> +++ b/include/configs/x86-common.h
> > > > >> >> @@ -56,7 +56,7 @@
> > > > >> >> * Serial Configuration
> > > > >> >> */
> > > > >> >> #define CONFIG_SYS_BAUDRATE_TABLE {300, 600, 1200, 2400, 4800, \
> > > > >> >> - 9600, 19200, 38400, 115200}
> > > > >> >> + 9600, 19200, 38400, 57600, 115200}
> > > > >> >> #define CONFIG_SYS_NS16550_PORT_MAPPED
> > > > >> >>
> > > > >> >> #define CONFIG_CMDLINE_EDITING
> > > > >> >
> > > > >> > Can we just use the fall back table instead? Thanks!
> > > > >>
> > > > >> Can you point me to the "fall back table"?
> > > > >
> > > > > If one isn't defined the one in <config_fallbacks.h> is used.
> > > >
> > >
> > > The fallback table looks okay and has 57600 as baud rate in it. The problematic
> > > part is the xf86-common.h which defines CONFIG_SYS_BAUDRATE_TABLE and
> > > as a result the fallback table plays no role here.
> > >
> > > > Can you respin the patch per Tom's suggestion? Thanks!
> > >
> > > I think that the current patch is okay as Tom's suggestion does not fly.
> > >
> >
> > I believe what Tom asked was to update config_fallbacks.h directly,
> > and then no need to keep x86-specific one.
>
> To be extra clear, drop the table from the x86 file and then the default
> will be used.
>
Got it - thanks...
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-09-06 7:42 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-06 11:51 [U-Boot] [PATCH] x86: extend baudrate table with 57600 Christian Gmeiner
2017-06-06 20:04 ` Tom Rini
2017-06-08 7:38 ` Christian Gmeiner
2017-06-09 0:58 ` Tom Rini
2017-06-22 6:50 ` Bin Meng
2018-09-04 10:07 ` Christian Gmeiner
2018-09-05 4:57 ` Bin Meng
2018-09-05 15:10 ` Tom Rini
2018-09-06 7:42 ` Christian Gmeiner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.