From: Michal Hocko <mhocko@kernel.org> To: Wei Yang <richard.weiyang@gmail.com> Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org, Mel Gorman <mgorman@suse.de>, Vlastimil Babka <vbabka@suse.cz>, Andrea Arcangeli <aarcange@redhat.com>, Reza Arbab <arbab@linux.vnet.ibm.com>, Yasuaki Ishimatsu <yasu.isimatu@gmail.com>, qiuxishi@huawei.com, Kani Toshimitsu <toshi.kani@hpe.com>, slaoub@gmail.com, Joonsoo Kim <js1304@gmail.com>, Andi Kleen <ak@linux.intel.com>, David Rientjes <rientjes@google.com>, Daniel Kiper <daniel.kiper@oracle.com>, Igor Mammedov <imammedo@redhat.com>, Vitaly Kuznetsov <vkuznets@redhat.com>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] mm, memory_hotplug: support movable_node for hotplugable nodes Date: Thu, 15 Jun 2017 10:16:11 +0200 [thread overview] Message-ID: <20170615081611.GD1486@dhcp22.suse.cz> (raw) In-Reply-To: <20170615031354.GC16833@WeideMacBook-Pro.local> On Thu 15-06-17 11:13:54, Wei Yang wrote: > On Mon, Jun 12, 2017 at 08:45:02AM +0200, Michal Hocko wrote: > >On Mon 12-06-17 12:28:32, Wei Yang wrote: > >> On Thu, Jun 08, 2017 at 02:23:18PM +0200, Michal Hocko wrote: > >> >From: Michal Hocko <mhocko@suse.com> > >> > > >> >movable_node kernel parameter allows to make hotplugable NUMA > >> >nodes to put all the hotplugable memory into movable zone which > >> >allows more or less reliable memory hotremove. At least this > >> >is the case for the NUMA nodes present during the boot (see > >> >find_zone_movable_pfns_for_nodes). > >> > > >> > >> When movable_node is enabled, we would have overlapped zones, right? > > > >It won't based on this patch. See movable_pfn_range > > > > Ok, I went through the code and here maybe a question not that close related > to this patch. Please start a new thread with unrelated questions > I did some experiment with qemu+kvm and see this. > > Guest config: 8G RAM, 2 nodes with 4G on each > Guest kernel: 4.11 > Guest kernel command: kernelcore=1G > > The log message in kernel is: > > [ 0.000000] Zone ranges: > [ 0.000000] DMA [mem 0x0000000000001000-0x0000000000ffffff] > [ 0.000000] DMA32 [mem 0x0000000001000000-0x00000000ffffffff] > [ 0.000000] Normal [mem 0x0000000100000000-0x000000023fffffff] > [ 0.000000] Movable zone start for each node > [ 0.000000] Node 0: 0x0000000100000000 > [ 0.000000] Node 1: 0x0000000140000000 > > We see on node 2, ZONE_NORMAL overlap with ZONE_MOVABLE. > [0x0000000140000000 - 0x000000023fffffff] belongs to both ZONE. Not really. The above output is just confusing a bit. Zone ranges print arch_zone_{lowest,highest}_possible_pfn range while the Movable zone is excluded from that in adjust_zone_range_for_zone_movable -- Michal Hocko SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org> To: Wei Yang <richard.weiyang@gmail.com> Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org, Mel Gorman <mgorman@suse.de>, Vlastimil Babka <vbabka@suse.cz>, Andrea Arcangeli <aarcange@redhat.com>, Reza Arbab <arbab@linux.vnet.ibm.com>, Yasuaki Ishimatsu <yasu.isimatu@gmail.com>, qiuxishi@huawei.com, Kani Toshimitsu <toshi.kani@hpe.com>, slaoub@gmail.com, Joonsoo Kim <js1304@gmail.com>, Andi Kleen <ak@linux.intel.com>, David Rientjes <rientjes@google.com>, Daniel Kiper <daniel.kiper@oracle.com>, Igor Mammedov <imammedo@redhat.com>, Vitaly Kuznetsov <vkuznets@redhat.com>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] mm, memory_hotplug: support movable_node for hotplugable nodes Date: Thu, 15 Jun 2017 10:16:11 +0200 [thread overview] Message-ID: <20170615081611.GD1486@dhcp22.suse.cz> (raw) In-Reply-To: <20170615031354.GC16833@WeideMacBook-Pro.local> On Thu 15-06-17 11:13:54, Wei Yang wrote: > On Mon, Jun 12, 2017 at 08:45:02AM +0200, Michal Hocko wrote: > >On Mon 12-06-17 12:28:32, Wei Yang wrote: > >> On Thu, Jun 08, 2017 at 02:23:18PM +0200, Michal Hocko wrote: > >> >From: Michal Hocko <mhocko@suse.com> > >> > > >> >movable_node kernel parameter allows to make hotplugable NUMA > >> >nodes to put all the hotplugable memory into movable zone which > >> >allows more or less reliable memory hotremove. At least this > >> >is the case for the NUMA nodes present during the boot (see > >> >find_zone_movable_pfns_for_nodes). > >> > > >> > >> When movable_node is enabled, we would have overlapped zones, right? > > > >It won't based on this patch. See movable_pfn_range > > > > Ok, I went through the code and here maybe a question not that close related > to this patch. Please start a new thread with unrelated questions > I did some experiment with qemu+kvm and see this. > > Guest config: 8G RAM, 2 nodes with 4G on each > Guest kernel: 4.11 > Guest kernel command: kernelcore=1G > > The log message in kernel is: > > [ 0.000000] Zone ranges: > [ 0.000000] DMA [mem 0x0000000000001000-0x0000000000ffffff] > [ 0.000000] DMA32 [mem 0x0000000001000000-0x00000000ffffffff] > [ 0.000000] Normal [mem 0x0000000100000000-0x000000023fffffff] > [ 0.000000] Movable zone start for each node > [ 0.000000] Node 0: 0x0000000100000000 > [ 0.000000] Node 1: 0x0000000140000000 > > We see on node 2, ZONE_NORMAL overlap with ZONE_MOVABLE. > [0x0000000140000000 - 0x000000023fffffff] belongs to both ZONE. Not really. The above output is just confusing a bit. Zone ranges print arch_zone_{lowest,highest}_possible_pfn range while the Movable zone is excluded from that in adjust_zone_range_for_zone_movable -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-06-15 8:16 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-08 12:23 [PATCH] mm, memory_hotplug: support movable_node for hotplugable nodes Michal Hocko 2017-06-08 12:23 ` Michal Hocko 2017-06-10 14:33 ` Wei Yang 2017-06-12 6:35 ` Michal Hocko 2017-06-12 6:35 ` Michal Hocko 2017-06-11 1:45 ` Wei Yang 2017-06-12 6:37 ` Michal Hocko 2017-06-12 6:37 ` Michal Hocko 2017-06-12 4:28 ` Wei Yang 2017-06-12 6:45 ` Michal Hocko 2017-06-12 6:45 ` Michal Hocko 2017-06-14 9:06 ` Wei Yang 2017-06-14 9:07 ` Vlastimil Babka 2017-06-14 9:07 ` Vlastimil Babka 2017-06-15 1:03 ` Wei Yang 2017-06-15 3:13 ` Wei Yang 2017-06-15 8:16 ` Michal Hocko [this message] 2017-06-15 8:16 ` Michal Hocko 2017-06-12 8:58 ` Vlastimil Babka 2017-06-12 8:58 ` Vlastimil Babka 2017-06-12 11:12 ` [PATCH -v2] " Michal Hocko 2017-06-12 11:12 ` Michal Hocko 2017-06-15 3:29 ` [PATCH] " Wei Yang 2017-06-15 8:24 ` Michal Hocko 2017-06-15 8:24 ` Michal Hocko 2017-06-15 15:43 ` Reza Arbab 2017-06-15 15:43 ` Reza Arbab
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170615081611.GD1486@dhcp22.suse.cz \ --to=mhocko@kernel.org \ --cc=aarcange@redhat.com \ --cc=ak@linux.intel.com \ --cc=akpm@linux-foundation.org \ --cc=arbab@linux.vnet.ibm.com \ --cc=daniel.kiper@oracle.com \ --cc=imammedo@redhat.com \ --cc=js1304@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=qiuxishi@huawei.com \ --cc=richard.weiyang@gmail.com \ --cc=rientjes@google.com \ --cc=slaoub@gmail.com \ --cc=toshi.kani@hpe.com \ --cc=vbabka@suse.cz \ --cc=vkuznets@redhat.com \ --cc=yasu.isimatu@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.