From: Christoph Hellwig <hch@lst.de> To: Jens Axboe <axboe@kernel.dk> Cc: Keith Busch <keith.busch@intel.com>, Sagi Grimberg <sagi@grimberg.me>, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org Subject: [PATCH 08/10] block: provide a generic_make_request_fast helper Date: Wed, 23 Aug 2017 19:58:13 +0200 [thread overview] Message-ID: <20170823175815.3646-9-hch@lst.de> (raw) In-Reply-To: <20170823175815.3646-1-hch@lst.de> This helper allows reinserting a bio into a new queue without much overhead, but requires all queue limits to be the same for the upper and lower queues, and it does not provide any recursion preventions, which requires the caller to not split the bio. Signed-off-by: Christoph Hellwig <hch@lst.de> --- block/blk-core.c | 26 ++++++++++++++++++++++++++ include/linux/blkdev.h | 1 + 2 files changed, 27 insertions(+) diff --git a/block/blk-core.c b/block/blk-core.c index 0c7050f20a60..e91f3477538f 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -2224,6 +2224,32 @@ blk_qc_t generic_make_request(struct bio *bio) } EXPORT_SYMBOL(generic_make_request); +/* + * Fast-path version of generic_make_request. The caller must ensure that + * generic_make_request_checks has already been called with the limits that + * fit the queue, and no recursion prevention is provided. + */ +blk_qc_t generic_make_request_fast(struct bio *bio) +{ + struct request_queue *q = bio->bi_disk->queue; + bool nowait = bio->bi_opf & REQ_NOWAIT; + blk_qc_t ret = BLK_QC_T_NONE; + + if (unlikely(blk_queue_enter(q, nowait))) { + if (nowait && !blk_queue_dying(q)) + bio->bi_status = BLK_STS_AGAIN; + else + bio->bi_status = BLK_STS_IOERR; + bio_endio(bio); + return BLK_QC_T_NONE; + } + + ret = q->make_request_fn(q, bio); + blk_queue_exit(q); + return ret; +} +EXPORT_SYMBOL_GPL(generic_make_request_fast); + /** * submit_bio - submit a bio to the block device layer for I/O * @bio: The &struct bio which describes the I/O diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 25f6a0cb27d3..5f81151d181a 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -938,6 +938,7 @@ do { \ extern int blk_register_queue(struct gendisk *disk); extern void blk_unregister_queue(struct gendisk *disk); extern blk_qc_t generic_make_request(struct bio *bio); +extern blk_qc_t generic_make_request_fast(struct bio *bio); extern void blk_rq_init(struct request_queue *q, struct request *rq); extern void blk_init_request_from_bio(struct request *req, struct bio *bio); extern void blk_put_request(struct request *); -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig) Subject: [PATCH 08/10] block: provide a generic_make_request_fast helper Date: Wed, 23 Aug 2017 19:58:13 +0200 [thread overview] Message-ID: <20170823175815.3646-9-hch@lst.de> (raw) In-Reply-To: <20170823175815.3646-1-hch@lst.de> This helper allows reinserting a bio into a new queue without much overhead, but requires all queue limits to be the same for the upper and lower queues, and it does not provide any recursion preventions, which requires the caller to not split the bio. Signed-off-by: Christoph Hellwig <hch at lst.de> --- block/blk-core.c | 26 ++++++++++++++++++++++++++ include/linux/blkdev.h | 1 + 2 files changed, 27 insertions(+) diff --git a/block/blk-core.c b/block/blk-core.c index 0c7050f20a60..e91f3477538f 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -2224,6 +2224,32 @@ blk_qc_t generic_make_request(struct bio *bio) } EXPORT_SYMBOL(generic_make_request); +/* + * Fast-path version of generic_make_request. The caller must ensure that + * generic_make_request_checks has already been called with the limits that + * fit the queue, and no recursion prevention is provided. + */ +blk_qc_t generic_make_request_fast(struct bio *bio) +{ + struct request_queue *q = bio->bi_disk->queue; + bool nowait = bio->bi_opf & REQ_NOWAIT; + blk_qc_t ret = BLK_QC_T_NONE; + + if (unlikely(blk_queue_enter(q, nowait))) { + if (nowait && !blk_queue_dying(q)) + bio->bi_status = BLK_STS_AGAIN; + else + bio->bi_status = BLK_STS_IOERR; + bio_endio(bio); + return BLK_QC_T_NONE; + } + + ret = q->make_request_fn(q, bio); + blk_queue_exit(q); + return ret; +} +EXPORT_SYMBOL_GPL(generic_make_request_fast); + /** * submit_bio - submit a bio to the block device layer for I/O * @bio: The &struct bio which describes the I/O diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 25f6a0cb27d3..5f81151d181a 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -938,6 +938,7 @@ do { \ extern int blk_register_queue(struct gendisk *disk); extern void blk_unregister_queue(struct gendisk *disk); extern blk_qc_t generic_make_request(struct bio *bio); +extern blk_qc_t generic_make_request_fast(struct bio *bio); extern void blk_rq_init(struct request_queue *q, struct request *rq); extern void blk_init_request_from_bio(struct request *req, struct bio *bio); extern void blk_put_request(struct request *); -- 2.11.0
next prev parent reply other threads:[~2017-08-23 17:58 UTC|newest] Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-23 17:58 RFC: nvme multipath support Christoph Hellwig 2017-08-23 17:58 ` Christoph Hellwig 2017-08-23 17:58 ` [PATCH 01/10] nvme: report more detailed status codes to the block layer Christoph Hellwig 2017-08-23 17:58 ` Christoph Hellwig 2017-08-28 6:06 ` Sagi Grimberg 2017-08-28 6:06 ` Sagi Grimberg 2017-08-28 18:50 ` Keith Busch 2017-08-28 18:50 ` Keith Busch 2017-08-23 17:58 ` [PATCH 02/10] nvme: allow calling nvme_change_ctrl_state from irq context Christoph Hellwig 2017-08-23 17:58 ` Christoph Hellwig 2017-08-28 6:06 ` Sagi Grimberg 2017-08-28 6:06 ` Sagi Grimberg 2017-08-28 18:50 ` Keith Busch 2017-08-28 18:50 ` Keith Busch 2017-08-23 17:58 ` [PATCH 03/10] nvme: remove unused struct nvme_ns fields Christoph Hellwig 2017-08-23 17:58 ` Christoph Hellwig 2017-08-28 6:07 ` Sagi Grimberg 2017-08-28 6:07 ` Sagi Grimberg 2017-08-28 19:13 ` Keith Busch 2017-08-28 19:13 ` Keith Busch 2017-08-23 17:58 ` [PATCH 04/10] nvme: remove nvme_revalidate_ns Christoph Hellwig 2017-08-23 17:58 ` Christoph Hellwig 2017-08-28 6:12 ` Sagi Grimberg 2017-08-28 6:12 ` Sagi Grimberg 2017-08-28 19:14 ` Keith Busch 2017-08-28 19:14 ` Keith Busch 2017-08-23 17:58 ` [PATCH 05/10] nvme: don't blindly overwrite identifiers on disk revalidate Christoph Hellwig 2017-08-23 17:58 ` Christoph Hellwig 2017-08-28 6:17 ` Sagi Grimberg 2017-08-28 6:17 ` Sagi Grimberg 2017-08-28 6:23 ` Christoph Hellwig 2017-08-28 6:23 ` Christoph Hellwig 2017-08-28 6:32 ` Sagi Grimberg 2017-08-28 6:32 ` Sagi Grimberg 2017-08-28 19:15 ` Keith Busch 2017-08-28 19:15 ` Keith Busch 2017-08-23 17:58 ` [PATCH 06/10] nvme: track subsystems Christoph Hellwig 2017-08-23 17:58 ` Christoph Hellwig 2017-08-23 22:04 ` Keith Busch 2017-08-23 22:04 ` Keith Busch 2017-08-24 8:52 ` Christoph Hellwig 2017-08-24 8:52 ` Christoph Hellwig 2017-08-28 6:22 ` Sagi Grimberg 2017-08-28 6:22 ` Sagi Grimberg 2017-08-23 17:58 ` [PATCH 07/10] nvme: track shared namespaces Christoph Hellwig 2017-08-23 17:58 ` Christoph Hellwig 2017-08-28 6:51 ` Sagi Grimberg 2017-08-28 6:51 ` Sagi Grimberg 2017-08-28 8:50 ` Christoph Hellwig 2017-08-28 8:50 ` Christoph Hellwig 2017-08-28 20:21 ` J Freyensee 2017-08-28 20:21 ` J Freyensee 2017-08-29 8:25 ` Christoph Hellwig 2017-08-29 8:25 ` Christoph Hellwig 2017-08-29 6:54 ` Guan Junxiong 2017-08-29 6:54 ` Guan Junxiong 2017-08-28 12:04 ` javigon 2017-08-28 12:04 ` javigon 2017-08-28 12:41 ` Guan Junxiong 2017-08-28 12:41 ` Guan Junxiong 2017-08-28 14:30 ` Christoph Hellwig 2017-08-28 14:30 ` Christoph Hellwig 2017-08-29 2:42 ` Guan Junxiong 2017-08-29 2:42 ` Guan Junxiong 2017-08-29 8:30 ` Christoph Hellwig 2017-08-29 8:30 ` Christoph Hellwig 2017-08-29 8:29 ` Christoph Hellwig 2017-08-29 8:29 ` Christoph Hellwig 2017-08-28 19:18 ` Keith Busch 2017-08-28 19:18 ` Keith Busch 2017-08-23 17:58 ` Christoph Hellwig [this message] 2017-08-23 17:58 ` [PATCH 08/10] block: provide a generic_make_request_fast helper Christoph Hellwig 2017-08-28 7:00 ` Sagi Grimberg 2017-08-28 7:00 ` Sagi Grimberg 2017-08-28 8:54 ` Christoph Hellwig 2017-08-28 8:54 ` Christoph Hellwig 2017-08-28 11:01 ` Sagi Grimberg 2017-08-28 11:01 ` Sagi Grimberg 2017-08-28 11:54 ` Christoph Hellwig 2017-08-28 11:54 ` Christoph Hellwig 2017-08-28 12:38 ` Sagi Grimberg 2017-08-28 12:38 ` Sagi Grimberg 2017-08-23 17:58 ` [PATCH 09/10] blk-mq: add a blk_steal_bios helper Christoph Hellwig 2017-08-23 17:58 ` Christoph Hellwig 2017-08-28 7:04 ` Sagi Grimberg 2017-08-28 7:04 ` Sagi Grimberg 2017-08-23 17:58 ` [PATCH 10/10] nvme: implement multipath access to nvme subsystems Christoph Hellwig 2017-08-23 17:58 ` Christoph Hellwig 2017-08-23 18:21 ` Bart Van Assche 2017-08-23 18:21 ` Bart Van Assche 2017-08-24 8:59 ` hch 2017-08-24 8:59 ` hch 2017-08-24 20:17 ` Bart Van Assche 2017-08-24 20:17 ` Bart Van Assche 2017-09-05 11:53 ` Christoph Hellwig 2017-09-05 11:53 ` Christoph Hellwig 2017-09-11 6:34 ` Tony Yang 2017-08-23 22:53 ` Keith Busch 2017-08-23 22:53 ` Keith Busch 2017-08-24 8:52 ` Christoph Hellwig 2017-08-24 8:52 ` Christoph Hellwig 2017-08-28 7:23 ` Sagi Grimberg 2017-08-28 7:23 ` Sagi Grimberg 2017-08-28 9:06 ` Christoph Hellwig 2017-08-28 9:06 ` Christoph Hellwig 2017-08-28 13:40 ` Sagi Grimberg 2017-08-28 13:40 ` Sagi Grimberg 2017-08-28 14:24 ` Christoph Hellwig 2017-08-28 14:24 ` Christoph Hellwig 2017-09-07 15:17 ` Tony Yang 2017-08-29 10:22 ` Guan Junxiong 2017-08-29 10:22 ` Guan Junxiong 2017-08-29 14:51 ` Christoph Hellwig 2017-08-29 14:51 ` Christoph Hellwig 2017-08-29 14:54 ` Keith Busch 2017-08-29 14:54 ` Keith Busch 2017-08-29 14:55 ` Christoph Hellwig 2017-08-29 14:55 ` Christoph Hellwig 2017-08-29 15:41 ` Keith Busch 2017-08-29 15:41 ` Keith Busch 2017-09-18 0:17 ` Christoph Hellwig 2017-09-18 0:17 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170823175815.3646-9-hch@lst.de \ --to=hch@lst.de \ --cc=axboe@kernel.dk \ --cc=keith.busch@intel.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=sagi@grimberg.me \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.