All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915: Remove excess indent in intel_finish_reset() caught by sparse
@ 2017-08-28 10:46 Chris Wilson
  2017-08-28 11:30 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Chris Wilson @ 2017-08-28 10:46 UTC (permalink / raw)
  To: intel-gfx

  CHECK   drivers/gpu/drm/i915/intel_display.c
drivers/gpu/drm/i915/intel_display.c:3753 intel_finish_reset() warn: inconsistent indenting

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/intel_display.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 7cd392f2cd94..7317e1d1c1e8 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -3750,8 +3750,8 @@ void intel_finish_reset(struct drm_i915_private *dev_priv)
 	if (!gpu_reset_clobbers_display(dev_priv)) {
 		/* for testing only restore the display */
 		ret = __intel_display_resume(dev, state, ctx);
-			if (ret)
-				DRM_ERROR("Restoring old state failed with %i\n", ret);
+		if (ret)
+			DRM_ERROR("Restoring old state failed with %i\n", ret);
 	} else {
 		/*
 		 * The display has been reset as well,
-- 
2.14.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Remove excess indent in intel_finish_reset() caught by sparse
  2017-08-28 10:46 [PATCH] drm/i915: Remove excess indent in intel_finish_reset() caught by sparse Chris Wilson
@ 2017-08-28 11:30 ` Patchwork
  2017-08-28 13:01 ` ✗ Fi.CI.IGT: warning " Patchwork
  2017-08-28 22:12 ` [PATCH] " Daniel Vetter
  2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-08-28 11:30 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Remove excess indent in intel_finish_reset() caught by sparse
URL   : https://patchwork.freedesktop.org/series/29424/
State : success

== Summary ==

Series 29424v1 drm/i915: Remove excess indent in intel_finish_reset() caught by sparse
https://patchwork.freedesktop.org/api/1.0/series/29424/revisions/1/mbox/

fi-bdw-5557u     total:279  pass:268  dwarn:0   dfail:0   fail:0   skip:11  time:455s
fi-bdw-gvtdvm    total:279  pass:265  dwarn:0   dfail:0   fail:0   skip:14  time:446s
fi-blb-e6850     total:279  pass:224  dwarn:1   dfail:0   fail:0   skip:54  time:360s
fi-bsw-n3050     total:279  pass:243  dwarn:0   dfail:0   fail:0   skip:36  time:560s
fi-bwr-2160      total:279  pass:184  dwarn:0   dfail:0   fail:0   skip:95  time:256s
fi-bxt-j4205     total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:523s
fi-byt-j1900     total:279  pass:254  dwarn:1   dfail:0   fail:0   skip:24  time:516s
fi-byt-n2820     total:279  pass:250  dwarn:1   dfail:0   fail:0   skip:28  time:515s
fi-elk-e7500     total:279  pass:230  dwarn:0   dfail:0   fail:0   skip:49  time:438s
fi-glk-2a        total:279  pass:260  dwarn:0   dfail:0   fail:0   skip:19  time:612s
fi-hsw-4770      total:279  pass:263  dwarn:0   dfail:0   fail:0   skip:16  time:456s
fi-hsw-4770r     total:279  pass:263  dwarn:0   dfail:0   fail:0   skip:16  time:422s
fi-ilk-650       total:279  pass:229  dwarn:0   dfail:0   fail:0   skip:50  time:418s
fi-ivb-3520m     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:497s
fi-ivb-3770      total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:473s
fi-kbl-7500u     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:481s
fi-kbl-7560u     total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:609s
fi-kbl-r         total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:594s
fi-pnv-d510      total:279  pass:223  dwarn:1   dfail:0   fail:0   skip:55  time:527s
fi-skl-6260u     total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:471s
fi-skl-6700k     total:279  pass:261  dwarn:0   dfail:0   fail:0   skip:18  time:474s
fi-skl-6770hq    total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:502s
fi-skl-gvtdvm    total:279  pass:266  dwarn:0   dfail:0   fail:0   skip:13  time:441s
fi-skl-x1585l    total:279  pass:269  dwarn:0   dfail:0   fail:0   skip:10  time:502s
fi-snb-2520m     total:279  pass:251  dwarn:0   dfail:0   fail:0   skip:28  time:543s
fi-snb-2600      total:279  pass:249  dwarn:0   dfail:0   fail:1   skip:29  time:401s

00b77f621f835bc114b79ec897b9aa277ea5726b drm-tip: 2017y-08m-28d-10h-25m-08s UTC integration manifest
1403c89af085 drm/i915: Remove excess indent in intel_finish_reset() caught by sparse

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5506/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* ✗ Fi.CI.IGT: warning for drm/i915: Remove excess indent in intel_finish_reset() caught by sparse
  2017-08-28 10:46 [PATCH] drm/i915: Remove excess indent in intel_finish_reset() caught by sparse Chris Wilson
  2017-08-28 11:30 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-08-28 13:01 ` Patchwork
  2017-08-28 22:12 ` [PATCH] " Daniel Vetter
  2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-08-28 13:01 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

== Series Details ==

Series: drm/i915: Remove excess indent in intel_finish_reset() caught by sparse
URL   : https://patchwork.freedesktop.org/series/29424/
State : warning

== Summary ==

Test perf:
        Subgroup blocking:
                pass       -> FAIL       (shard-hsw) fdo#102252
Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-primscrn-spr-indfb-draw-render:
                pass       -> SKIP       (shard-hsw)

fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252

shard-hsw        total:2186 pass:1211 dwarn:0   dfail:0   fail:17  skip:958 time:9510s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5506/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Remove excess indent in intel_finish_reset() caught by sparse
  2017-08-28 10:46 [PATCH] drm/i915: Remove excess indent in intel_finish_reset() caught by sparse Chris Wilson
  2017-08-28 11:30 ` ✓ Fi.CI.BAT: success for " Patchwork
  2017-08-28 13:01 ` ✗ Fi.CI.IGT: warning " Patchwork
@ 2017-08-28 22:12 ` Daniel Vetter
  2017-08-29  9:57   ` Chris Wilson
  2 siblings, 1 reply; 5+ messages in thread
From: Daniel Vetter @ 2017-08-28 22:12 UTC (permalink / raw)
  To: Chris Wilson; +Cc: intel-gfx

On Mon, Aug 28, 2017 at 11:46:04AM +0100, Chris Wilson wrote:
>   CHECK   drivers/gpu/drm/i915/intel_display.c
> drivers/gpu/drm/i915/intel_display.c:3753 intel_finish_reset() warn: inconsistent indenting
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>

Ooops, I think that was me :-(

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> ---
>  drivers/gpu/drm/i915/intel_display.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 7cd392f2cd94..7317e1d1c1e8 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -3750,8 +3750,8 @@ void intel_finish_reset(struct drm_i915_private *dev_priv)
>  	if (!gpu_reset_clobbers_display(dev_priv)) {
>  		/* for testing only restore the display */
>  		ret = __intel_display_resume(dev, state, ctx);
> -			if (ret)
> -				DRM_ERROR("Restoring old state failed with %i\n", ret);
> +		if (ret)
> +			DRM_ERROR("Restoring old state failed with %i\n", ret);
>  	} else {
>  		/*
>  		 * The display has been reset as well,
> -- 
> 2.14.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915: Remove excess indent in intel_finish_reset() caught by sparse
  2017-08-28 22:12 ` [PATCH] " Daniel Vetter
@ 2017-08-29  9:57   ` Chris Wilson
  0 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2017-08-29  9:57 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: intel-gfx

Quoting Daniel Vetter (2017-08-28 23:12:57)
> On Mon, Aug 28, 2017 at 11:46:04AM +0100, Chris Wilson wrote:
> >   CHECK   drivers/gpu/drm/i915/intel_display.c
> > drivers/gpu/drm/i915/intel_display.c:3753 intel_finish_reset() warn: inconsistent indenting
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> Ooops, I think that was me :-(
> 
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

And the trivial cleanup pushed.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-08-29  9:57 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-28 10:46 [PATCH] drm/i915: Remove excess indent in intel_finish_reset() caught by sparse Chris Wilson
2017-08-28 11:30 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-08-28 13:01 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-08-28 22:12 ` [PATCH] " Daniel Vetter
2017-08-29  9:57   ` Chris Wilson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.