All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] hinic: don't build the module by default
@ 2017-08-28 13:16 Vitaly Kuznetsov
  2017-08-29  4:40 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Vitaly Kuznetsov @ 2017-08-28 13:16 UTC (permalink / raw)
  To: netdev; +Cc: Aviad Krawczyk, linux-kernel

We probably don't want to enable code supporting particular hardware by
default e.g. when someone does 'make defconfig'. Other ethernet modules
don't do it.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
 drivers/net/ethernet/huawei/hinic/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/huawei/hinic/Kconfig b/drivers/net/ethernet/huawei/hinic/Kconfig
index 69f2b1fba48d..08db24954f7e 100644
--- a/drivers/net/ethernet/huawei/hinic/Kconfig
+++ b/drivers/net/ethernet/huawei/hinic/Kconfig
@@ -5,7 +5,6 @@
 config HINIC
 	tristate "Huawei Intelligent PCIE Network Interface Card"
 	depends on (PCI_MSI && X86)
-	default m
 	---help---
 	  This driver supports HiNIC PCIE Ethernet cards.
 	  To compile this driver as part of the kernel, choose Y here.
-- 
2.13.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] hinic: don't build the module by default
  2017-08-28 13:16 [PATCH net-next] hinic: don't build the module by default Vitaly Kuznetsov
@ 2017-08-29  4:40 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-08-29  4:40 UTC (permalink / raw)
  To: vkuznets; +Cc: netdev, aviad.krawczyk, linux-kernel

From: Vitaly Kuznetsov <vkuznets@redhat.com>
Date: Mon, 28 Aug 2017 15:16:05 +0200

> We probably don't want to enable code supporting particular hardware by
> default e.g. when someone does 'make defconfig'. Other ethernet modules
> don't do it.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-08-29  4:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-28 13:16 [PATCH net-next] hinic: don't build the module by default Vitaly Kuznetsov
2017-08-29  4:40 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.