* [PATCH net-next] net: bcmgenet: Do not return from void function
@ 2017-08-30 4:48 Florian Fainelli
2017-08-30 5:40 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2017-08-30 4:48 UTC (permalink / raw)
To: netdev; +Cc: davem, opendmb, Florian Fainelli
A stray return was added in the macro bcmgenet_##name##_writel where it
should not, drop it.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Fixes: 69d2ea9c7989 ("net: bcmgenet: Use correct I/O accessors")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/ethernet/broadcom/genet/bcmgenet.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.h b/drivers/net/ethernet/broadcom/genet/bcmgenet.h
index 2bfeaefcca0f..4c49d0b97748 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.h
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.h
@@ -684,7 +684,7 @@ static inline void bcmgenet_##name##_writel(struct bcmgenet_priv *priv, \
u32 val, u32 off) \
{ \
if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(CONFIG_CPU_BIG_ENDIAN)) \
- return __raw_writel(val, priv->base + offset + off); \
+ __raw_writel(val, priv->base + offset + off); \
else \
writel_relaxed(val, priv->base + offset + off); \
}
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: bcmgenet: Do not return from void function
2017-08-30 4:48 [PATCH net-next] net: bcmgenet: Do not return from void function Florian Fainelli
@ 2017-08-30 5:40 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-08-30 5:40 UTC (permalink / raw)
To: f.fainelli; +Cc: netdev, davem, opendmb
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue, 29 Aug 2017 21:48:51 -0700
> A stray return was added in the macro bcmgenet_##name##_writel where it
> should not, drop it.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Fixes: 69d2ea9c7989 ("net: bcmgenet: Use correct I/O accessors")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-30 5:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-30 4:48 [PATCH net-next] net: bcmgenet: Do not return from void function Florian Fainelli
2017-08-30 5:40 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.