From: Dong Aisheng <dongas86@gmail.com> To: Rob Herring <robh@kernel.org> Cc: Dong Aisheng <aisheng.dong@nxp.com>, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sboyd@codeaurora.org, vireshk@kernel.org, nm@ti.com, rjw@rjwysocki.net, shawnguo@kernel.org, Anson.Huang@nxp.com, ping.bai@nxp.com, Frank Rowand <frowand.list@gmail.com>, devicetree@vger.kernel.org Subject: Re: [PATCH 2/7] dt-bindings: PM / OPP: add clocks per OPP node support Date: Fri, 1 Sep 2017 21:01:32 +0800 [thread overview] Message-ID: <20170901130132.GA22788@b29396-OptiPlex-7040> (raw) In-Reply-To: <20170831173920.4emtr5vkgvjcx6ac@rob-hp-laptop> On Thu, Aug 31, 2017 at 12:39:20PM -0500, Rob Herring wrote: > On Thu, Aug 24, 2017 at 12:10:05AM +0800, Dong Aisheng wrote: > > It's used for platforms where different OPPs may use different clocks. > > With this extended binding, user could specify the correct clock for each > > OPP node. > > > > Cc: Viresh Kumar <vireshk@kernel.org> > > Cc: Nishanth Menon <nm@ti.com> > > Cc: Stephen Boyd <sboyd@codeaurora.org> > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: Frank Rowand <frowand.list@gmail.com> > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > > --- > > Documentation/devicetree/bindings/opp/opp.txt | 52 +++++++++++++++++++++++++++ > > 1 file changed, 52 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt > > index e36d261..40a4340 100644 > > --- a/Documentation/devicetree/bindings/opp/opp.txt > > +++ b/Documentation/devicetree/bindings/opp/opp.txt > > @@ -152,6 +152,11 @@ Optional properties: > > hierarchy can be contained in multiple 32 bit values. i.e. <X Y Z1 Z2> in the > > above example, Z1 & Z2 refer to the version hierarchy Z. > > > > +- clocks: Clock phandle and specifier used for this opp. > > + > > +- clock-names: clock names for this opp. The valid clock names are platform > > + specific. > > You don't need -names if there's only 1 clock. Got it, will remove -name. > But then how long until > we have a list of any random clocks some how associated with an OPP. > Not sure whether it will really happen in the future. Even it happens, as we usually only need the device parent clock, then probably better to handle the left complicated things in clock driver or OPP device driver. > I think this should really be solved within the clock framework. What > you really need is "set my parent clock to the source that can provide X > Hz". Could the assigned-clocks property work here (in the OPP nodes > rather than the cpu nodes)? > I'm not quite sure i got your point. assigned-clocks seems a bit like function the same as clocks property here, both are used to specifying the device parent clock which provide X hz. Or are you suggesting using assigned-clocks/assigned-clocks-rates instread of clocks/opp-hz? Would you please clarify a bit more? > > + > > - status: Marks the node enabled/disabled. > > > > Example 1: Single cluster Dual-core ARM cortex A9, switch DVFS states together. > > @@ -528,3 +533,50 @@ Example 6: opp-microvolt-<name>, opp-microamp-<name>: > > }; > > }; > > }; > > + > > +Example 7: Single core ARM cortex A7, switch separate clocks for each OPP: > > Can't you add this to an existing example? We don't need to enumerate > every possible option. Okay, Will merge it. Thanks Regards Dong Aisheng > > Rob
WARNING: multiple messages have this Message-ID (diff)
From: dongas86@gmail.com (Dong Aisheng) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/7] dt-bindings: PM / OPP: add clocks per OPP node support Date: Fri, 1 Sep 2017 21:01:32 +0800 [thread overview] Message-ID: <20170901130132.GA22788@b29396-OptiPlex-7040> (raw) In-Reply-To: <20170831173920.4emtr5vkgvjcx6ac@rob-hp-laptop> On Thu, Aug 31, 2017 at 12:39:20PM -0500, Rob Herring wrote: > On Thu, Aug 24, 2017 at 12:10:05AM +0800, Dong Aisheng wrote: > > It's used for platforms where different OPPs may use different clocks. > > With this extended binding, user could specify the correct clock for each > > OPP node. > > > > Cc: Viresh Kumar <vireshk@kernel.org> > > Cc: Nishanth Menon <nm@ti.com> > > Cc: Stephen Boyd <sboyd@codeaurora.org> > > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: Frank Rowand <frowand.list@gmail.com> > > Cc: devicetree at vger.kernel.org > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > > --- > > Documentation/devicetree/bindings/opp/opp.txt | 52 +++++++++++++++++++++++++++ > > 1 file changed, 52 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt > > index e36d261..40a4340 100644 > > --- a/Documentation/devicetree/bindings/opp/opp.txt > > +++ b/Documentation/devicetree/bindings/opp/opp.txt > > @@ -152,6 +152,11 @@ Optional properties: > > hierarchy can be contained in multiple 32 bit values. i.e. <X Y Z1 Z2> in the > > above example, Z1 & Z2 refer to the version hierarchy Z. > > > > +- clocks: Clock phandle and specifier used for this opp. > > + > > +- clock-names: clock names for this opp. The valid clock names are platform > > + specific. > > You don't need -names if there's only 1 clock. Got it, will remove -name. > But then how long until > we have a list of any random clocks some how associated with an OPP. > Not sure whether it will really happen in the future. Even it happens, as we usually only need the device parent clock, then probably better to handle the left complicated things in clock driver or OPP device driver. > I think this should really be solved within the clock framework. What > you really need is "set my parent clock to the source that can provide X > Hz". Could the assigned-clocks property work here (in the OPP nodes > rather than the cpu nodes)? > I'm not quite sure i got your point. assigned-clocks seems a bit like function the same as clocks property here, both are used to specifying the device parent clock which provide X hz. Or are you suggesting using assigned-clocks/assigned-clocks-rates instread of clocks/opp-hz? Would you please clarify a bit more? > > + > > - status: Marks the node enabled/disabled. > > > > Example 1: Single cluster Dual-core ARM cortex A9, switch DVFS states together. > > @@ -528,3 +533,50 @@ Example 6: opp-microvolt-<name>, opp-microamp-<name>: > > }; > > }; > > }; > > + > > +Example 7: Single core ARM cortex A7, switch separate clocks for each OPP: > > Can't you add this to an existing example? We don't need to enumerate > every possible option. Okay, Will merge it. Thanks Regards Dong Aisheng > > Rob
next prev parent reply other threads:[~2017-09-01 13:01 UTC|newest] Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-23 16:10 [PATCH 0/7] PM / OPP: per OPP node clock support and imx7ulp cpufreq driver Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` [PATCH 1/7] PM / OPP: Add platform specific set_clk function Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-09-19 22:58 ` Viresh Kumar 2017-09-19 22:58 ` Viresh Kumar 2017-09-20 7:03 ` Dong Aisheng 2017-09-20 7:03 ` Dong Aisheng 2017-09-20 20:30 ` Viresh Kumar 2017-09-20 20:30 ` Viresh Kumar 2017-09-21 2:17 ` A.s. Dong 2017-09-21 2:17 ` A.s. Dong 2017-09-21 2:17 ` A.s. Dong 2017-08-23 16:10 ` [PATCH 2/7] dt-bindings: PM / OPP: add clocks per OPP node support Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-31 17:39 ` Rob Herring 2017-08-31 17:39 ` Rob Herring 2017-09-01 13:01 ` Dong Aisheng [this message] 2017-09-01 13:01 ` Dong Aisheng 2017-08-23 16:10 ` [PATCH 3/7] PM / OPP: rename opp_table->clk to opp_table->cur_clk Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` [PATCH 4/7] PM / OPP: use OPP node clock to set CPU frequency Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` [PATCH 5/7] PM / OPP: Add dev_pm_opp_get_cur_clk() Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` [PATCH 6/7] cpufreq: make cpufreq_generic_init transition_latency default to CPUFREQ_ETERNAL Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-09-19 23:10 ` Viresh Kumar 2017-09-19 23:10 ` Viresh Kumar 2017-09-20 7:04 ` Dong Aisheng 2017-09-20 7:04 ` Dong Aisheng 2017-09-20 14:45 ` Viresh Kumar 2017-09-20 14:45 ` Viresh Kumar 2017-08-23 16:10 ` [PATCH 7/7] cpufreq: add imx7ulp cpufreq driver Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-08-23 16:10 ` Dong Aisheng 2017-09-11 7:28 ` [PATCH 0/7] PM / OPP: per OPP node clock support and " Dong Aisheng 2017-09-11 7:28 ` Dong Aisheng 2017-09-19 22:54 ` Viresh Kumar 2017-09-19 22:54 ` Viresh Kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170901130132.GA22788@b29396-OptiPlex-7040 \ --to=dongas86@gmail.com \ --cc=Anson.Huang@nxp.com \ --cc=aisheng.dong@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=frowand.list@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=nm@ti.com \ --cc=ping.bai@nxp.com \ --cc=rjw@rjwysocki.net \ --cc=robh@kernel.org \ --cc=sboyd@codeaurora.org \ --cc=shawnguo@kernel.org \ --cc=vireshk@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.