From: Yury Norov <ynorov@caviumnetworks.com> To: Volodymyr Babchuk <volodymyr_babchuk@epam.com> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tee-dev@lists.linaro.org, Jens Wiklander <jens.wiklander@linaro.org>, Volodymyr Babchuk <vlad.babchuk@gmail.com> Subject: Re: [PATCH v1 06/14] tee: optee: add page list manipulation functions Date: Fri, 29 Sep 2017 03:23:00 +0300 [thread overview] Message-ID: <20170929002300.zxu4n47m5jdymdyt@yury-thinkpad> (raw) In-Reply-To: <1506621851-6929-7-git-send-email-volodymyr_babchuk@epam.com> On Thu, Sep 28, 2017 at 09:04:03PM +0300, Volodymyr Babchuk wrote: > From: Volodymyr Babchuk <vlad.babchuk@gmail.com> > > These functions will be used to pass information about shared > buffers to OP-TEE. > > Signed-off-by: Volodymyr Babchuk <vlad.babchuk@gmail.com> > --- > drivers/tee/optee/call.c | 48 +++++++++++++++++++++++++++++++++++++++ > drivers/tee/optee/optee_private.h | 4 ++++ > 2 files changed, 52 insertions(+) > > diff --git a/drivers/tee/optee/call.c b/drivers/tee/optee/call.c > index f7b7b40..f8e044d 100644 > --- a/drivers/tee/optee/call.c > +++ b/drivers/tee/optee/call.c > @@ -11,6 +11,7 @@ > * GNU General Public License for more details. > * > */ > +#include <asm/pgtable.h> > #include <linux/arm-smccc.h> > #include <linux/device.h> > #include <linux/err.h> > @@ -442,3 +443,50 @@ void optee_disable_shm_cache(struct optee *optee) > } > optee_cq_wait_final(&optee->call_queue, &w); > } > + > +/** > + * optee_fill_pages_list() - write list of user pages to given shared > + * buffer. > + * > + * @dst: page-aligned buffer where list of pages will be stored I'm not much familiar with the subsystem you work on, but I don't understand why the type of dst is u64*. If it's just a buffer, it should be void *. Also, if we assuming running it on arm were pointers are 32-bit, the result of page_to_phys() will be u32, and you will waste half of your u64 array for storing zeroes; this line: *dst = page_to_phys(pages[i]); > + * @pages: array of pages that represents shared buffer > + * @num_pages: number of entries in @pages > + * > + * @dst should be big enough to hold list of user page addresses and > + * links to the next pages of buffer > + */ > +void optee_fill_pages_list(u64 *dst, struct page **pages, size_t num_pages) > +{ > + size_t i; > + > + /* TODO: add support for RichOS page sizes that != 4096 */ > + BUILD_BUG_ON(PAGE_SIZE != OPTEE_MSG_NONCONTIG_PAGE_SIZE); RichOS stands for Linux? Why I am still not a rich OS developer? :) This is the first occurrence of the term in kernel sources, please explain it. Also, I think that it would be more logical to add the dependency on page size to Kconfig, not here, and move the comment there, so user will be simply unable to build the whole module. > + for (i = 0; i < num_pages; i++, dst++) { > + /* Check if we are going to roll over the page boundary */ > + if (IS_ALIGNED((uintptr_t)(dst + 1), > + OPTEE_MSG_NONCONTIG_PAGE_SIZE)) { > + *dst = virt_to_phys(dst + 1); > + dst++; > + } Is my understanding correct that @dst is not a simple array of buffer page addresses? Instead, it has a complex structure: First 511 records store buffer page entries, and last one points to the next page of dst. Is it somehow documented? Also, did you consider to create a header structure for the buffer page, like memory allocators do? You can place there number of entries, pointer to the next page, maybe some flags. I think it will be more transparent, especially if we consider communication protocol between independent software products. > + *dst = page_to_phys(pages[i]); > + } > +} > + > +static size_t get_pages_array_size(size_t num_entries) > +{ > + /* Number of user pages + number of pages to hold list of user pages */ > + return sizeof(u64) * > + (num_entries + (sizeof(u64) * num_entries) / > + OPTEE_MSG_NONCONTIG_PAGE_SIZE); > +} > + > +u64 *optee_allocate_pages_array(size_t num_entries) > +{ > + return alloc_pages_exact(get_pages_array_size(num_entries), GFP_KERNEL); > +} > + > +void optee_free_pages_array(void *array, size_t num_entries) > +{ > + free_pages_exact(array, get_pages_array_size(num_entries)); > +} > + > diff --git a/drivers/tee/optee/optee_private.h b/drivers/tee/optee/optee_private.h > index c374cd5..caa3c04 100644 > --- a/drivers/tee/optee/optee_private.h > +++ b/drivers/tee/optee/optee_private.h > @@ -165,6 +165,10 @@ int optee_from_msg_param(struct tee_param *params, size_t num_params, > int optee_to_msg_param(struct optee_msg_param *msg_params, size_t num_params, > const struct tee_param *params); > > +u64 *optee_allocate_pages_array(size_t num_entries); > +void optee_free_pages_array(void *array, size_t num_entries); > +void optee_fill_pages_list(u64 *dst, struct page **pages, size_t num_pages); > + > /* > * Small helpers > */ > -- > 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: ynorov@caviumnetworks.com (Yury Norov) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v1 06/14] tee: optee: add page list manipulation functions Date: Fri, 29 Sep 2017 03:23:00 +0300 [thread overview] Message-ID: <20170929002300.zxu4n47m5jdymdyt@yury-thinkpad> (raw) In-Reply-To: <1506621851-6929-7-git-send-email-volodymyr_babchuk@epam.com> On Thu, Sep 28, 2017 at 09:04:03PM +0300, Volodymyr Babchuk wrote: > From: Volodymyr Babchuk <vlad.babchuk@gmail.com> > > These functions will be used to pass information about shared > buffers to OP-TEE. > > Signed-off-by: Volodymyr Babchuk <vlad.babchuk@gmail.com> > --- > drivers/tee/optee/call.c | 48 +++++++++++++++++++++++++++++++++++++++ > drivers/tee/optee/optee_private.h | 4 ++++ > 2 files changed, 52 insertions(+) > > diff --git a/drivers/tee/optee/call.c b/drivers/tee/optee/call.c > index f7b7b40..f8e044d 100644 > --- a/drivers/tee/optee/call.c > +++ b/drivers/tee/optee/call.c > @@ -11,6 +11,7 @@ > * GNU General Public License for more details. > * > */ > +#include <asm/pgtable.h> > #include <linux/arm-smccc.h> > #include <linux/device.h> > #include <linux/err.h> > @@ -442,3 +443,50 @@ void optee_disable_shm_cache(struct optee *optee) > } > optee_cq_wait_final(&optee->call_queue, &w); > } > + > +/** > + * optee_fill_pages_list() - write list of user pages to given shared > + * buffer. > + * > + * @dst: page-aligned buffer where list of pages will be stored I'm not much familiar with the subsystem you work on, but I don't understand why the type of dst is u64*. If it's just a buffer, it should be void *. Also, if we assuming running it on arm were pointers are 32-bit, the result of page_to_phys() will be u32, and you will waste half of your u64 array for storing zeroes; this line: *dst = page_to_phys(pages[i]); > + * @pages: array of pages that represents shared buffer > + * @num_pages: number of entries in @pages > + * > + * @dst should be big enough to hold list of user page addresses and > + * links to the next pages of buffer > + */ > +void optee_fill_pages_list(u64 *dst, struct page **pages, size_t num_pages) > +{ > + size_t i; > + > + /* TODO: add support for RichOS page sizes that != 4096 */ > + BUILD_BUG_ON(PAGE_SIZE != OPTEE_MSG_NONCONTIG_PAGE_SIZE); RichOS stands for Linux? Why I am still not a rich OS developer? :) This is the first occurrence of the term in kernel sources, please explain it. Also, I think that it would be more logical to add the dependency on page size to Kconfig, not here, and move the comment there, so user will be simply unable to build the whole module. > + for (i = 0; i < num_pages; i++, dst++) { > + /* Check if we are going to roll over the page boundary */ > + if (IS_ALIGNED((uintptr_t)(dst + 1), > + OPTEE_MSG_NONCONTIG_PAGE_SIZE)) { > + *dst = virt_to_phys(dst + 1); > + dst++; > + } Is my understanding correct that @dst is not a simple array of buffer page addresses? Instead, it has a complex structure: First 511 records store buffer page entries, and last one points to the next page of dst. Is it somehow documented? Also, did you consider to create a header structure for the buffer page, like memory allocators do? You can place there number of entries, pointer to the next page, maybe some flags. I think it will be more transparent, especially if we consider communication protocol between independent software products. > + *dst = page_to_phys(pages[i]); > + } > +} > + > +static size_t get_pages_array_size(size_t num_entries) > +{ > + /* Number of user pages + number of pages to hold list of user pages */ > + return sizeof(u64) * > + (num_entries + (sizeof(u64) * num_entries) / > + OPTEE_MSG_NONCONTIG_PAGE_SIZE); > +} > + > +u64 *optee_allocate_pages_array(size_t num_entries) > +{ > + return alloc_pages_exact(get_pages_array_size(num_entries), GFP_KERNEL); > +} > + > +void optee_free_pages_array(void *array, size_t num_entries) > +{ > + free_pages_exact(array, get_pages_array_size(num_entries)); > +} > + > diff --git a/drivers/tee/optee/optee_private.h b/drivers/tee/optee/optee_private.h > index c374cd5..caa3c04 100644 > --- a/drivers/tee/optee/optee_private.h > +++ b/drivers/tee/optee/optee_private.h > @@ -165,6 +165,10 @@ int optee_from_msg_param(struct tee_param *params, size_t num_params, > int optee_to_msg_param(struct optee_msg_param *msg_params, size_t num_params, > const struct tee_param *params); > > +u64 *optee_allocate_pages_array(size_t num_entries); > +void optee_free_pages_array(void *array, size_t num_entries); > +void optee_fill_pages_list(u64 *dst, struct page **pages, size_t num_pages); > + > /* > * Small helpers > */ > -- > 2.7.4
next prev parent reply other threads:[~2017-09-29 0:23 UTC|newest] Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-28 18:03 [PATCH v1 00/14] tee: optee: add dynamic shared memory support Volodymyr Babchuk 2017-09-28 18:03 ` Volodymyr Babchuk 2017-09-28 18:03 ` [PATCH v1 01/14] tee: flexible shared memory pool creation Volodymyr Babchuk 2017-09-28 18:03 ` Volodymyr Babchuk 2017-09-28 18:03 ` [PATCH v1 02/14] tee: add register user memory Volodymyr Babchuk 2017-09-28 18:03 ` Volodymyr Babchuk 2017-09-29 10:53 ` Mark Rutland 2017-09-29 10:53 ` Mark Rutland 2017-09-29 15:19 ` Volodymyr Babchuk 2017-09-29 15:19 ` Volodymyr Babchuk 2017-09-28 18:04 ` [PATCH v1 03/14] tee: shm: add accessors for buffer size and page offset Volodymyr Babchuk 2017-09-28 18:04 ` Volodymyr Babchuk 2017-09-28 18:04 ` [PATCH v1 04/14] tee: shm: add page accessor functions Volodymyr Babchuk 2017-09-28 18:04 ` Volodymyr Babchuk 2017-09-28 22:14 ` Yury Norov 2017-09-28 22:14 ` Yury Norov 2017-09-29 10:17 ` Volodymyr Babchuk 2017-09-29 10:17 ` Volodymyr Babchuk 2017-09-28 18:04 ` [PATCH v1 05/14] tee: optee: Update protocol definitions Volodymyr Babchuk 2017-09-28 18:04 ` Volodymyr Babchuk 2017-09-28 18:04 ` [PATCH v1 06/14] tee: optee: add page list manipulation functions Volodymyr Babchuk 2017-09-28 18:04 ` Volodymyr Babchuk 2017-09-29 0:23 ` Yury Norov [this message] 2017-09-29 0:23 ` Yury Norov 2017-09-29 10:34 ` Volodymyr Babchuk 2017-09-29 10:34 ` Volodymyr Babchuk 2017-09-29 16:23 ` Yury Norov 2017-09-29 16:23 ` Yury Norov 2017-09-29 13:00 ` Mark Rutland 2017-09-29 13:00 ` Mark Rutland 2017-09-28 18:04 ` [PATCH v1 07/14] tee: optee: add shared buffer registration functions Volodymyr Babchuk 2017-09-28 18:04 ` Volodymyr Babchuk 2017-09-29 13:06 ` Mark Rutland 2017-09-29 13:06 ` Mark Rutland 2017-09-29 15:37 ` Volodymyr Babchuk 2017-09-29 15:37 ` Volodymyr Babchuk 2017-09-28 18:04 ` [PATCH v1 08/14] tee: optee: add registered shared parameters handling Volodymyr Babchuk 2017-09-28 18:04 ` Volodymyr Babchuk 2017-09-28 18:04 ` [PATCH v1 09/14] tee: optee: add registered buffers handling into RPC calls Volodymyr Babchuk 2017-09-28 18:04 ` Volodymyr Babchuk 2017-09-28 18:04 ` [PATCH v1 10/14] tee: optee: store OP-TEE capabilities in private data Volodymyr Babchuk 2017-09-28 18:04 ` Volodymyr Babchuk 2017-09-28 18:04 ` [PATCH v1 11/14] tee: optee: add optee-specific shared pool implementation Volodymyr Babchuk 2017-09-28 18:04 ` Volodymyr Babchuk 2017-09-28 18:04 ` [PATCH v1 12/14] tee: optee: enable dynamic SHM support Volodymyr Babchuk 2017-09-28 18:04 ` Volodymyr Babchuk 2017-10-03 16:06 ` [Tee-dev] " Stuart Yoder 2017-10-03 16:06 ` Stuart Yoder 2017-10-04 11:49 ` Jens Wiklander 2017-10-04 11:49 ` Jens Wiklander 2017-09-28 18:04 ` [PATCH v1 13/14] tee: use reference counting for tee_context Volodymyr Babchuk 2017-09-28 18:04 ` Volodymyr Babchuk 2017-09-28 18:04 ` [PATCH v1 14/14] tee: shm: inline tee_shm getter functions Volodymyr Babchuk 2017-09-28 18:04 ` Volodymyr Babchuk 2017-09-29 0:50 ` Yury Norov 2017-09-29 0:50 ` Yury Norov 2017-09-29 10:31 ` [PATCH v1 00/14] tee: optee: add dynamic shared memory support Mark Rutland 2017-09-29 10:31 ` Mark Rutland 2017-09-29 10:51 ` Volodymyr Babchuk 2017-09-29 10:51 ` Volodymyr Babchuk 2017-10-03 16:05 ` [Tee-dev] " Stuart Yoder 2017-10-03 16:05 ` Stuart Yoder 2017-10-04 17:23 ` Volodymyr Babchuk 2017-10-04 17:23 ` Volodymyr Babchuk 2017-10-13 19:32 ` Volodymyr Babchuk 2017-10-13 19:32 ` Volodymyr Babchuk 2017-10-13 19:32 ` [PATCH v1 01/14] tee: flexible shared memory pool creation Volodymyr Babchuk 2017-10-13 19:32 ` Volodymyr Babchuk 2017-10-13 19:32 ` [PATCH v1 02/14] tee: add register user memory Volodymyr Babchuk 2017-10-13 19:32 ` Volodymyr Babchuk 2017-10-13 19:32 ` [PATCH v1 03/14] tee: shm: add accessors for buffer size and page offset Volodymyr Babchuk 2017-10-13 19:32 ` Volodymyr Babchuk 2017-10-13 19:32 ` [PATCH v1 04/14] tee: shm: add page accessor functions Volodymyr Babchuk 2017-10-13 19:32 ` Volodymyr Babchuk 2017-10-13 19:32 ` [PATCH v1 05/14] tee: optee: Update protocol definitions Volodymyr Babchuk 2017-10-13 19:32 ` Volodymyr Babchuk 2017-10-13 19:32 ` [PATCH v1 06/14] tee: optee: add page list manipulation functions Volodymyr Babchuk 2017-10-13 19:32 ` Volodymyr Babchuk 2017-10-13 19:32 ` [PATCH v1 07/14] tee: optee: add shared buffer registration functions Volodymyr Babchuk 2017-10-13 19:32 ` Volodymyr Babchuk 2017-10-13 19:32 ` [PATCH v1 08/14] tee: optee: add registered shared parameters handling Volodymyr Babchuk 2017-10-13 19:32 ` Volodymyr Babchuk 2017-10-13 19:32 ` [PATCH v1 09/14] tee: optee: add registered buffers handling into RPC calls Volodymyr Babchuk 2017-10-13 19:32 ` Volodymyr Babchuk 2017-10-13 19:32 ` [PATCH v1 10/14] tee: optee: store OP-TEE capabilities in private data Volodymyr Babchuk 2017-10-13 19:32 ` Volodymyr Babchuk 2017-10-13 19:32 ` [PATCH v1 11/14] tee: optee: add optee-specific shared pool implementation Volodymyr Babchuk 2017-10-13 19:32 ` Volodymyr Babchuk 2017-10-13 19:32 ` [PATCH v1 12/14] tee: optee: enable dynamic SHM support Volodymyr Babchuk 2017-10-13 19:32 ` Volodymyr Babchuk 2017-10-13 19:32 ` [PATCH v1 13/14] tee: use reference counting for tee_context Volodymyr Babchuk 2017-10-13 19:32 ` Volodymyr Babchuk 2017-10-13 19:32 ` [PATCH v1 14/14] tee: shm: inline tee_shm_get_id() Volodymyr Babchuk 2017-10-13 19:32 ` Volodymyr Babchuk 2017-10-13 19:40 ` [PATCH v1 00/14] tee: optee: add dynamic shared memory support Volodymyr Babchuk 2017-10-13 19:40 ` Volodymyr Babchuk 2017-11-29 12:48 ` [RESEND PATCH v2 " Volodymyr Babchuk 2017-11-29 12:48 ` Volodymyr Babchuk 2017-11-29 12:48 ` [RESEND PATCH v2 01/14] tee: flexible shared memory pool creation Volodymyr Babchuk 2017-11-29 12:48 ` Volodymyr Babchuk 2017-11-29 12:48 ` [RESEND PATCH v2 02/14] tee: add register user memory Volodymyr Babchuk 2017-11-29 12:48 ` Volodymyr Babchuk 2017-11-29 12:48 ` [RESEND PATCH v2 03/14] tee: shm: add accessors for buffer size and page offset Volodymyr Babchuk 2017-11-29 12:48 ` Volodymyr Babchuk 2017-11-29 12:48 ` [RESEND PATCH v2 04/14] tee: shm: add page accessor functions Volodymyr Babchuk 2017-11-29 12:48 ` Volodymyr Babchuk 2017-11-29 12:48 ` [RESEND PATCH v2 05/14] tee: optee: Update protocol definitions Volodymyr Babchuk 2017-11-29 12:48 ` Volodymyr Babchuk 2017-11-29 12:48 ` [RESEND PATCH v2 06/14] tee: optee: add page list manipulation functions Volodymyr Babchuk 2017-11-29 12:48 ` Volodymyr Babchuk 2017-11-29 12:48 ` [RESEND PATCH v2 07/14] tee: optee: add shared buffer registration functions Volodymyr Babchuk 2017-11-29 12:48 ` Volodymyr Babchuk 2017-11-29 12:48 ` [RESEND PATCH v2 08/14] tee: optee: add registered shared parameters handling Volodymyr Babchuk 2017-11-29 12:48 ` Volodymyr Babchuk 2017-11-29 12:48 ` [RESEND PATCH v2 09/14] tee: optee: add registered buffers handling into RPC calls Volodymyr Babchuk 2017-11-29 12:48 ` Volodymyr Babchuk 2017-11-29 12:48 ` [RESEND PATCH v2 10/14] tee: optee: store OP-TEE capabilities in private data Volodymyr Babchuk 2017-11-29 12:48 ` Volodymyr Babchuk 2017-11-29 12:48 ` [RESEND PATCH v2 11/14] tee: optee: add optee-specific shared pool implementation Volodymyr Babchuk 2017-11-29 12:48 ` Volodymyr Babchuk 2017-11-29 12:48 ` [RESEND PATCH v2 12/14] tee: optee: enable dynamic SHM support Volodymyr Babchuk 2017-11-29 12:48 ` Volodymyr Babchuk 2017-11-29 12:48 ` [RESEND PATCH v2 13/14] tee: use reference counting for tee_context Volodymyr Babchuk 2017-11-29 12:48 ` Volodymyr Babchuk 2017-11-29 12:48 ` [RESEND PATCH v2 14/14] tee: shm: inline tee_shm_get_id() Volodymyr Babchuk 2017-11-29 12:48 ` Volodymyr Babchuk 2017-12-06 14:32 ` [RESEND PATCH v2 00/14] tee: optee: add dynamic shared memory support Jens Wiklander 2017-12-06 14:32 ` Jens Wiklander
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170929002300.zxu4n47m5jdymdyt@yury-thinkpad \ --to=ynorov@caviumnetworks.com \ --cc=jens.wiklander@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=tee-dev@lists.linaro.org \ --cc=vlad.babchuk@gmail.com \ --cc=volodymyr_babchuk@epam.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.