From: Andrew Morton <akpm@linux-foundation.org>
To: Jan Kara <jack@suse.cz>
Cc: <linux-mm@kvack.org>, Mel Gorman <mgorman@suse.de>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
<linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 7/7] mm: Batch radix tree operations when truncating pages
Date: Tue, 17 Oct 2017 16:05:21 -0700 [thread overview]
Message-ID: <20171017160521.33ca85c45431c355833daa63@linux-foundation.org> (raw)
In-Reply-To: <20171010151937.26984-8-jack@suse.cz>
On Tue, 10 Oct 2017 17:19:37 +0200 Jan Kara <jack@suse.cz> wrote:
> --- a/mm/truncate.c
> +++ b/mm/truncate.c
> @@ -294,6 +294,14 @@ void truncate_inode_pages_range(struct address_space *mapping,
> while (index < end && pagevec_lookup_entries(&pvec, mapping, index,
> min(end - index, (pgoff_t)PAGEVEC_SIZE),
> indices)) {
> + /*
> + * Pagevec array has exceptional entries and we may also fail
> + * to lock some pages. So we store pages that can be deleted
> + * in an extra array.
> + */
> + struct page *pages[PAGEVEC_SIZE];
> + int batch_count = 0;
OK, but we could still use a new pagevec here. Then
delete_from_page_cache_batch() and page_cache_tree_delete_batch() would
take one less argument.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-mm@kvack.org, Mel Gorman <mgorman@suse.de>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 7/7] mm: Batch radix tree operations when truncating pages
Date: Tue, 17 Oct 2017 16:05:21 -0700 [thread overview]
Message-ID: <20171017160521.33ca85c45431c355833daa63@linux-foundation.org> (raw)
In-Reply-To: <20171010151937.26984-8-jack@suse.cz>
On Tue, 10 Oct 2017 17:19:37 +0200 Jan Kara <jack@suse.cz> wrote:
> --- a/mm/truncate.c
> +++ b/mm/truncate.c
> @@ -294,6 +294,14 @@ void truncate_inode_pages_range(struct address_space *mapping,
> while (index < end && pagevec_lookup_entries(&pvec, mapping, index,
> min(end - index, (pgoff_t)PAGEVEC_SIZE),
> indices)) {
> + /*
> + * Pagevec array has exceptional entries and we may also fail
> + * to lock some pages. So we store pages that can be deleted
> + * in an extra array.
> + */
> + struct page *pages[PAGEVEC_SIZE];
> + int batch_count = 0;
OK, but we could still use a new pagevec here. Then
delete_from_page_cache_batch() and page_cache_tree_delete_batch() would
take one less argument.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-10-17 23:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 15:19 [PATCH 0/7 v1] Speed up page cache truncation Jan Kara
2017-10-10 15:19 ` Jan Kara
2017-10-10 15:19 ` [PATCH 1/7] mm: Speedup cancel_dirty_page() for clean pages Jan Kara
2017-10-10 15:19 ` Jan Kara
2017-10-10 15:19 ` [PATCH 2/7] mm: Refactor truncate_complete_page() Jan Kara
2017-10-10 15:19 ` Jan Kara
2017-10-10 15:19 ` [PATCH 3/7] mm: Factor out page cache page freeing into a separate function Jan Kara
2017-10-10 15:19 ` Jan Kara
2017-10-10 15:19 ` [PATCH 4/7] mm: Move accounting updates before page_cache_tree_delete() Jan Kara
2017-10-10 15:19 ` Jan Kara
2017-10-10 15:19 ` [PATCH 5/7] mm: Move clearing of page->mapping to page_cache_tree_delete() Jan Kara
2017-10-10 15:19 ` Jan Kara
2017-10-10 15:19 ` [PATCH 6/7] mm: Factor out checks and accounting from __delete_from_page_cache() Jan Kara
2017-10-10 15:19 ` Jan Kara
2017-10-10 15:19 ` [PATCH 7/7] mm: Batch radix tree operations when truncating pages Jan Kara
2017-10-10 15:19 ` Jan Kara
2017-10-11 7:39 ` Mel Gorman
2017-10-17 23:05 ` Andrew Morton [this message]
2017-10-17 23:05 ` Andrew Morton
2017-10-18 10:44 ` Jan Kara
2017-10-10 17:25 ` [PATCH 0/7 v1] Speed up page cache truncation Andi Kleen
2017-10-10 17:25 ` Andi Kleen
2017-10-11 8:06 ` Jan Kara
2017-10-11 16:51 ` Andi Kleen
2017-10-11 17:34 ` Dave Hansen
2017-10-11 17:59 ` Mel Gorman
2017-10-11 18:37 ` Andi Kleen
2017-10-11 21:06 ` Jan Kara
2017-10-11 21:24 ` Dave Chinner
2017-10-12 9:09 ` Mel Gorman
2017-10-12 14:07 ` Jan Kara
2017-10-17 16:21 [PATCH 0/7 v2] " Jan Kara
2017-10-17 16:21 ` [PATCH 7/7] mm: Batch radix tree operations when truncating pages Jan Kara
2017-10-17 16:21 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017160521.33ca85c45431c355833daa63@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.