All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Morse <james.morse@arm.com>
To: linux-acpi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, x86@kernel.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
	Borislav Petkov <bp@suse.de>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>, Tony Luck <tony.luck@intel.com>,
	Tyler Baicar <tbaicar@codeaurora.org>,
	Dongjiu Geng <gengdongjiu@huawei.com>,
	Xie XiuQi <xiexiuqi@huawei.com>,
	torvalds@linux-foundation.org, James Morse <james.morse@arm.com>
Subject: [RFC/RFT PATCH 5/6] arm64: mm: Remove arch_apei_flush_tlb_one()
Date: Tue, 31 Oct 2017 15:38:31 +0000	[thread overview]
Message-ID: <20171031153832.17746-6-james.morse@arm.com> (raw)
In-Reply-To: <20171031153832.17746-1-james.morse@arm.com>

Nothing calls arch_apei_flush_tlb_one() anymore, instead relying on
__set_fixmap() to do the invalidation. Remove it.

Move the IPI-considered-harmful comment to __set_fixmap().

Signed-off-by: James Morse <james.morse@arm.com>
---
 arch/arm64/include/asm/acpi.h | 12 ------------
 arch/arm64/mm/mmu.c           |  4 ++++
 2 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h
index 59cca1d6ec54..32f465a80e4e 100644
--- a/arch/arm64/include/asm/acpi.h
+++ b/arch/arm64/include/asm/acpi.h
@@ -126,18 +126,6 @@ static inline const char *acpi_get_enable_method(int cpu)
  */
 #define acpi_disable_cmcff 1
 pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr);
-
-/*
- * Despite its name, this function must still broadcast the TLB
- * invalidation in order to ensure other CPUs don't end up with junk
- * entries as a result of speculation. Unusually, its also called in
- * IRQ context (ghes_iounmap_irq) so if we ever need to use IPIs for
- * TLB broadcasting, then we're in trouble here.
- */
-static inline void arch_apei_flush_tlb_one(unsigned long addr)
-{
-	flush_tlb_kernel_range(addr, addr + PAGE_SIZE);
-}
 #endif /* CONFIG_ACPI_APEI */
 
 #ifdef CONFIG_ACPI_NUMA
diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
index f1eb15e0e864..267d2b79d52d 100644
--- a/arch/arm64/mm/mmu.c
+++ b/arch/arm64/mm/mmu.c
@@ -778,6 +778,10 @@ void __init early_fixmap_init(void)
 	}
 }
 
+/*
+ * Unusually, this is also called in IRQ context (ghes_iounmap_irq) so if we
+ * ever need to use IPIs for TLB broadcasting, then we're in trouble here.
+ */
 void __set_fixmap(enum fixed_addresses idx,
 			       phys_addr_t phys, pgprot_t flags)
 {
-- 
2.15.0.rc2

WARNING: multiple messages have this Message-ID (diff)
From: james.morse@arm.com (James Morse)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC/RFT PATCH 5/6] arm64: mm: Remove arch_apei_flush_tlb_one()
Date: Tue, 31 Oct 2017 15:38:31 +0000	[thread overview]
Message-ID: <20171031153832.17746-6-james.morse@arm.com> (raw)
In-Reply-To: <20171031153832.17746-1-james.morse@arm.com>

Nothing calls arch_apei_flush_tlb_one() anymore, instead relying on
__set_fixmap() to do the invalidation. Remove it.

Move the IPI-considered-harmful comment to __set_fixmap().

Signed-off-by: James Morse <james.morse@arm.com>
---
 arch/arm64/include/asm/acpi.h | 12 ------------
 arch/arm64/mm/mmu.c           |  4 ++++
 2 files changed, 4 insertions(+), 12 deletions(-)

diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h
index 59cca1d6ec54..32f465a80e4e 100644
--- a/arch/arm64/include/asm/acpi.h
+++ b/arch/arm64/include/asm/acpi.h
@@ -126,18 +126,6 @@ static inline const char *acpi_get_enable_method(int cpu)
  */
 #define acpi_disable_cmcff 1
 pgprot_t arch_apei_get_mem_attribute(phys_addr_t addr);
-
-/*
- * Despite its name, this function must still broadcast the TLB
- * invalidation in order to ensure other CPUs don't end up with junk
- * entries as a result of speculation. Unusually, its also called in
- * IRQ context (ghes_iounmap_irq) so if we ever need to use IPIs for
- * TLB broadcasting, then we're in trouble here.
- */
-static inline void arch_apei_flush_tlb_one(unsigned long addr)
-{
-	flush_tlb_kernel_range(addr, addr + PAGE_SIZE);
-}
 #endif /* CONFIG_ACPI_APEI */
 
 #ifdef CONFIG_ACPI_NUMA
diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
index f1eb15e0e864..267d2b79d52d 100644
--- a/arch/arm64/mm/mmu.c
+++ b/arch/arm64/mm/mmu.c
@@ -778,6 +778,10 @@ void __init early_fixmap_init(void)
 	}
 }
 
+/*
+ * Unusually, this is also called in IRQ context (ghes_iounmap_irq) so if we
+ * ever need to use IPIs for TLB broadcasting, then we're in trouble here.
+ */
 void __set_fixmap(enum fixed_addresses idx,
 			       phys_addr_t phys, pgprot_t flags)
 {
-- 
2.15.0.rc2

  parent reply	other threads:[~2017-10-31 15:38 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-31 15:38 [RFC/RFT PATCH 0/6] Switch GHES ioremap_page_range() to use fixmap James Morse
2017-10-31 15:38 ` James Morse
2017-10-31 15:38 ` [RFC/RFT PATCH 1/6] arm64: fixmap: Add GHES fixmap entries James Morse
2017-10-31 15:38   ` James Morse
2017-10-31 15:38 ` [RFC/RFT PATCH 2/6] x86/mm/fixmap: " James Morse
2017-10-31 15:38   ` James Morse
2017-10-31 19:04   ` Ingo Molnar
2017-10-31 19:04     ` Ingo Molnar
2017-10-31 19:09   ` Borislav Petkov
2017-10-31 19:09     ` Borislav Petkov
2017-10-31 15:38 ` [RFC/RFT PATCH 3/6] ACPI / APEI: Replace ioremap_page_range() with fixmap James Morse
2017-10-31 15:38   ` James Morse
2017-11-01  4:13   ` gengdongjiu
2017-11-01  4:13     ` gengdongjiu
2017-11-01  4:13     ` gengdongjiu
2017-11-01 14:57     ` James Morse
2017-11-01 14:57       ` James Morse
2017-11-02 12:01       ` gengdongjiu
2017-11-02 12:01         ` gengdongjiu
2017-11-02 12:01         ` gengdongjiu
2017-11-06 18:41         ` James Morse
2017-11-06 18:41           ` James Morse
2017-11-01 13:34   ` Borislav Petkov
2017-11-01 13:34     ` Borislav Petkov
2017-10-31 15:38 ` [RFC/RFT PATCH 4/6] ACPI / APEI: Remove ghes_ioremap_area James Morse
2017-10-31 15:38   ` James Morse
2017-11-01 13:47   ` Borislav Petkov
2017-11-01 13:47     ` Borislav Petkov
2017-10-31 15:38 ` James Morse [this message]
2017-10-31 15:38   ` [RFC/RFT PATCH 5/6] arm64: mm: Remove arch_apei_flush_tlb_one() James Morse
2017-10-31 15:38 ` [RFC/RFT PATCH 6/6] ACPI / APEI: " James Morse
2017-10-31 15:38   ` James Morse
2017-11-01 13:50   ` Borislav Petkov
2017-11-01 13:50     ` Borislav Petkov
2017-10-31 15:52 ` [RFC/RFT PATCH 0/6] Switch GHES ioremap_page_range() to use fixmap Linus Torvalds
2017-10-31 15:52   ` Linus Torvalds
2017-10-31 15:52   ` Linus Torvalds
2017-10-31 16:05   ` Linus Torvalds
2017-10-31 16:05     ` Linus Torvalds
2017-10-31 16:05     ` Linus Torvalds
2017-11-01 14:58   ` James Morse
2017-11-01 14:58     ` James Morse
2017-11-01 14:58     ` James Morse
2017-10-31 18:46 ` Tyler Baicar
2017-10-31 18:46   ` Tyler Baicar
2017-11-01 14:58 ` James Morse
2017-11-01 14:58   ` James Morse
2017-11-01 15:30   ` Borislav Petkov
2017-11-01 15:30     ` Borislav Petkov
2017-11-01 18:20     ` Kani, Toshimitsu
2017-11-01 18:20       ` Kani, Toshimitsu
2017-11-01 18:20       ` Kani, Toshimitsu
2017-11-06 18:43       ` James Morse
2017-11-06 18:43         ` James Morse
2017-11-06 18:43         ` James Morse
2017-11-02 10:19 ` Will Deacon
2017-11-02 10:19   ` Will Deacon
2017-11-09 12:22 ` Zhengqiang
2017-11-09 12:22   ` Zhengqiang
2017-11-09 12:22   ` Zhengqiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171031153832.17746-6-james.morse@arm.com \
    --to=james.morse@arm.com \
    --cc=bp@suse.de \
    --cc=catalin.marinas@arm.com \
    --cc=gengdongjiu@huawei.com \
    --cc=hpa@zytor.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rjw@rjwysocki.net \
    --cc=tbaicar@codeaurora.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=will.deacon@arm.com \
    --cc=x86@kernel.org \
    --cc=xiexiuqi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.